codecov-commenter
commented
3 months ago Codecov Report
Attention: Patch coverage is 42.85714% with 36 lines in your changes are missing coverage. Please review.
Project coverage is 50.36%. Comparing base (
049c465) to head (3ea6b5c).
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #996 +/- ## ============================================ + Coverage 50.32% 50.36% +0.03% Complexity 644 644 ============================================ Files 87 87 Lines 5210 5266 +56 Branches 666 669 +3 ============================================ + Hits 2622 2652 +30 - Misses 2339 2366 +27 + Partials 249 248 -1 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Description of what I changed
Fixes #995 Please note that only the second commit belongs to this PR; the other commit is from another PR under review.
E2E test
TESTED:
Ran the
/viewfunctionality in the browser and tested it for some samples. Here is an snapshot generated using the patient_flat ViewDefinition:After review related changes:
Checklist: I completed these to help reviewers :)
[x] I have read and will follow the review process.
[x] I am familiar with Google Style Guides for the language I have coded in.
No? Please take some time and review Java and Python style guides.
[x] My IDE is configured to follow the Google code styles.
No? Unsure? -> configure your IDE.
[x] I have added tests to cover my changes. (If you refactored existing code that was well tested you do not have to add tests)
[x] I ran
mvn clean packageright before creating this pull request and added all formatting changes to my commit.[x] All new and existing tests passed.
[x] My pull request is based on the latest changes of the master branch.
No? Unsure? -> execute command
git pull --rebase upstream master