added codecov and minor lints

bashir2 commented 6 months ago

Description of what I changed

This is to enable Codecov on the repo plus some minor lint issues that were fixed by mvn package.

E2E test

TESTED:

Relied on e2e/unit tests.

Checklist: I completed these to help reviewers :)

[x] I have read and will follow the review process.
[x] I am familiar with Google Style Guides for the language I have coded in.

No? Please take some time and review Java and Python style guides.
[x] My IDE is configured to follow the Google code styles.

No? Unsure? -> configure your IDE.
[ ] I have added tests to cover my changes. (If you refactored existing code that was well tested you do not have to add tests)
[x] I ran mvn clean package right before creating this pull request and added all formatting changes to my commit.
[x] All new and existing tests passed.
[x] My pull request is based on the latest changes of the master branch.

No? Unsure? -> execute command git pull --rebase upstream master

codecov-commenter commented 6 months ago

Welcome to Codecov :tada:

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered :open_umbrella:

bashir2 commented 6 months ago

@chandrashekar-s this is similar to the other PR on the fhir-data-pipes side. The main difference is that I did not add a new coverage module in this case as I want to experiment with this approach a little bit.

bashir2 commented 6 months ago

@chandrashekar-s this is similar to the other PR on the fhir-data-pipes side. The main difference is that I did not add a new coverage module in this case as I want to experiment with this approach a little bit.

Please disregard this comment; I added the coverage module for the report-aggregate goal which makes the report more accurate.

chandrashekar-s commented 6 months ago

Just curious, do you know why the coverage report is not added to the PR after the build?

bashir2 commented 5 months ago

Just curious, do you know why the coverage report is not added to the PR after the build?

Not sure; maybe because there was no baseline.

google / fhir-gateway