google / fhir-gateway

A generic proxy server for applying access-control policies for a FHIR-store.
Other
70 stars 28 forks source link

Support for request content mutation. #265

Closed vbothe23 closed 3 months ago

vbothe23 commented 4 months ago

Description of what I changed

Fixes issue: #258

E2E test

TESTED:

Please replace this with a description of how you tested your PR beyond the automated e2e/unit tests.

Checklist: I completed these to help reviewers :)

vbothe23 commented 4 months ago

Hi @bashir2 , As per our discussion, I have raised this draft PR. Please review the changes that I have implemented.

codecov-commenter commented 4 months ago

Codecov Report

Attention: Patch coverage is 62.50000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 69.78%. Comparing base (f0788a6) to head (75d0265).

Files Patch % Lines
...e/fhir/gateway/BearerAuthorizationInterceptor.java 57.14% 1 Missing and 2 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #265 +/- ## ============================================ - Coverage 69.84% 69.78% -0.06% - Complexity 342 343 +1 ============================================ Files 26 26 Lines 1343 1347 +4 Branches 212 214 +2 ============================================ + Hits 938 940 +2 - Misses 318 319 +1 - Partials 87 88 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

vbothe23 commented 3 months ago

Thanks @bashir2, for sharing the concerns about the request mutation. As discussed, we decided to proceed with the prostProcess approach, which mutate the response from the FHIR server, rather than the request data goes into the server. Thus our problem will be solved without these code changes.