Closed vbothe23 closed 3 months ago
Hi @bashir2 , As per our discussion, I have raised this draft PR. Please review the changes that I have implemented.
Attention: Patch coverage is 62.50000%
with 3 lines
in your changes are missing coverage. Please review.
Project coverage is 69.78%. Comparing base (
f0788a6
) to head (75d0265
).
Files | Patch % | Lines |
---|---|---|
...e/fhir/gateway/BearerAuthorizationInterceptor.java | 57.14% | 1 Missing and 2 partials :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks @bashir2, for sharing the concerns about the request mutation. As discussed, we decided to proceed with the prostProcess
approach, which mutate the response from the FHIR server, rather than the request data goes into the server. Thus our problem will be solved without these code changes.
Description of what I changed
Fixes issue: #258
requestContent
in theRequestMutation
class.mutateRequest()
function, added check for the request content.E2E test
TESTED:
Please replace this with a description of how you tested your PR beyond the automated e2e/unit tests.
Checklist: I completed these to help reviewers :)
[x] I have read and will follow the review process.
[ ] I am familiar with Google Style Guides for the language I have coded in.
No? Please take some time and review Java and Python style guides.
[ ] My IDE is configured to follow the Google code styles.
No? Unsure? -> configure your IDE.
[ ] I have added tests to cover my changes. (If you refactored existing code that was well tested you do not have to add tests)
[x] I ran
mvn clean package
right before creating this pull request and added all formatting changes to my commit.[ ] All new and existing tests passed.
[ ] My pull request is based on the latest changes of the master branch.
No? Unsure? -> execute command
git pull --rebase upstream master