search

google / fhir

FHIR Protocol Buffers
Apache License 2.0
841 stars 191 forks source link

Unmarshaller support for R5 versions #224

Open nithin36543654 opened 1 year ago

nithin36543654 commented 1 year ago

Hi, Is there a plan to write an unmarshaller for R5 version. I currently see the unmarshaller is available for R4, R3. If the plan is not in near future, can you guide me on how to generate the unmarshaller. I would like to tweak the code base and add the functionality.

nikklassen commented 1 year ago

Support for R5 is something we will be starting very soon. We don't generate the unmarshaller, if you wanted to fork this repo and support R5 sooner you would have to modify all the per-version code we have, such as in https://github.com/google/fhir/blob/master/go/jsonformat/internal/jsonpbhelper/fhirutil.go

nithin36543654 commented 1 year ago

Hi, Great. I would like to contribute. Can you list me all the possible files you remember, I have to add support for.

Regards, Nithin

From: Nik Klassen @.> Reply-To: google/fhir @.> Date: Tuesday, August 1, 2023 at 8:00 AM To: google/fhir @.> Cc: "Chamala, Nithin Reddy (CTR) HHHH" @.>, Author @.***> Subject: [External] Re: [google/fhir] Unmarshaller support for R5 versions (Issue #224)

Support for R5 is something we will be starting very soon. We don't generate the unmarshaller, if you wanted to fork this repo and support R5 sooner you would have to modify all the per-version code we have, such as in https://github.com/google/fhir/blob/master/go/jsonformat/internal/jsonpbhelper/fhirutil.gohttps://urldefense.com/v3/__https:/github.com/google/fhir/blob/master/go/jsonformat/internal/jsonpbhelper/fhirutil.go__;!!FEyU5bU!DeHS16sq7bX6i6uvOE_cbd_CRIZTmX8IAHkZ5RuLAaVbHSNgwYkrR380iOxzG7IAu3pTbL4EHQfJmR49h8zDogOezLxATtk$

— Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/google/fhir/issues/224*issuecomment-1660503576__;Iw!!FEyU5bU!DeHS16sq7bX6i6uvOE_cbd_CRIZTmX8IAHkZ5RuLAaVbHSNgwYkrR380iOxzG7IAu3pTbL4EHQfJmR49h8zDogOeDHjLddI$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/BBR5RPQVTQFOKW3YMI6PE7LXTEKZNANCNFSM6AAAAAA22V2OUY__;!!FEyU5bU!DeHS16sq7bX6i6uvOE_cbd_CRIZTmX8IAHkZ5RuLAaVbHSNgwYkrR380iOxzG7IAu3pTbL4EHQfJmR49h8zDogOeBWJYU-4$. You are receiving this because you authored the thread.Message ID: @.***>

CONFIDENTIALITY NOTICE: If you have received this email in error, please immediately notify the sender by e-mail at the address shown. This email transmission may contain confidential information. This information is intended only for the use of the individual(s) or entity to whom it is intended even if addressed incorrectly. Please delete it from your files if you are not the intended recipient. Thank you for your compliance. Copyright (c) 2023 Cigna

nikklassen commented 1 year ago

Unfortunately I don't think we'd be able to accept contributions for this at this time. The maintainers are looking into a wider strategy for migrating our code that will include this repo. If you want to fork the repo and make your own changes take a look for any files importing import "r4pb" or "r3pb"