search

google / fhir

FHIR Protocol Buffers
Apache License 2.0
840 stars 190 forks source link

Namespace/Class collisions with C# compiler in DatatypesReflection #26

Open saltatory opened 4 years ago

saltatory commented 4 years ago

Both proto/google/fhir/proto/r4/core/datatypes.proto and proto/google/fhir/proto/r4/core/profiles/datatypes.proto generate a class named DatatypesReflection as part of the standard output from protoc. Both *.proto files use the same package google.fhir.r4.core. This results in a duplicate name collision in the generated output.

This problem disappears if the datatypes.proto file is moved into the google.fhir.r4.core.profiles namespace.

Tho' I am not certain if that causes any other unrelated issues.

Cam2337 commented 3 years ago

We'd love to suport C# but don't really have the bandwidth right now :(

If going this route, as a first step you might try to have a look at https://github.com/bazelbuild/rules_dotnet to see if you can get support going with Bazel?

saltatory commented 3 years ago

Thanks for the reply Cam!

Got it ... I'll take a look at the Bazel configuration. It may be a while as I'm working on other elements of the project. If I come up with something, I'll contribute back.