google / filament

Filament is a real-time physically based rendering engine for Android, iOS, Windows, Linux, macOS, and WebGL2
https://google.github.io/filament/
Apache License 2.0
17.78k stars 1.89k forks source link

Still a couple of DEPRECATED #5888

Closed jiapei-nexera closed 2 years ago

jiapei-nexera commented 2 years ago
➜  include grep -rn "DEPRECATED" 
GL/glcorearb.h:2303:#define GL_DEBUG_TYPE_DEPRECATED_BEHAVIOR 0x824D
GL/glcorearb.h:3044:#define GL_DEBUG_TYPE_DEPRECATED_BEHAVIOR_ARB 0x824D
GL/glext.h:2250:#define GL_DEBUG_TYPE_DEPRECATED_BEHAVIOR 0x824D
GL/glext.h:3044:#define GL_DEBUG_TYPE_DEPRECATED_BEHAVIOR_ARB 0x824D
utils/JobSystem.h:98:    UTILS_DEPRECATED
utils/compiler.h:40:#   define UTILS_DEPRECATED [[deprecated]]
utils/compiler.h:42:#   define UTILS_DEPRECATED
backend/PresentCallable.h:99:using FrameFinishedCallback UTILS_DEPRECATED = void(*)(PresentCallable callable, void* user);
filament/ColorGrading.h:125:    enum class UTILS_DEPRECATED ToneMapping : uint8_t {
filament/ColorGrading.h:212:        UTILS_DEPRECATED
filament/View.h:288:    UTILS_DEPRECATED
filament/View.h:298:    UTILS_DEPRECATED
filament/View.h:772:    enum class UTILS_DEPRECATED AmbientOcclusion : uint8_t {
filament/View.h:784:    UTILS_DEPRECATED
filament/View.h:794:    UTILS_DEPRECATED
filament/IndirectLight.h:339:    UTILS_DEPRECATED
filament/IndirectLight.h:343:    UTILS_DEPRECATED
vulkan/vulkan_core.h:61:// DEPRECATED: This define is deprecated. VK_MAKE_API_VERSION should be used instead.
vulkan/vulkan_core.h:65:// DEPRECATED: This define has been removed. Specific version defines (e.g. VK_API_VERSION_1_0), or the VK_MAKE_VERSION macro, should be used instead.
vulkan/vulkan_core.h:80:// DEPRECATED: This define is deprecated. VK_API_VERSION_MAJOR should be used instead.
vulkan/vulkan_core.h:83:// DEPRECATED: This define is deprecated. VK_API_VERSION_MINOR should be used instead.
vulkan/vulkan_core.h:86:// DEPRECATED: This define is deprecated. VK_API_VERSION_PATCH should be used instead.

Particularly, those UTILS_DEPRECATED should be removed, maybe next release?

Cheers

romainguy commented 2 years ago

No we are not removing them. They are used by some of our users.