PlatformEGL::createSwapChain never returns a nullptr anymore

google / filament

Filament is a real-time physically based rendering engine for Android, iOS, Windows, Linux, macOS, and WebGL2

https://google.github.io/filament/

Apache License 2.0

17.44k stars 1.84k forks source link

PlatformEGL::createSwapChain never returns a nullptr anymore #7687

Closed pixelflinger closed 4 months ago

pixelflinger commented 4 months ago

in case the swapchain creation fails, it will now return a swapchain with an EGL_NO_SURFACE handle. this will avoid having to nullptr check the pointer in various places and will revert to the previous behavior on failure.

FIXES=[329659681]

github-actions[bot] commented 4 months ago

Please add a release note line to NEW_RELEASE_NOTES.md. If this PR does not warrant a release note, add the 'internal' label to this PR.