google / filament

Filament is a real-time physically based rendering engine for Android, iOS, Windows, Linux, macOS, and WebGL2
https://google.github.io/filament/
Apache License 2.0
17.44k stars 1.84k forks source link

Fix WebGL build with newer Emscripten #7721

Closed bejado closed 4 months ago

bejado commented 4 months ago

Newer Emscripten toolchains require us to wrap raw pointers in allow_raw_pointer.

bejado commented 4 months ago

which version of emscripten does this work with? Do we need to update the build script for web?

I'm not sure when the Emscripten change was made, but this should be backwards compatible. That is, we should have been doing this all along, but it only recently became a failure. So no, I don't think we need to update any build scripts.