google / filament

Filament is a real-time physically based rendering engine for Android, iOS, Windows, Linux, macOS, and WebGL2
https://google.github.io/filament/
Apache License 2.0
17.44k stars 1.84k forks source link

remove wrong `noexcept` in the backend #7723

Closed pixelflinger closed 4 months ago

pixelflinger commented 4 months ago

going forward we want to be able to throw exceptions from the backend at the very least, we need to be consistant, currently we are potentially throwing exceptions from noexcept places.

this changes makes it possible to throw exceptions from the backend, during handle construction and conversion to pointers, which wasn't allowed before.

We still can't throw from dtors because it's generally a bad idea, better abort in that case.