search

google / filament

Filament is a real-time physically based rendering engine for Android, iOS, Windows, Linux, macOS, and WebGL2
https://google.github.io/filament/
Apache License 2.0
17.37k stars 1.84k forks source link

Set VkApplicationInfo.pEngineName to Filament #7755

Closed pippy360 closed 2 months ago

pippy360 commented 2 months ago

Setting the pEngineName helps with the collection of metrics and is generally good practice.

google-cla[bot] commented 2 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

poweifeng commented 2 months ago

superceded by: https://github.com/google/filament/pull/7756