search

google / filament

Filament is a real-time physically based rendering engine for Android, iOS, Windows, Linux, macOS, and WebGL2
https://google.github.io/filament/
Apache License 2.0
17.36k stars 1.84k forks source link

Remove bitcode from iOS builds #7802

Closed vpopovyc closed 2 months ago

vpopovyc commented 2 months ago

With the release of Xcode 14, bitcode was deprecated.

Reference: https://developer.apple.com/documentation/xcode-release-notes/xcode-14-release-notes#Deprecations

Xcode no longer builds bitcode by default and generates a warning message if a project explicitly enables bitcode: “Building with bitcode is deprecated. Please update your project and/or target settings to disable bitcode.”

It’s important to note that any app submitted to the AppStore with a bitcode will be rejected, triggering the ITMS-90482 error.

RN, the latest Filament binary for iOS, contains the bitcode. Therefore, with this change, I propose to allow the optional exclusion of the bitcode.

I’ve followed https://github.com/google/filament/pull/2708 to revert code blocks that were affected.

Sidenote:
 It may be reasonable to assume that a bitcode can be turned off by default for iOS builds.

google-cla[bot] commented 2 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

bejado commented 2 months ago

LGTM, but since it's deprecated now, we can probably just remove bitcode altogether. I think I originally added bitcode support because it was a requirement for Cocoapods. If that's no longer the case, then let's just remove it. Clients are expected to use a recent Xcode anyway.

vpopovyc commented 2 months ago

Ok, I'll update the PR to remove it.