google / filament

Filament is a real-time physically based rendering engine for Android, iOS, Windows, Linux, macOS, and WebGL2
https://google.github.io/filament/
Apache License 2.0
17.35k stars 1.83k forks source link

gltfio: [extended] Fix generated color default #7917

Closed poweifeng closed 2 weeks ago

poweifeng commented 2 weeks ago

Fixes #7905

mbalajee commented 2 weeks ago

Doesn't seem to fix the issue. Model (attached in the original issue) still appears all black,

Screenshot 2024-06-11 at 3 31 28 PM

@poweifeng @pixelflinger

poweifeng commented 2 weeks ago

Doesn't seem to fix the issue. Model (attached in the original issue) still appears all black, Screenshot 2024-06-11 at 3 31 28 PM @poweifeng @pixelflinger

Can you attach the model again? It seems corrupted in the previous comment.

mbalajee commented 2 weeks ago

It was attached as .zip cz of github attachment restriction. Removing the .zip extension should work, i just tried from previous comment.

Here is the same model, walls.glb.zip

poweifeng commented 2 weeks ago

Let's continue the conversation in #7905.

mbalajee commented 2 weeks ago

Clean build worked. Model appears as expected. Thanks.