google / filament

Filament is a real-time physically based rendering engine for Android, iOS, Windows, Linux, macOS, and WebGL2
https://google.github.io/filament/
Apache License 2.0
17.35k stars 1.83k forks source link

Add ability to disable panning in the OrbitManipulator #7928

Closed mentholyspirit closed 4 days ago

mentholyspirit commented 2 weeks ago

It's useful when you want to have the ability to rotate the camera, but want to limit panning.

google-cla[bot] commented 2 weeks ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

mentholyspirit commented 1 week ago

@pixelflinger The problem then comes when someone tries to use it like this: Config config = {}; config.upVector = vec2(1.f, 0.f); mainpulator.setProperties(config) Then panning will be set to false, which is not the expected behaviour.

pixelflinger commented 1 week ago

@pixelflinger The problem then comes when someone tries to use it like this: Config config = {}; config.upVector = vec2(1.f, 0.f); mainpulator.setProperties(config) Then panning will be set to false, which is not the expected behaviour.

Why can't we set panning to true by default in Config?

pixelflinger commented 1 week ago

@mentholyspirit the Android presubmit is failing.