Closed mentholyspirit closed 4 days ago
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
View this failed invocation of the CLA check for more information.
For the most up to date status, view the checks section at the bottom of the pull request.
@pixelflinger The problem then comes when someone tries to use it like this:
Config config = {}; config.upVector = vec2(1.f, 0.f); mainpulator.setProperties(config)
Then panning
will be set to false, which is not the expected behaviour.
@pixelflinger The problem then comes when someone tries to use it like this:
Config config = {}; config.upVector = vec2(1.f, 0.f); mainpulator.setProperties(config)
Thenpanning
will be set to false, which is not the expected behaviour.
Why can't we set panning
to true
by default in Config
?
@mentholyspirit the Android presubmit is failing.
It's useful when you want to have the ability to rotate the camera, but want to limit panning.