search

google / filament

Filament is a real-time physically based rendering engine for Android, iOS, Windows, Linux, macOS, and WebGL2
https://google.github.io/filament/
Apache License 2.0
17.35k stars 1.83k forks source link

Extended algorithm crashes the sample app #7930

Open mbalajee opened 1 week ago

mbalajee commented 1 week ago

Describe the bug Extended algorithm (from this PR) drastically slows down the rendering. When I opt in to the extended algorithm the model which was loading fine before (if I don't opt in) takes a very very long time to load & it eventually crashes

To Reproduce Steps to reproduce the behavior: Follow this step to opt in to extended asset loader

Expected behavior There should be no difference in performance

Screenshots

Left - Opt in to extended algo | Without extended algo

https://github.com/google/filament/assets/17508872/c75adf99-f15a-47dc-85aa-0c0a70ce9fcd

Desktop (please complete the following information):

Additional context Load a larger model to reproduce the degrade in performance & an eventual crash. I couldn't attach the model here since it is sensitive but any larger model (> 8K entities) will be impacted

poweifeng commented 1 week ago

If you can point to a publicly available gltf with this issue, it'll help speed along the investigation. Also note that fixing any issues with the extended algo is not really prioritized at the moment since we really prefer to focus on exploring a better gltf loader overall.

mbalajee commented 1 week ago

If you can point to a publicly available gltf with this issue, it'll help speed along the investigation. Also note that fixing any issues with the extended algo is not really prioritized at the moment since we really prefer to focus on exploring a better gltf loader overall.

I'll try to find some online but any glb with over 8 to 10K entities will be affected