search

google / firing-range

Apache License 2.0
1.38k stars 241 forks source link

Fixes some broken URLs and unnecessary "deletes" #11

Closed jasvir closed 8 years ago

paradoxengine commented 8 years ago

Minor nit, otherwise CL looks good, can merge once fixed.

jasvir commented 8 years ago

Note as mentioned in the bug description, the removal of the "delete window.localStorage" is deliberate and is one of the things being fixed.

See http://jsfiddle.net/2d000fjt/ to repro the bug - it may only happen to be working for the web security scanner if localStorage was being frozen or mocked in some way that delete window.localStorage didn't end up deleting the localStorage object entirely rather than just emptying it.

paradoxengine commented 8 years ago

Thank you Jas!