google / firing-range

Apache License 2.0
1.38k stars 241 forks source link

Add build configuration for lgtm.com #17

Closed aibaars closed 6 years ago

aibaars commented 6 years ago

This pull request adds an .lgtm.yml configuration file to teach lgtm.com to build this repository.

See also: https://discuss.lgtm.com/t/cannot-build-ant-build-logs-unhelpful/736/2 @paradoxengine

googlebot commented 6 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


aibaars commented 6 years ago

I signed it!

googlebot commented 6 years ago

CLAs look good, thanks!

paradoxengine commented 6 years ago

Thank you!

sirdarckcat commented 6 years ago

@aibaars do you know why https://lgtm.com/projects/g/google/firing-range/latest/files/src/?sort=name&dir=ASC&mode=heatmap&excluded=false doesn't show https://github.com/google/firing-range/tree/master/src/pages

aibaars commented 6 years ago

@sirdarckcat lgtm.com currently analyses java, javascript, python, and c/c++ code. The src/pages folder contains mostly html code, which we do analyse as part of the javascript analysis. Unfortunately, lgtm considered the amount of javascript files (0.1% according to github) to be too small. Let me see if I can enable javascript analysis for your repository, so it will analyse the javascript in the html pages.

sirdarckcat commented 6 years ago

@aibaars it also didn't index the Java files it seems

https://github.com/google/firing-range/blob/master/src/tests/escape/JsEscape.java

sirdarckcat commented 6 years ago

(this shows empty: https://lgtm.com/projects/g/google/firing-range/latest/files/src/tests/escape/?sort=name&dir=ASC&mode=heatmap&excluded=false )

aibaars commented 6 years ago

We filter out test code, generated code, and some more things by default, but you can unhide them with the funny button on the left. https://lgtm.com/projects/g/google/firing-range/latest/files/src/tests/escape/?sort=name&dir=ASC&mode=heatmap&excluded=true

sirdarckcat commented 6 years ago

thanks :) that worked.

On Fri, Nov 24, 2017 at 5:32 PM Arthur Baars notifications@github.com wrote:

We filter out test code, generated code, and some more things by default, but you can unhide them with the funny button on the left. https://lgtm.com/projects/g/google/firing-range/latest/files/src/tests/escape/?sort=name&dir=ASC&mode=heatmap&excluded=true

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/google/firing-range/pull/17#issuecomment-346864730, or mute the thread https://github.com/notifications/unsubscribe-auth/AACBQayFIdu4frcF8ihy6xYYLXbluj3yks5s5u9cgaJpZM4Qnkel .