search

google / flatbuffers

FlatBuffers: Memory Efficient Serialization Library
https://flatbuffers.dev/
Apache License 2.0
22.52k stars 3.19k forks source link

dart: Fix incorrect write in Float64 write method #8290

Closed NotTsunami closed 1 month ago

NotTsunami commented 2 months ago

Closes #8070, closes #6688.

Credits @Llamadmiral for pointing out the fix and @vaind for the test case.

NOTE: The currently commented out test code is still commented out as it isn't a great test case. The test will fail because no ColorT type exists (as expected). We should probably get a better test case. https://github.com/google/flatbuffers/blob/7106d86685e3395efc6df5d2ee5914fe622ed6b9/dart/test/flat_buffers_test.dart#L818-L827

google-cla[bot] commented 2 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

NotTsunami commented 2 months ago

Hi Llamadmiral, I attributed the commit to you because you have found the fix for it. For this to get merged with your handle in the credit, you need to sign the CLA!

Llamadmiral commented 2 months ago

Hello @NotTsunami,

Thanks for attributing the commit to me! I signed the CLA, and pressed rescan, I think it finished successfully.

Thanks again! :)