search

google / flatbuffers

FlatBuffers: Memory Efficient Serialization Library
https://flatbuffers.dev/
Apache License 2.0
22.52k stars 3.19k forks source link

Use MODULE.bazel and avoid directly running npm commands. #8305

Open jjh42 opened 1 month ago

jjh42 commented 1 month ago

I'm not sure if you directly able to accept this PR if people are relying on the workspace rule but this can at least start a discussion.

This patches flatbuffers for use with bazel modules. Its based on: https://github.com/bazelbuild/bazel-central-registry/tree/main/modules/flatbuffers but removes the npm commands since they conflict with a repo that already uses npm.

google-cla[bot] commented 1 month ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

jkuszmaul commented 1 month ago

Getting flatbuffers onto bzlmod would be great; see some prior effort at https://github.com/google/flatbuffers/pull/8227 and issue reference at https://github.com/google/flatbuffers/issues/7695. I'd guess no one took the time to review #8227 since I don't see any reason it shouldn't've gotten reviewed.