search

google / flatbuffers

FlatBuffers: Memory Efficient Serialization Library
https://flatbuffers.dev/
Apache License 2.0
22.52k stars 3.19k forks source link

ci: fix g++13 build on linux #8315

Closed vaind closed 1 month ago

vaind commented 1 month ago

g++13 was removed from ubuntu-22.04 (https://github.com/actions/runner-images/issues/9679, https://github.com/actions/runner-images/issues/9866) breaking everyone in the process...

updating the CI to use ubuntu-24.04 instead. This is currently blocked by the large runner not being enabled for the project - needs input from maintainers

P. S. sorry about the whitespace changes, the file was auto-fixed during search&replace by my editor. Let me know if that's really an issue and I can roll the whitespace change back

hartwork commented 1 month ago

P. S. sorry about the whitespace changes, the file was auto-fixed during search&replace by my editor. Let me know if that's really an issue and I can roll the whitespace change back

@vaind I don't have any say here, but this could be a single tiny easy-to-review commit. If my vote counts, I would definitely vote for a revert in whitespace changes. Thanks for your consideration!

dbaileychess commented 1 month ago

Thanks, I had to do some other stuff in #8319 that includes this.