google / flatbuffers

FlatBuffers: Memory Efficient Serialization Library
https://flatbuffers.dev/
Apache License 2.0
22.52k stars 3.19k forks source link

[TS] Actually import typescript extension in typescript generator #8339

Closed hhvrc closed 1 week ago

hhvrc commented 1 week ago

Is there any reason these are importing .js extensions in the typescript generator?

They should be importing .ts so i changed it

bjornharrtell commented 1 week ago

I'm not aware of importing modules with .ts extensions being a thing at all. Either it's with .js extension as that is the compiled target explicit module name, or it can sometimes be acceptable with extensionless module name depending on runtime environment.

Unless some very convincing motivation is given here I would suggest to close this.