google / flatbuffers

FlatBuffers: Memory Efficient Serialization Library
https://flatbuffers.dev/
Apache License 2.0
23.16k stars 3.23k forks source link

[.NET] Fix VerifyUnion using wrong offset for typeId #8360

Open 0x4261756D opened 2 months ago

0x4261756D commented 2 months ago

The offset was overwritten to point to the data before the typeId was set.

google-cla[bot] commented 2 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

0x4261756D commented 2 months ago

Oh well, too bad having a Google account is a requirement for contributing. Seems like this change won't make its way into the repo then I guess.