Fixes for Dart imports - Githubissues

google / flatbuffers

FlatBuffers: Memory Efficient Serialization Library

https://flatbuffers.dev/

Apache License 2.0

23.37k stars 3.25k forks source link

Open insertjokehere opened 3 months ago

insertjokehere commented 3 months ago

Add a simple test to catch regressions in this area
Fix an issue where include chains (a includes b which includes c) are naively represented as a single import in Dart, which doesn't reflect how Dart handles imports. I've adjusted the Dart code generator to include an export statement to match import statements for files in the same namespace to ensure that include chains work in the generated code

fawdlstty commented 5 days ago

@CasperN @vaind Sorry to tag you out of the blue. This part of the modification is very important to me. Can you promote the merger of PR?

vaind commented 5 days ago

I'm not a maintainer so I don't have merge permissions

fawdlstty commented 2 days ago

@aardappel Sorry to tag you out of the blue. Can you promote the merger of PR?

aardappel commented 1 day ago

Can you rebase this one, seems there may be some conflicts.

aardappel commented 1 day ago

There also seem to be dart codegen changes to the generated files that are not included in this PR

insertjokehere commented 1 day ago

@aardappel thanks for the review - I've rebased and updated the generated bindings. Happy to squash this down before merge.

aardappel commented 1 day ago

There also seem to be dart codegen changes to the generated files that are not included in this PR

This still seems to be an issue