pixelcnn.py: README is outdated and bug in dataset downloading

google / flax

Flax is a neural network library for JAX that is designed for flexibility.

https://flax.readthedocs.io

Apache License 2.0

5.98k stars 631 forks source link

pixelcnn.py: README is outdated and bug in dataset downloading #1114

Closed brettkoonce closed 3 years ago

brettkoonce commented 3 years ago

python3 main.py --workdir=./pixelcnn --config=configs/default.py

fails on

TypeError: __init__() got an unexpected keyword argument 'deterministic'

rolling back #683:

 git reset --hard feb9119d76b0e23d89670ba752caa414c5a7ade2

works again. ping @jheek

marcvanzee commented 3 years ago

Thanks @brettkoonce for catching this! I can fix this today.

brettkoonce commented 3 years ago

per discussion in #1122, upgrading to 0.3.2 fixes this, closing!

marcvanzee commented 3 years ago

Actually I tried running it and it didn't work since the dataset wasn't downloaded. Also the README instructions were outdated, so I'm reopening and attaching a PR that fixes it.

brettkoonce commented 3 years ago

kk, i had something similar in https://github.com/brettkoonce/flax/commit/84faadf6070b9df5aebcc29562ee063ab864badf, but yours is fancier!