search

google / flexbox-layout

Flexbox for Android
Apache License 2.0
18.22k stars 1.79k forks source link

bugfix: #614 #615

Open hjhjw1991 opened 1 year ago

hjhjw1991 commented 1 year ago

bug: when using FlexboxLayoutManager with flex-direction set to column, a child having top margin will result in an unexpected top margin on every following child cause: previous child's TOP_MARGIN is added when moving childTop down. I think it should be BOTTOM_MARGIN instead. similar for childBottom

google-cla[bot] commented 1 year ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.