Closed sgowroji closed 5 months ago
Apparently the builds have been failing since December.
https://buildkite.com/bazel/flogger/builds/2715#018daa29-0ee6-4680-ad6d-4ec7dfce09bf is failing now for a different reason:
log4j2/src/test/java/com/google/common/flogger/backend/log4j2/Log4j2BackendFactoryTest.java:34: error: [strict] Using type com.google.common.collect.ImmutableList from an indirect dependency (TOOL_INFO: "@@com_google_guava_guava//:com_google_guava_guava"). See command below ** ImmutableList<BackendFactory> factories = ^ ** Please add the following dependencies: @@com_google_guava_guava//:com_google_guava_guava to //log4j2:src/test/java/com/google/common/flogger/backend/log4j2/Log4j2BackendFactoryTest ** You can use the following buildozer command: buildozer 'add deps @@com_google_guava_guava//:com_google_guava_guava' //log4j2:src/test/java/com/google/common/flogger/backend/log4j2/Log4j2BackendFactoryTest
I just realized that this isn't our CI (which is currently green: https://github.com/google/flogger/actions).
@sgowroji, what's the difference between that build and this repo's CI? Where are the configs for this project on buildkite?
Oh, I see. The config is in https://github.com/bazelbuild/continuous-integration/blob/master/pipelines/flogger.yml.
So it's just bazel build //...
that's failing. I wonder why the project's CI doesn't cover that.
It looks like our normal build probably builds that, too: https://github.com/google/flogger/blob/3b7e325dcde4f5ee041494e0fbcfe947d53dbfde/.github/workflows/ci.yml#L43
Maybe just a Bazel version issue? I think you'd pointed me to the version selection recently: https://github.com/google/flogger/blob/3b7e325dcde4f5ee041494e0fbcfe947d53dbfde/.github/workflows/ci.yml#L20
I can reproduce the successful build locally with:
$ echo 3.7.1 > .bazelversion
$ bazelisk build //log4j2:src/test/java/com/google/common/flogger/backend/log4j2/Log4j2BackendFactoryTest
But without the .bazelversion
file, bazelisk picks a more recent version, and the build fails.
CI : https://buildkite.com/bazel/flogger/builds/2701#018d64f0-b10f-4087-b959-3e56353224da
Platform : Windows
Logs:
CC Greenteam @wyv