google / flutter-desktop-embedding

Experimental plugins for Flutter for Desktop
Apache License 2.0
7.1k stars 608 forks source link

Implement canLaunch for linux #707

Closed kenvandine closed 4 years ago

kenvandine commented 4 years ago

Returns true for URL schemes starting with ftp, http, and https

Fixes #706

googlebot commented 4 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

stuartmorgan commented 4 years ago

As an aside, we should definitely convert this to a pure Dart implementation at some point. Now that such a thing is possible, there's no need to use C++ here at all.

kenvandine commented 4 years ago

I think I've addressed everything, except the CLA which I've requested to get added to our corp agreement.

kenvandine commented 4 years ago

@googlebot I signed it!

googlebot commented 4 years ago

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.