Closed kenvandine closed 4 years ago
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!
and we'll verify it.
ℹ️ Googlers: Go here for more info.
As an aside, we should definitely convert this to a pure Dart implementation at some point. Now that such a thing is possible, there's no need to use C++ here at all.
I think I've addressed everything, except the CLA which I've requested to get added to our corp agreement.
@googlebot I signed it!
Returns true for URL schemes starting with ftp, http, and https
Fixes #706