google / flutter-desktop-embedding

Experimental plugins for Flutter for Desktop
Apache License 2.0
7.1k stars 608 forks source link

Add GTK window_size plugin #746

Closed robert-ancell closed 4 years ago

robert-ancell commented 4 years ago

@stuartmorgan this is ready for review. I haven't resolved my issues with the current Flutter build not working locally so I haven't yet fully tested it.

stuartmorgan commented 4 years ago

I haven't resolved my issues with the current Flutter build not working locally

We should work through this in Discord today if you're still stuck.

stuartmorgan commented 4 years ago

As a follow-up, it would be good to implement https://github.com/google/flutter-desktop-embedding/issues/483 for Linux in the GTK plugin. I never got to it for GLFW, but hopefully it would be straightforward with GTK.

stuartmorgan commented 4 years ago

Per chat the centering isn't actually working for me, despite the values looking good on the Dart side, but the really bad issues are resolved so landing and we can follow up on the behavior later.