search

google / flutter-desktop-embedding

Experimental plugins for Flutter for Desktop
Apache License 2.0
7.1k stars 604 forks source link

Building in container failed due to missing `strcmp` #895

Closed Migarl closed 2 years ago

Migarl commented 2 years ago

Hello everyone!

Nice plugin!

But in our gitlab CI the building failed with following error message:

/linux/flutter/ephemeral/.plugin_symlinks/window_size/linux/window_size_plugin.cc:345:7: error: use of undeclared identifier 'strcmp'
/linux/flutter/ephemeral/.plugin_symlinks/window_size/linux/window_size_plugin.cc:347:14: error: use of undeclared identifier 'strcmp'
/linux/flutter/ephemeral/.plugin_symlinks/window_size/linux/window_size_plugin.cc:349:14: error: use of undeclared identifier 'strcmp'
/linux/flutter/ephemeral/.plugin_symlinks/window_size/linux/window_size_plugin.cc:351:14: error: use of undeclared identifier 'strcmp'
/linux/flutter/ephemeral/.plugin_symlinks/window_size/linux/window_size_plugin.cc:353:14: error: use of undeclared identifier 'strcmp'
/linux/flutter/ephemeral/.plugin_symlinks/window_size/linux/window_size_plugin.cc:355:14: error: use of undeclared identifier 'strcmp'
/linux/flutter/ephemeral/.plugin_symlinks/window_size/linux/window_size_plugin.cc:357:14: error: use of undeclared identifier 'strcmp'
/linux/flutter/ephemeral/.plugin_symlinks/window_size/linux/window_size_plugin.cc:359:14: error: use of undeclared identifier 'strcmp'
/linux/flutter/ephemeral/.plugin_symlinks/window_size/linux/window_size_plugin.cc:361:14: error: use of undeclared identifier 'strcmp'
Build process failed

We are building in a container.

With #include <string.h> the container finds strcmp and builds with success

google-cla[bot] commented 2 years ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.