google / flutter-mediapipe

Apache License 2.0
165 stars 7 forks source link

[wip] Add Android plugin for Text #2

Closed craiglabenz closed 2 months ago

craiglabenz commented 1 year ago

Description

Adds the beginning scaffolding for the mediapipe_task_text library, including the mediapipe_task_text_platform_implementation and mediapipe_task_text_android libraries.

Checklist

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

PaulTR commented 1 year ago

We should probably move the app in example down a layer since the text plugin includes things like text classification, language detector, and text embedding.

craiglabenz commented 1 year ago

We should probably move the app in example down a layer since the text plugin includes things like text classification, language detector, and text embedding.

Do you think it's important to have separate samples for each work flow, or could they potentially be lumped into one demo with 3 different buttons to complete each task?

PaulTR commented 1 year ago

I'd keep them separated. We have one example per task in the other platforms, so keeping them separated helps us add examples for each over time

On Mon, May 29, 2023, 9:37 AM Craig Labenz @.***> wrote:

We should probably move the app in example down a layer since the text plugin includes things like text classification, language detector, and text embedding.

Do you think it's important to have separate samples for each work flow, or could they potentially be lumped into one demo with 3 different buttons to complete each task?

— Reply to this email directly, view it on GitHub https://github.com/google/flutter-mediapipe/pull/2#issuecomment-1567284047, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAR2C36XATQY2PTMPOG6DITXIS7B3ANCNFSM6AAAAAAYEIC7VI . You are receiving this because you commented.Message ID: @.***>

PaulTR commented 1 year ago

Also let's keep it simple and only have one sample to start per category. For Android we did text classification, audio classification, and object detection. We can flesh out the remainders via GSoC and my own development once we have a rough template so you're not spending all of your time on samples. Core functionality is definitely the priority, and I can focus on details/polish.

craiglabenz commented 1 year ago

The latest commit should be working (or at least close to) from an implementation standpoint, but I'm getting segfault-like errors in my Android emulator.

craiglabenz commented 2 months ago

So obsolete, you can't even imagine.