Upgrade to Flutter 2 and null-safety

f-person commented 3 years ago

I migrated the code base (package, tests, example) to Flutter 2 and null-safety.

google-cla[bot] commented 3 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

f-person commented 3 years ago

@googlebot I signed it!

f-person commented 2 years ago

I understand that this package is not recommended for use now but there are apps that are migrating to null safety but still didn't migrate from flutter_flux. So I think the migration process will be easier if a null-safe package is available on pub.dev.

@rxlabz @jimbeveridge @AndreHaueisen @Hixie can you please take a look at this PR?

Hixie commented 2 years ago

LGTM, but I'm not an owner on this repo so I'm afraid my review means nothing.

jimbeveridge commented 2 years ago

Hi @Hixie. I was the owner of this repo before I left Google, but it doesn't look like I have approval permission anymore. This looks like a valuable PR - can someone else take over as owner so this PR can be approved?

Hixie commented 2 years ago

@jimbeveridge would you like to continue being owner? i can see if we can give you rights again.

jimbeveridge commented 2 years ago

@Hixie SGTM.

Hixie commented 2 years ago

@jimbeveridge I spoke to OSPO and they suggested the best course of action is for you to fork the repo and maintain it there, and then for us to archive this one. Would that work for you?

google / flutter_flux