search

google / fonts

Font files available from Google Fonts, and a public issue tracker for all things Google Fonts
https://fonts.google.com
18.23k stars 2.62k forks source link

/ofl/*/OFL.txt missing line after Copyright notice #1034

Open m4rc1e opened 7 years ago

m4rc1e commented 7 years ago

When I added the missing families to this repo, some of the OFL.txt files did not include a gap between the copyright string (first line) and the rest of the text. e.g:

Incorrect

Copyright 2017 The Font Project Authors (git repo url)
This Font Software is licensed under the SIL Open Font License, Version 1.1.
This license is copied below, and is also available with a FAQ at:
http://scripts.sil.org/OFL

Correct

Copyright 2017 The Font Project Authors (git repo url)

This Font Software is licensed under the SIL Open Font License, Version 1.1.
This license is copied below, and is also available with a FAQ at:
http://scripts.sil.org/OFL

@davelab6 went on a mission and fixed a lot of these by hand. I've just written a quick script to see if we have any of them still out standing. The only incorrect OFL.txt files left are:

These are very messed up though. Eg,

knewave screen shot 2017-06-06 at 15 26 08

A lot of the OFL.txt files use Win line endings, \r\n, whilst others use Unix, \n. I don't know whether this is a major issue though.

davelab6 commented 7 years ago

The only incorrect OFL.txt files left are

I'll fix them by hand

A lot of the OFL.txt files use Win line endings, \r\n, whilst others use Unix, \n. I don't know whether this is a major issue though.

I don't think so; probably Unix style is preferable. I'll happily accept a PR that fixes up everything to Unix style, and a fb check that ensures things stay that way.