Closed rsheeter closed 5 years ago
I have just implemented a new Font Bakery check for detecting this kind of problem. Current state of the collection as of latest master at https://github.com/google/fonts/commit/d08233f9c581786e8c834a1f0695a4f27869c119:
@felipesanches does this check every name record?
In https://github.com/google/fonts/pull/1905, I limited it to just fix nameIDs 1, 4, 6, 16, and 19.
Fontbakery version: 0.7.1.dev3+g02ba8f3
💔 ERROR | 🔥 FAIL | ⚠ WARN | 💤 SKIP | ℹ INFO | 🍞 PASS |
---|---|---|---|---|---|
0 | 220 | 0 | 0 | 0 | 2474 |
0% | 8% | 0% | 0% | 0% | 92% |
Note: The following loglevels were omitted in this report:
@felipesanches does this check every name record?
yes, it detects all offending name table records.
Nice. I agree that all name records shouldn't end with whitespace. However, my collection wide hotfix only fixes nameIDs which are related to the family name. I didn't want my hotfix to fix every record because it would've fixed 100+ fonts. Going forward, all families must pass this check.
Also, I noticed that there are strings that begin with spaces. And this check also detects spurious newlines (either in the beginning or end of name table strings)
The following have trailing spaces in their full_name:
ofl/sueellenfrancisco/METADATA.pb
ofl/pompiere/METADATA.pb
ofl/vidaloka/METADATA.pb
ofl/imfelldoublepica/METADATA.pb
I checked Sue Ellen, there it seemed to be in the underlying font as well.
Padauk-Regular has an empty string full_name. Padauk-Bold has a single space full_name.
Please fix both font binary and corresponding metadata. Bonus points for adding bakery checks to prevent ongoing, and doing a scan over all existing families.