google / fonts

Font files available from Google Fonts, and a public issue tracker for all things Google Fonts
https://fonts.google.com
18.07k stars 2.6k forks source link

Open Sans font has wrong 'locl' for Romanian #213

Closed davelab6 closed 2 years ago

davelab6 commented 8 years ago

See https://groups.google.com/forum/#!topic/early-access-fonts/S6C6e8AweSk

adipop commented 8 years ago

The GSUB table must be eliminated or the substitutions should be reversed! (all things here https://bugzilla.mozilla.org/show_bug.cgi?id=907793) The glyphs S, s, T, t with cedillaaccent (Ş,ş,Ţ,ţ) must be substituted with S, s, T, t with commaaccent (Ș,ș, Ț, ț) for the Romanian language! This affects all Romanian sites using Open Sans as well all the WordPress romanian sites on the Dashboard Admin side in any Romanian installation. It must be quickly fixed!

All the best!

cristianadam commented 8 years ago

It seems now Google Chrome also uses the 'locl' feature. A screenshot of Google Chrome 31, where it worked fine, can be found here https://bugzilla.mozilla.org/show_bug.cgi?id=951141

The test page looks as bad on Google Chrome as it does on Mozilla Firefox:

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01//EN" "http://www.w3.org/TR/html4/strict.dtd"> 
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8"/> 
<link href='http://fonts.googleapis.com/css?family=Open+Sans:400,700,300,400italic&subset=latin,latin-ext' rel='stylesheet' type='text/css'>
<style type="text/css">
h1 {
    font-family: "Open Sans";
    font-size: 36px;
    font-weight: normal;    
    margin: 10px 0 20px 0;
}
</style>
</head>

<h1 lang="ro">&#354;&#355; &#350;&#351; (cedilla)</h1>
<h1 lang="ro">&#538;&#539; &#536;&#537; (comma) </h1>

</html>
m4rc1e commented 7 years ago

Issue still exists

top: Roboto, bottom: Open Sans screen shot 2017-06-08 at 15 53 47

buiestru commented 7 years ago

Hello, the issue is extant and continues to spoil an otherwise excellent type family (for this particular localisation, of course).

Currently, the GSUB/'locl' lookup table looks like this:

Base Glyph Name Replacement Glyph Name
Scommaaccent (Ș) Scedilla (Ş)
scommaaccent (ș) scedilla (ş)
Tcommaaccent (Ț) Tcedilla (Ţ)
tcommaaccent (ț) tcedilla (ţ)

where comma variants are replaced with cedilla variants.

However, substitutions should be performed exactly the other way around:

Base Glyph Name Replacement Glyph Name
Scedilla (Ş) Scommaaccent (Ș)
scedilla (ş) scommaaccent (ș)
Tcedilla (Ţ) Tcommaaccent (Ț)
tcedilla (ţ) tcommaaccent (ț)

where non-Romanian lookalikes are replaced by proper Romanian glyphs.

It is especially frustrating that the 'locl' feature is active only in the presence of the HTML lang="ro" attribute. In other words, only standards compliant websites that care for SEO, accessibility (screen readers) etc. get the wrong glyphs.

I would argue for the removal of the 'locl' GSUB table, more precisely, for an empty 'locl' GSUB table. Given that glyph substitutions are, essentially, manipulating font rendering, what you see is not what you get.

Jobava commented 6 years ago

This bug has kept appearing in popular font suites and this has been plaguing Romanian for a long time (10+ years). Is there a chance to see a resolution to this soon?

laerm0 commented 6 years ago

Hi all –

I've just done a thorough revitalization of Open Sans and fixed this. New files are not live yet but soon! Thanks for your patience.

screen region 2017-12-12 at 11 46 18
adipop commented 6 years ago

Great news for romanians! Can't wait to go back to this font :)

All the best and Merry Christmas! Adrian ​

On Tue, Dec 12, 2017 at 6:48 PM, Micah Stupak notifications@github.com wrote:

Hi all –

I've just done a thorough revitalization of Open Sans and fixed this. New files are not live yet but soon! Thanks for your patience.

[image: screen region 2017-12-12 at 11 46 18] https://user-images.githubusercontent.com/10780161/33897001-4e19ce9c-df32-11e7-963e-60dc8671a129.png

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/google/fonts/issues/213#issuecomment-351111659, or mute the thread https://github.com/notifications/unsubscribe-auth/AA3z8XmaKKvFIZEzJjRMVHVnD4cbZ_0Sks5s_q5qgaJpZM4HasnH .

dale-cooper commented 3 years ago

Hi all –

I've just done a thorough revitalization of Open Sans and fixed this. New files are not live yet but soon! Thanks for your patience.

screen region 2017-12-12 at 11 46 18

Hey, any new on that? I know it's been a long time but the issue is still open. Thanks!

davelab6 commented 3 years ago

@m4rc1e has the latest VF made by @moyogo fixed this?

moyogo commented 3 years ago

The VF version and its static fonts have the fix, see https://github.com/googlefonts/opensans/tree/main/fonts, but the version of Google Fonts hasn't been updated yet.

$ hb-view --output-format=png --text=ŞşŢţ fonts/ttf/OpenSans-Regular.ttf
image
$ hb-view --output-format=png --text=ŞşŢţ --language=ro fonts/ttf/OpenSans-Regular.ttf
image
davelab6 commented 3 years ago

👍

Should be soon

ambrozieputna commented 2 years ago

Hi!

There is still a problem with the Condensed form of Open Sans in Google Fonts. If the webpage has the lang tag set to "ro" the diacritics appear with cedilla accent (Ş,ş,Ţ,ţ), not with commaaccent (Ș,ș, Ț, ț) as it should. The attached screenshot was made after modifying the lang tag in the inspector in Google Chrome from "en" to "ro". The same happens on the website where I want to use the font.

Can you fix it? Thanks!

Screenshot 2022-02-18 162803

davelab6 commented 2 years ago

Open Sans Condensed is frozen and will never be updated; we just pulled the https://fonts.google.com/specimen/Open+Sans+Condensed page, although the API will continue to serve existing users.

Instead, use Open Sans with the Width axis to obtain the styles you want.

fitojb commented 2 years ago

use Open Sans with the Width axis

Which is difficult to select since the Axes section on Google Fonts pages are never displayed to users of Microsoft Edge and Firefox. Why is that?