search

google / fonts

Font files available from Google Fonts, and a public issue tracker for all things Google Fonts
https://fonts.google.com
18.29k stars 2.64k forks source link

Add California Gothic (2.2) #2305

Open mattlag opened 4 years ago

mattlag commented 4 years ago

Updated issue to reflect v2.2 fixes

Hello, Googlefonts! I just completed work on v2.2 of my typeface California Gothic. This version fixed the few FontBakery validation errors I was getting in v2.0 and missing characters from v2.1. I tried to include as many of the recommended items in the repo as possible. Please let me know if any changes are needed! https://github.com/mattlag/California-Gothic https://github.com/mattlag/California-Gothic/releases/tag/v2.2

You can also check out my site for more background: https://www.mattlag.com/californiagothic/

Small preview: image

Daymarius commented 4 years ago

@mattlag https://github.com/Daymarius/California-Gothic-Updated

thlinard commented 4 years ago

https://github.com/google/fonts/blob/master/CONTRIBUTING.md

mattlag commented 4 years ago

Hi @thlinard, I believe I've done everything listed in the CONTRIBUTING.md document. Is there something else I should do?

mattlag commented 4 years ago

Hi @Daymarius - thanks for the link to your -Updated repo... could you let me know a little more about the changes you made? The original California Gothic is kerned. What OpenType features did you add?

@mattlag https://github.com/Daymarius/California-Gothic-Updated

thlinard commented 4 years ago

Hi @mattlag, yes, indeed! The link was for Daymarius, although probably the best thing to advise him would have been to do a pull request on your repository.

mattlag commented 4 years ago

@thlinard oh, great - that makes sense. Thank you!

Daymarius commented 4 years ago

Hi @Daymarius - thanks for the link to your -Updated repo... could you let me know a little more about the changes you made? The original California Gothic is kerned. What OpenType features did you add?

@mattlag https://github.com/Daymarius/California-Gothic-Updated

What font editor did you use?

I could send you Features in .fea file.

tphinney commented 4 years ago

Character set is mostly pretty good. But seems to be lacking a trademark symbol.

mattlag commented 4 years ago

@tphinney I see that, in the latin_unique-glyphs.nam document it includes 0x2122 ™ TRADE MARK SIGN but the font files I generated passed the Font Bakery tests... I'll add the Trade Mark Sign. I'll also see if there should be an issue opened on Font Bakery somewhere.

mattlag commented 4 years ago

@tphinney I submitted https://github.com/googlefonts/fontbakery/issues/2755 - the Font Bakery test list is slightly different than the latin_unique-glyphs.nam list.

mattlag commented 4 years ago

I discovered a list of glyphs that Font Bakery didn't look for that are included in the latin_unique-glyphs list. I'm going to work on adding these to California Gothic. I also included this list in the issue I started on the fontbakery repo.

0x02BB : ʻ MODIFIER LETTER TURNED COMMA exists in latin_unique-glyphs.nam but not GF_latin_core 
0x02BC : ʼ MODIFIER LETTER APOSTROPHE exists in latin_unique-glyphs.nam but not GF_latin_core 
0x2002 :   EN SPACE exists in latin_unique-glyphs.nam but not GF_latin_core 
0x200B :   ZERO WIDTH SPACE exists in latin_unique-glyphs.nam but not GF_latin_core 
0x2009 :   THIN SPACE exists in latin_unique-glyphs.nam but not GF_latin_core 
0x2032 : ′ PRIME exists in latin_unique-glyphs.nam but not GF_latin_core 
0x2033 : ″ DOUBLE PRIME exists in latin_unique-glyphs.nam but not GF_latin_core 
0x2122 : ™ TRADE MARK SIGN exists in latin_unique-glyphs.nam but not GF_latin_core 
0x2191 : ↑ UPWARDS ARROW exists in latin_unique-glyphs.nam but not GF_latin_core 
0x2193 : ↓ DOWNWARDS ARROW exists in latin_unique-glyphs.nam but not GF_latin_core 
0xFEFF :   ZERO WIDTH NO-BREAK SPACE (BOM) exists in latin_unique-glyphs.nam but not GF_latin_core 
0xFFFD : � REPLACEMENT CHARACTER exists in latin_unique-glyphs.nam but not GF_latin_core