google / fonts

Font files available from Google Fonts, and a public issue tracker for all things Google Fonts
https://fonts.google.com
18.25k stars 2.62k forks source link

Is Newsreader OpSz min really 6? #2772

Closed davelab6 closed 3 years ago

davelab6 commented 4 years ago

This 0 value should not have been accepted, and has been set to the axis minimum here, 6

https://github.com/google/fonts/commit/92ec7cb6699bcdc28a8c23a38805820a2161cd66

Originally posted by me at https://github.com/google/fonts/pull/2577#r512413769

@yanone is that the correct value?

felipesanches commented 4 years ago

yes, FontBakery detects this problem nowadays:

Screenshot from 2020-10-27 08-19-27

But this family was added back at 4d442fa119714832efd1ad3e019f0b18615e9508 last July 29 when we still did not have these checks on Font Bakery.

We also have a few more problems in this font detected by a recently implemented FB check: Screenshot from 2020-10-27 08-22-45

yanone commented 4 years ago

I'm tackling this, but I want to point out that you're looking at the wrong PR, which got "blocked". The current one is here: #2661

RosaWagner commented 3 years ago

I close this since it is resolved