search

google / fonts

Font files available from Google Fonts, and a public issue tracker for all things Google Fonts
https://fonts.google.com
18.2k stars 2.61k forks source link

Update Merriweather font to new version #2943

Open ghost opened 3 years ago

ghost commented 3 years ago

The font Merriweather 2 years ago chaged they repo to one, under they foundry at Github/SorkinType. I would like to request an update to the latest version, or if I could do it, I more than happy to do it.

Production notes: Don't forget to check if all open issues for Merriweather are fixed with this upgrade, and close them at the same tile.

davelab6 commented 2 years ago

Will be fixed soon in #4077

alxndr-w commented 1 year ago

"soon"?

chrissimpkins commented 1 year ago

We are currently reviewing changes relative to the last production release in Fonts and will decide about the production push. There are horizontal metrics changes and a move to lining proportional figures from oldstyle proportional figures. Our team feels that both sets of changes are progression in a better direction for the family, but these changes will affect existing documents that use Merriweather. The H metrics impact will be an average line length that is shorter in the new version based on Marc Foley's diffenator2 review of the design changes.

davelab6 commented 1 year ago

@RosaWagner wrote,

Production notes: Don't forget to check if all open issues for Merriweather are fixed with this upgrade, and close them at the same tile.

Did anyone check this?

davelab6 commented 1 year ago

Back on June 16th, @m4rc1e wrote:

In 2018, Google Fonts commissioned Eben Sorkin to work on a variable font replacement for Merriweather. The work was completed in 2021 but it hasn’t been onboarded to Google Fonts yet because it's a huge project that requires a large investment in careful handling, and we only recently developed the tools needed to do so. I've now completed driving development of these tools and have started this work. This document reports my key findings.

The horizontal metrics have changed significantly. I believe that the new variable fonts have better kerning, which is causing the new line length to be smaller.

kern change illustrated with toggling gif

In order to minimise the horizontal metrics differences, I considered changing the font’s optical size value to increase the line length. However, I found that the font’s optical size default value was already at the smallest allowable value in the font.

Since we couldn’t increase the line length by making the opsz smaller, I presented the following workarounds in the pipeline meeting held on 2023-06-15:

  1. Modify the kerning in the variable font, to be more similar to the current one
  2. Release the family under a new name, such as “Merriweather 2”
  3. Release as is, since the kerning is an improvement

@davelab6 decided to go with option (3), so we’re hoping this document serves as evidence that we’re aware of this issue and the change is intentional.

Apart from the line length, the only other significant change is the figure style has been changed from old-style to lining

Current: Static Fonts with old-style default numerals:

old-style default numerals

New: Variable Fonts, with lining default numerals:

lining default numerals

This change will bring the Merriweather family in line with our best practice recommendations and our other most-popular families: By default, we expect fonts to have lining proportional figures.

FYI @ebensorkin

davelab6 commented 1 year ago

Since the old style numerals are available via OT Feature and CSS, I suggest we make sure to update the DESC file with info about how to use CSS to turn off kerning and turn on osf to replicate the v1 design

kenmcd commented 1 year ago

@RosaWagner wrote,

Production notes: Don't forget to check if all open issues for Merriweather are fixed with this upgrade, and close them at the same tile.

Did anyone check this?

There are still a lot of interpolation issues in the v2.200 files. Most of the many I posted here are still in there: https://github.com/SorkinType/Merriweather/issues/540 And there are those plus others I missed in the Font Bakery report here: https://github.com/google/fonts/pull/4077#issuecomment-1604321642

m4rc1e commented 1 year ago

Confirmed on the interpolation issues

Screenshot 2023-06-28 at 09 43 46

wght=900, wdth=106, opsz=7

Interestingly, interpolation issues seem to appear when the wdth is greater than 100.

@ebensorkin please take a look at all of the glyph reported by @kenmcd. @kenmcd thank you for the report, I'll work on some tooling to catch these issues. Interestingly, if you compare the old static fonts against the VF instances, there isn't any interpolation issues.

davelab6 commented 1 year ago

Thanks @kenmcd !! :)

@ebensorkin since you'll need to open this up again at the design level, the new kerning of the default opsz (min) is drastic compared to the current version, so @tobestobs asks if you could now dial it back a little, so its not such a drastic change at that size?

EbenSorkin commented 1 year ago

I am happy to re-kern the file to make it less drastic. I also think the kerning that happens now in kern on is better than when I did this.

I am also happy to find and fix the interpolation problems.

On Wed, Jun 28, 2023 at 11:00 AM Dave Crossland @.***> wrote:

Thanks @kenmcd https://github.com/kenmcd !! :)

@EbenSorkin https://github.com/EbenSorkin since you'll need to open this up again at the design level, the new kerning of the default opsz (min) is drastic compared to the current version, so @tobestobs https://github.com/tobestobs asks if you could now dial it back a little, so its not such a drastic change at that size?

— Reply to this email directly, view it on GitHub https://github.com/google/fonts/issues/2943#issuecomment-1611606799, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAQUQXMW5EFO445P2LGGN43XNRBJBANCNFSM4VXLDNLA . You are receiving this because you were mentioned.Message ID: @.***>

chrissimpkins commented 1 year ago

@EbenSorkin Do you think that this is something that you will complete during Q3?

EbenSorkin commented 1 year ago

When does Q3 end?

-e.

On Wed, Jul 19, 2023 at 10:11 AM Chris Simpkins @.***> wrote:

@EbenSorkin https://github.com/EbenSorkin Do you think that this is something that you will complete during Q3?

— Reply to this email directly, view it on GitHub https://github.com/google/fonts/issues/2943#issuecomment-1642164064, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAQUQXL2DKX5L5DGCAKSNQDXQ7TIFANCNFSM4VXLDNLA . You are receiving this because you were mentioned.Message ID: @.***>

chrissimpkins commented 1 year ago

This Friday :)

chrissimpkins commented 1 year ago

@EbenSorkin Mind providing an updated schedule for these changes when you have a chance? Thanks!

EbenSorkin commented 1 year ago

Yes. I’m hoping to have Au school and Briem school out with Simon and then focus on Merriweather, the how to design for SSA document and supporting the other African projects. I put five updates into the issues cue. They all got GF African Pri updates. They are Gelasio, Alatsi, Alata, Calistoga, and Voltaire. My hope now is that Merriweather can be concluded in 1-2 weeks.

On Thu, Oct 19, 2023 at 10:41 AM Chris Simpkins @.***> wrote:

@EbenSorkin https://github.com/EbenSorkin Mind providing an updated schedule for these changes when you have a chance? Thanks!

— Reply to this email directly, view it on GitHub https://github.com/google/fonts/issues/2943#issuecomment-1771133274, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAQUQXNQMPB5FCRIVO2HGXTYAE3ZZAVCNFSM4VXLDNLKU5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCNZXGEYTGMZSG42A . You are receiving this because you were mentioned.Message ID: @.***>

chrissimpkins commented 10 months ago

status?

EbenSorkin commented 10 months ago

Au school and Breim are out of my hands and Merriweather is progressing.

I am fixing Merriweather for small subcontractor errors and revised Glyph standards since they worked on it now. I think it will be mid-late Dec before I have completed all the fixes and re-kerned it.

On Wed, Nov 29, 2023 at 4:16 PM Chris Simpkins @.***> wrote:

status?

— Reply to this email directly, view it on GitHub https://github.com/google/fonts/issues/2943#issuecomment-1832712544, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAQUQXMB6NEH6G42UFRTOPTYG6Q3LAVCNFSM4VXLDNLKU5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCOBTGI3TCMRVGQ2A . You are receiving this because you were mentioned.Message ID: @.***>

chrissimpkins commented 9 months ago

I have this tentatively slated for onboarding this quarter. Is the development complete @EbenSorkin?

EbenSorkin commented 9 months ago

There is still some work to do on Italics I am about to swap into that after I review small caps. I had been hoping to get Cyrillic improvements in too but that may have to come by Summer.

I am still hoping to be done by end of Jan.

-e.

On Wed, Jan 10, 2024 at 10:03 AM Chris Simpkins @.***> wrote:

I have this tentatively slated for onboarding this quarter. Is the development complete @EbenSorkin https://github.com/EbenSorkin?

— Reply to this email directly, view it on GitHub https://github.com/google/fonts/issues/2943#issuecomment-1885017424, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAQUQXJ2KVRENOEKEXWTNGTYN2USLAVCNFSM4VXLDNLKU5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCOBYGUYDCNZUGI2A . You are receiving this because you were mentioned.Message ID: @.***>

chrissimpkins commented 7 months ago

Status?

m4rc1e commented 6 months ago

I think Eben is still working on it.

EbenSorkin commented 6 months ago

Yes - still 20-30 day out

On Thu, Mar 28, 2024 at 12:46 PM Marc Foley @.***> wrote:

I think Eben is still working on it.

— Reply to this email directly, view it on GitHub https://github.com/google/fonts/issues/2943#issuecomment-2025666115, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAQUQXNKQCBUGBCVPFO6XKTY2Q3MPAVCNFSM4VXLDNLKU5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TEMBSGU3DMNRRGE2Q . You are receiving this because you were mentioned.Message ID: @.***>

chrissimpkins commented 6 months ago

Will move this to Q2. Thanks for letting us know!

chrissimpkins commented 5 months ago

@EbenSorkin how are things coming along with the updates?

EbenSorkin commented 5 months ago

I think I am getting very very close to done.

I'd like to think it will by next Friday or maybe even sooner.

On Fri, May 3, 2024 at 3:08 PM Chris Simpkins @.***> wrote:

@EbenSorkin https://github.com/EbenSorkin how are things coming along with the updates?

— Reply to this email directly, view it on GitHub https://github.com/google/fonts/issues/2943#issuecomment-2093609897, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAQUQXI2B3QTKKGXQEAF4XTZAPOBDAVCNFSM4VXLDNLKU5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TEMBZGM3DAOJYHE3Q . You are receiving this because you were mentioned.Message ID: @.***>

chrissimpkins commented 2 months ago

Still working through FB fails on these updates.

chrissimpkins commented 2 weeks ago

Updated to P2 in Q4 2024

EbenSorkin commented 2 weeks ago

I’m hoping to close relevant fontbakery fails tonight. All interpolation fails are resolved as of today.

On Tue, Oct 1, 2024 at 6:13 PM Chris Simpkins @.***> wrote:

Updated to P2 in Q4 2024

— Reply to this email directly, view it on GitHub https://github.com/google/fonts/issues/2943#issuecomment-2387173234, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAQUQXPAAYZ5U6T6F3HGPU3ZZMNCJAVCNFSM4VXLDNLKU5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TEMZYG4YTOMZSGM2A . You are receiving this because you were mentioned.Message ID: @.***>