google / fonts

Font files available from Google Fonts, and a public issue tracker for all things Google Fonts
https://fonts.google.com
18.24k stars 2.62k forks source link

Add Shimenkan (SIL) #4518

Open emmamarichal opened 2 years ago

emmamarichal commented 2 years ago

Font Project Git Repo URL: https://github.com/silnrsi/font-shimenkan

Super short description of the Font Family: The Shimenkan family of fonts supports the broad variety of writing systems that use the Miao (Pollard) script. Eight language-specific font families are part of the project, each reflecting the particular preferences of that language community.

Fonts Fonts.zip

Capture d’écran 2022-06-01 à 16 58 46
emmamarichal commented 2 years ago

Each style has this kind of design space, maybe it can be simplified:

Capture d’écran 2022-04-15 à 10 36 07

Fontbakery report

Fontbakery version: 0.8.9.dev3+gcf7de707

[1] Family checks
INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)
* ℹ **INFO** From a total of 1 font files, 1 of them (100.00%) lack a STAT table. And these are the most common STAT axis orderings: [code: summary]

[31] Shimenkan-Regular.ttf
🔥 FAIL: Check `Google Fonts Latin Core` glyph coverage. (com.google.fonts/check/glyph_coverage)
* 🔥 **FAIL** Missing required codepoints: - 0x2074 (SUPERSCRIPT FOUR) [code: missing-codepoints]
🔥 FAIL: Check license file has good copyright string. (com.google.fonts/check/license/OFL_copyright)
* 🔥 **FAIL** First line in license file does not match expected format: "copyright (c) 2018-2019, sil international (http://scripts.sil.org), with"
🔥 FAIL: Check copyright namerecords match license file. (com.google.fonts/check/name/license)
* 🔥 **FAIL** License file OFL.txt exists but NameID 13 (LICENSE DESCRIPTION) value on platform 3 (WINDOWS) is not specified for that. Value was: "Copyright (c) 2018-2019, SIL International (https://scripts.sil.org), with Reserved Font Names 'Shimenkan', 'Sapushan', 'Salaowu', and 'Taogu'. Latin glyphs copyright (c) 2010, 2012, 2014 Adobe Systems Incorporated (https://www.adobe.com/), with Reserved Font Name 'Source'. This Font Software is licensed under the SIL Open Font License, Version 1.1. This license is copied below, and is also available with a FAQ at: https://scripts.sil.org/OFL ----------------------------------------------------------- SIL OPEN FONT LICENSE Version 1.1 - 26 February 2007 ----------------------------------------------------------- PREAMBLE The goals of the Open Font License (OFL) are to stimulate worldwide development of collaborative font projects, to support the font creation efforts of academic and linguistic communities, and to provide a free and open framework in which fonts may be shared and improved in partnership with others. The OFL allows the licensed fonts to be used, studied, modified and redistributed freely as long as they are not sold by themselves. The fonts, including any derivative works, can be bundled, embedded, redistributed and/or sold with any software provided that any reserved names are not used by derivative works. The fonts and derivatives, however, cannot be released under any other type of license. The requirement for fonts to remain under this license does not apply to any document created using the fonts or their derivatives. DEFINITIONS "Font Software" refers to the set of files released by the Copyright Holder(s) under this license and clearly marked as such. This may include source files, build scripts and documentation. "Reserved Font Name" refers to any names specified as such after the copyright statement(s). "Original Version" refers to the collection of Font Software components as distributed by the Copyright Holder(s). "Modified Version" refers to any derivative made by adding to, deleting, or substituting -- in part or in whole -- any of the components of the Original Version, by changing formats or by porting the Font Software to a new environment. "Author" refers to any designer, engineer, programmer, technical writer or other person who contributed to the Font Software. PERMISSION & CONDITIONS Permission is hereby granted, free of charge, to any person obtaining a copy of the Font Software, to use, study, copy, merge, embed, modify, redistribute, and sell modified and unmodified copies of the Font Software, subject to the following conditions: 1) Neither the Font Software nor any of its individual components, in Original or Modified Versions, may be sold by itself. 2) Original or Modified Versions of the Font Software may be bundled, redistributed and/or sold with any software, provided that each copy contains the above copyright notice and this license. These can be included either as stand-alone text files, human-readable headers or in the appropriate machine-readable metadata fields within text or binary files as long as those fields can be easily viewed by the user. 3) No Modified Version of the Font Software may use the Reserved Font Name(s) unless explicit written permission is granted by the corresponding Copyright Holder. This restriction only applies to the primary font name as presented to the users. 4) The name(s) of the Copyright Holder(s) or the Author(s) of the Font Software shall not be used to promote, endorse or advertise any Modified Version, except to acknowledge the contribution(s) of the Copyright Holder(s) and the Author(s) or with their explicit written permission. 5) The Font Software, modified or unmodified, in part or in whole, must be distributed entirely under this license, and must not be distributed under any other license. The requirement for fonts to remain under this license does not apply to any document created using the Font Software. TERMINATION This license becomes null and void if any of the above conditions are not met. DISCLAIMER THE FONT SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO ANY WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT OF COPYRIGHT, PATENT, TRADEMARK, OR OTHER RIGHT. IN NO EVENT SHALL THE COPYRIGHT HOLDER BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, INCLUDING ANY GENERAL, SPECIAL, INDIRECT, INCIDENTAL, OR CONSEQUENTIAL DAMAGES, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF THE USE OR INABILITY TO USE THE FONT SOFTWARE OR FROM OTHER DEALINGS IN THE FONT SOFTWARE." Must be changed to "This Font Software is licensed under the SIL Open Font License, Version 1.1. This license is available with a FAQ at: https://scripts.sil.org/OFL" [code: wrong] * ⚠ **WARN** Please consider using HTTPS URLs at name table entry [plat=3, enc=1, name=13] [code: http-in-description] * ⚠ **WARN** For now we're still accepting http URLs, but you should consider using https instead. [code: http]
🔥 FAIL: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
* 🔥 **FAIL** Font is missing the 'gasp' table. Try exporting the font with autohinting enabled. If you are dealing with an unhinted font, it can be fixed by running the fonts through the command 'gftools fix-nonhinting' GFTools is available at https://pypi.org/project/gftools/ [code: lacks-gasp]
🔥 FAIL: Copyright notices match canonical pattern in fonts (com.google.fonts/check/font_copyright)
* 🔥 **FAIL** Name Table entry: Copyright notices should match a pattern similar to: "Copyright 2019 The Familyname Project Authors (git url)" But instead we have got: "Copyright (c) 2018-2019, SIL International (http://scripts.sil.org), with Reserved Font Names 'Shimenkan', 'Sapushan', 'Salaowu', and 'Taogu'. Latin glyphs copyright (c) 2010, 2012, 2014 Adobe Systems Incorporated (http://www.adobe.com/), with Reserved Font Name 'Source'." [code: bad-notice-format]
🔥 FAIL: Check glyphs do not have components which are themselves components. (com.google.fonts/check/glyf_nested_components)
* 🔥 **FAIL** The following glyphs have components which themselves are component glyphs: * perthousand * Blinebelow * blinebelow * Ddotbelow * ddotbelow * Dlinebelow * dlinebelow * Hdotbelow * hdotbelow * Hbrevebelow and 53 more. Use -F or --full-lists to disable shortening of long lists. [code: found-nested-components]
🔥 FAIL: Font enables smart dropout control in "prep" table instructions? (com.google.fonts/check/smart_dropout)
* 🔥 **FAIL** The 'prep' table does not contain TrueType instructions enabling smart dropout control. To fix, export the font with autohinting enabled, or run ttfautohint on the font, or run the `gftools fix-nonhinting` script. [code: lacks-smart-dropout]
🔥 FAIL: Name table entries should not contain line-breaks. (com.google.fonts/check/name/line_breaks)
* 🔥 **FAIL** Name entry LICENSE_DESCRIPTION on platform WINDOWS contains a line-break. [code: line-break]
🔥 FAIL: Name table strings must not contain the string 'Reserved Font Name'. (com.google.fonts/check/name/rfn)
* 🔥 **FAIL** Name table entry ("Copyright (c) 2018-2019, SIL International (http://scripts.sil.org), with Reserved Font Names 'Shimenkan', 'Sapushan', 'Salaowu', and 'Taogu'. Latin glyphs copyright (c) 2010, 2012, 2014 Adobe Systems Incorporated (http://www.adobe.com/), with Reserved Font Name 'Source'.") contains "Reserved Font Name". This is an error except in a few specific rare cases. [code: rfn]
🔥 FAIL: OS/2.fsSelection bit 7 (USE_TYPO_METRICS) is set in all fonts. (com.google.fonts/check/os2/use_typo_metrics)
* 🔥 **FAIL** OS/2.fsSelection bit 7 (USE_TYPO_METRICS) wasNOT set in the following fonts: ['/Users/marichalemma/Downloads/SIL_Fontbakery/Shimenkan family/Shimenkan-1.000/Shimenkan-Regular.ttf']. [code: missing-os2-fsselection-bit7]
🔥 FAIL: Checking OS/2 usWinAscent & usWinDescent. (com.google.fonts/check/family/win_ascent_and_descent)
* 🔥 **FAIL** OS/2.usWinDescent value should be equal or greater than 305, but got 234 instead. [code: descent]
🔥 FAIL: Space and non-breaking space have the same width? (com.google.fonts/check/whitespace_widths)
* 🔥 **FAIL** Space and non-breaking space have differing width: The space glyph named space is 113 font units wide, non-breaking space named (nbspace) is 202 font units wide, and both should be positive and the same. GlyphsApp has "Sidebearing arithmetic" (https://glyphsapp.com/tutorials/spacing) which allows you to set the non-breaking space width to always equal the space width. [code: different-widths]
🔥 FAIL: Does the font have any invalid language tags? (com.google.fonts/check/layout_valid_language_tags)
* 🔥 **FAIL** The following invalid language tags were found in the font: YNA , HMDD, HMD , HMZ , YGP , YWQA, LPO , YWQB, SFM [code: bad-language-tags]
WARN: License URL matches License text on name table? (com.google.fonts/check/name/license_url)
* ⚠ **WARN** Please consider using HTTPS URLs at name table entry [plat=3, enc=1, name=13] [code: http-in-description] * ⚠ **WARN** Please consider using HTTPS URLs at name table entry [plat=3, enc=1, name=13] [code: http-in-description] * ⚠ **WARN** Please consider using HTTPS URLs at name table entry [plat=3, enc=1, name=13] [code: http-in-description]
WARN: Check name table: FULL_FONT_NAME entries. (com.google.fonts/check/name/fullfontname)
* ⚠ **WARN** [FULL_FONT_NAME(4):WINDOWS(3)] Got "Shimenkan" which lacks "Regular", but it is probably OK in this case. [code: lacks-regular]
WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
* ⚠ **WARN** This font file does not have a 'meta' table. [code: lacks-meta-table]
WARN: Font has **proper** whitespace glyph names? (com.google.fonts/check/whitespace_glyphnames)
* ⚠ **WARN** Glyph 0x00A0 is called "nbspace": Change to "uni00A0" [code: not-recommended-00a0]
WARN: Check font contains no unreachable glyphs (com.google.fonts/check/unreachable_glyphs)
* ⚠ **WARN** The following glyphs could not be reached by codepoint or substitution rules: - dblgravecmb.cap - circumflexbreve - nine.dnom - six.dnom - space.frac - circumflexbreve.cap - slash.frac - ogonekcmb.cap - And nbspace.frac [code: unreachable-glyphs]
WARN: Check if each glyph has the recommended amount of contours. (com.google.fonts/check/contour_count)
* ⚠ **WARN** This font has a 'Soft Hyphen' character (codepoint 0x00AD) which is supposed to be zero-width and invisible, and is used to mark a hyphenation possibility within a word in the absence of or overriding dictionary hyphenation. It is mostly an obsolete mechanism now, and the character is only included in fonts for legacy codepage coverage. [code: softhyphen] * ⚠ **WARN** This check inspects the glyph outlines and detects the total number of contours in each of them. The expected values are infered from the typical ammounts of contours observed in a large collection of reference font families. The divergences listed below may simply indicate a significantly different design on some of your glyphs. On the other hand, some of these may flag actual bugs in the font such as glyphs mapped to an incorrect codepoint. Please consider reviewing the design and codepoint assignment of these to make sure they are correct. The following glyphs do not have the recommended number of contours: - Glyph name: Q Contours detected: 3 Expected: 2 - Glyph name: R Contours detected: 3 Expected: 1 or 2 - Glyph name: f Contours detected: 2 Expected: 1 - Glyph name: sfthyphen Contours detected: 1 Expected: 0 - Glyph name: Eth Contours detected: 3 Expected: 2 - Glyph name: Dcroat Contours detected: 3 Expected: 2 - Glyph name: dcroat Contours detected: 3 Expected: 2 - Glyph name: hbar Contours detected: 2 Expected: 1 - Glyph name: Lslash Contours detected: 2 Expected: 1 - Glyph name: lslash Contours detected: 2 Expected: 1 - And 56 more. Use -F or --full-lists to disable shortening of long lists. [code: contour-count]
WARN: Check glyphs in mark glyph class are non-spacing. (com.google.fonts/check/gdef_spacing_marks)
* ⚠ **WARN** The following spacing glyphs may be in the GDEF mark glyph class by mistake: acute (U+00B4), breve (U+02D8), caron (U+02C7), cedilla (U+00B8), circumflex (U+02C6), dieresis (U+00A8), dot (unencoded), dotaccent (U+02D9), grave (U+0060), hungarumlaut (U+02DD) and 67 more. Use -F or --full-lists to disable shortening of long lists. [code: spacing-mark-glyphs]
WARN: Check mark characters are in GDEF mark glyph class. (com.google.fonts/check/gdef_mark_chars)
* ⚠ **WARN** The following mark characters could be in the GDEF mark glyph class: u16F4F (U+16F4F), u16F8F.visible (U+16F8F), u16F90.visible (U+16F90), u16F91.visible (U+16F91), u16F92.visible (U+16F92), uniFE00 (U+FE00), uniFE01 (U+FE01), uniFE02 (U+FE02), uniFE03 (U+FE03), uniFE04 (U+FE04) and 10 more. Use -F or --full-lists to disable shortening of long lists. [code: mark-chars]
WARN: Check GDEF mark glyph class doesn't have characters that are not marks. (com.google.fonts/check/gdef_non_mark_chars)
* ⚠ **WARN** The following non-mark characters should not be in the GDEF mark glyph class: U+0060, U+00A8, U+00AF, U+00B4, U+00B8, U+02C6, U+02C7, U+02D8, U+02D9, U+02DA and 3 more. Use -F or --full-lists to disable shortening of long lists. [code: non-mark-chars]
WARN: Does GPOS table have kerning information? This check skips monospaced fonts as defined by post.isFixedPitch value (com.google.fonts/check/gpos_kerning_info)
* ⚠ **WARN** GPOS table lacks kerning information. [code: lacks-kern-info]
WARN: Check for points out of bounds. (com.google.fonts/check/points_out_of_bounds)
* ⚠ **WARN** The following glyphs have coordinates which are out of bounds: * ('u16F22', 545, 656) * ('u16F22', 545, 586) * ('u16F2B', 545, 71) * ('u16F2B', 545, 0) * ('u16F38', 469, 480) * ('u16F38', 469, 409) * ('u16F04_u16F51', 672, 487) * ('u16F04_u16F51', 672, 331) * ('u16F04_u16F51', 672, 174) * ('u16F91.visible', 175, 814) and 84 more. Use -F or --full-lists to disable shortening of long lists. This happens a lot when points are not extremes, which is usually bad. However, fixing this alert by adding points on extremes may do more harm than good, especially with italics, calligraphic-script, handwriting, rounded and other fonts. So it is common to ignore this message. [code: points-out-of-bounds]
WARN: Are there any misaligned on-curve points? (com.google.fonts/check/outline_alignment_miss)
* ⚠ **WARN** The following glyphs have on-curve points which have potentially incorrect y coordinates: * comma (U+002C): X=137.0,Y=2.0 (should be at baseline 0?) * comma (U+002C): X=127.0,Y=-1.0 (should be at baseline 0?) * semicolon (U+003B): X=137.0,Y=2.0 (should be at baseline 0?) * semicolon (U+003B): X=127.0,Y=-1.0 (should be at baseline 0?) * Q (U+0051): X=287.0,Y=2.0 (should be at baseline 0?) * f (U+0066): X=246.0,Y=657.0 (should be at cap-height 656?) * r (U+0072): X=350.0,Y=488.0 (should be at x-height 486?) * y (U+0079): X=207.0,Y=-1.0 (should be at baseline 0?) * registered (U+00AE): X=287.0,Y=656.5 (should be at cap-height 656?) * registered (U+00AE): X=135.5,Y=656.5 (should be at cap-height 656?) and 70 more. Use -F or --full-lists to disable shortening of long lists. [code: found-misalignments]
INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
* ℹ **INFO** Hinting filesize impact: | | /Users/marichalemma/Downloads/SIL_Fontbakery/Shimenkan family/Shimenkan-1.000/Shimenkan-Regular.ttf | |:------------- | ---------------:| | Dehinted Size | 188.9kb | | Hinted Size | 188.8kb | | Increase | -24 bytes | | Change | -0.0 % | [code: size-impact]
INFO: Font has old ttfautohint applied? (com.google.fonts/check/old_ttfautohint)
* ℹ **INFO** Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 1.000'] [code: version-not-detected]
INFO: EPAR table present in font? (com.google.fonts/check/epar)
* ℹ **INFO** EPAR table not present in font. To learn more see https://github.com/googlefonts/fontbakery/issues/818 [code: lacks-EPAR]
INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
* ℹ **INFO** Version string is: "Version 1.000" The version string must ideally include a git commit hash and either a "dev" or a "release" suffix such as in the example below: "Version 1.3; git-0d08353-release" [code: bad-format]
INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
* ℹ **INFO** This font contains the following optional tables: - loca - GPOS - And GSUB [code: optional-tables]
INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
* ℹ **INFO** /Users/marichalemma/Downloads/SIL_Fontbakery/Shimenkan family/Shimenkan-1.000 [code: family-path]

Summary

💔 ERROR 🔥 FAIL ⚠ WARN 💤 SKIP ℹ INFO 🍞 PASS 🔎 DEBUG
0 13 12 110 7 83 0
0% 6% 5% 49% 3% 37% 0%

Note: The following loglevels were omitted in this report:

RosaWagner commented 2 years ago

We will need to discuss that: 🔥 FAIL: OS/2.fsSelection bit 7 (USE_TYPO_METRICS) is set in all fonts. (com.google.fonts/check/os2/use_typo_metrics) 🔥 FAIL: Checking OS/2 usWinAscent & usWinDescent. (com.google.fonts/check/family/win_ascent_and_descent) 🔥 FAIL: Space and non-breaking space have the same width? (com.google.fonts/check/whitespace_widths) 🔥 FAIL: Does the font have any invalid language tags? (com.google.fonts/check/layout_valid_language_tags) 🔥 FAIL The following invalid language tags were found in the font: YNA , HMDD, HMD , HMZ , YGP , YWQA, LPO , YWQB, SFM [code: bad-language-tags]

https://docs.microsoft.com/en-us/typography/opentype/spec/languagetags

+clarify the family and instance naming

RosaWagner commented 2 years ago

On hold for now, waiting for next version Lang tags should be ignored since our data is outdated, and SIL is in discussion with Microsoft to add the missing ones.

We should also ignore all the different families, we will onboard only one "Shimenkan"

jvgaultney commented 2 years ago

Agreed - thanks!

chrissimpkins commented 2 years ago

What is the status here? We're prepared to begin onboarding this family when all issues that blocked it in the past are resolved.

jvgaultney commented 2 years ago

This is waiting for the next release.

chrissimpkins commented 10 months ago

Moving to Icebox. @jvgaultney will you please let us know when the next version release is available? Thanks!

jvgaultney commented 10 months ago

Will do - this has been delayed until later in the year