google / fonts

Font files available from Google Fonts, and a public issue tracker for all things Google Fonts
https://fonts.google.com
18.3k stars 2.64k forks source link

Add Iosevka #4728

Open pinpox opened 2 years ago

pinpox commented 2 years ago

Font Project Git Repo URL: https://github.com/be5invis/Iosevka

Super short description of the Font Family: Versatile typeface for code, from code.

Requirements:

I understand that Google Fonts will publish only fonts that matches its requirements, and I can confirm the project meets them (by ticking the cases, or putting x between the square brackets in text mode):

Image:

Attach here a pic or a screenshot of the font; one is enough, it can be few letters, to give a quick overview.

image

pvinis commented 2 years ago

lets tag @be5invis too here

RosaWagner commented 2 years ago

Thanks for the submission. We'll try to review it and will get back to you if it is accepted.

Some settings are not compliant with GF requirements, which I invite you to read more about here: https://googlefonts.github.io/gf-guide/

Making the font GF-friendly would imply important metadata change, so if the author actually wants to collaborate, may he make himself known in this thread. Otherwise we won't be able to make it happen.

pvinis commented 2 years ago

wow theres a lot of musts there. I wonder if it makes more sense @be5invis to make another repo that is just for google fonts, and it justs hosts the files in the right form, so not many changes have to happen on the main repo of iosevka.

Diablo-D3 commented 2 years ago

@RosaWagner Can you explain to me the exact things Iosevka does not comply with? The document linked above is lengthy and doesn't really provide a clear-cut actionable plan.

pvinis commented 2 years ago

@Diablo-D3 come on, lets not make it harder. the link is pretty clear. there are some musts there. just open a couple of them and you'll see that the iosevka repo is not in line with. (which is totally fine btw, and that's why I suggested we make a separate repo for conforming to google fonts requirements.)

take this as an example, https://googlefonts.github.io/gf-guide/upstream.html#the-essentials-explained. the repo needs to have this "layout", and its not. that would be the first this I fix.

AlbinoGeek commented 3 months ago

Now that this is literally the top result on Google:

For anyone wanting to use this font w/o waiting on this...

https://fontsource.org/fonts/iosevka/install

pvinis commented 3 months ago

Nice nice! I also have it here, but I only add versions whenever I feel like it 😅 https://github.com/pvinis/iosevka-webfont

emmamarichal commented 3 months ago

Hi @pinpox @be5invis, I'm Emma and I work in the Google Fonts team. I opened the last release of Ioseka, to have a first look and give you a feedback. However, I only found .ttc format. In GF, we only onboard ttf. Could you provide that in the release? thank you!

pvinis commented 3 months ago

@emmamarichal every release has many formats. ttf is included. check here https://github.com/be5invis/Iosevka/releases/tag/v31.1.0 and scroll down. there's ttc, ttf, webfont.

emmamarichal commented 3 months ago

Thank you!

I run fontbakery on Iosevka-Bold.ttf for example, it seems there are a lot of fails to solve. Fontbakery.zip

Just to be sure I understand the design space, we have 2 families to onboard:

We will review the font and let you know asap! Cheers!

be5invis commented 3 months ago

I do not have much bandwidth on creating packages for GF now. Some of the failures are not easy to fix, like the .join-l/.join-m/.join-r glyph name suffixes are used in Kitty's ligature support, changing them will require at least one major version bump. Also GF require a fixed repo structure? If so then I may need to setup another repo that is just for GF, and put some "tailored" build script there...

vv-monsalve commented 3 months ago

We had discussed this inclusion with @be5invis in the past, but he said the same about the extra work required to meet GF requirements, so we declined the expectations to include this font.

We can close this issue here.

davelab6 commented 3 months ago

I think like Inter we may just have to fork and maintain a version for our requirements in collaboration with @be5invis when we allocate more time to such in-depth projects. Let's park this in the icebox as this is a wildly popular libre font outside GF and ought to be available :)