Add Pixelify Sans - Githubissues

eifetx commented 1 year ago

Font Project Git Repo URL: https://github.com/eifetx/Pixelify-Sans

Super short description of the Font Family: pixel display font. It works great for your retro party designs, game creation or pretty much anything that demands a “go back in time” vibe.

Requirements:

I understand that Google Fonts will publish only fonts that matches its requirements, and I can confirm the project meets them (by ticking the cases, or putting x between the square brackets in text mode):

[x] The entire font project is licensed under the OFL
[x] There is no "Reserved Font Name" mention in the OFL license
[x] Family name is unique according to namecheck.fontdata.com
[x] The font supports at least GF Latin Core glyphset
[x] The repository respect the upstream repo structure
[x] The source files are available in the repository
[x] I read, agree and comply with the full contributing requirements
[x] I am the author of the font or the author agreed to this submission
[x] I will maintain the repository

Image:

Attach here a pic or a screenshot of the font; one is enough, it can be few letters, to give a quick overview. PREVIEW (1)

RosaWagner commented 1 year ago

Hi again @eifetx, thanks for your submission. Very cool pixel font! Unfortunately we can't give reviews when the sources are missing from the repository. Would you consider adding them?

jdavidleon commented 1 year ago

Hi, could you tell me how I can know when a font is ready to be incorporated into Google Fonts and I can collaborate by uploading it?

eifetx commented 1 year ago

Hi, could you tell me how I can know when a font is ready to be incorporated into Google Fonts and I can collaborate by uploading it?

Hi. i just upload the missing file. you want to collaborate with this fonts ?

eifetx commented 1 year ago

Hi again @eifetx, thanks for your submission. Very cool pixel font! Unfortunately we can't give reviews when the sources are missing from the repository. Would you consider adding them?

Hi, Rosa. i just upload the missing file. thanks for letting me know

jdavidleon commented 1 year ago

Hi, could you tell me how I can know when a font is ready to be incorporated into Google Fonts and I can collaborate by uploading it?

Hi. i just upload the missing file. you want to collaborate with this fonts ?

Hi, I would like to collaborate, but I am new to this topic, I had never collaborated before. Although I was reading the documentation and apparently if you were missing a file. If you could give me the summarized step by step to guide me, it would help me a lot.

eifetx commented 1 year ago

Hi, could you tell me how I can know when a font is ready to be incorporated into Google Fonts and I can collaborate by uploading it?

Hi. i just upload the missing file. you want to collaborate with this fonts ?

Hi, I would like to collaborate, but I am new to this topic, I had never collaborated before. Although I was reading the documentation and apparently if you were missing a file. If you could give me the summarized step by step to guide me, it would help me a lot.

thank you for interest this font. im new too in github, im never collaborated with someone else. maybe, we should wait Rosa for review this fonts

cancermood commented 1 year ago

Hi @eifetx, nice work! Will these fonts be available on Google Fonts? Thanks

eifetx commented 1 year ago

Hi @eifetx, nice work! Will these fonts be available on Google Fonts? Thanks

hello, thank you for interest this font. unfortunately, this font isn't available on google fonts. or you should ask @RosaWagner thanks!

emmamarichal commented 1 year ago

Hi @eifetx!

I'm Emma, working with the Google Fonts team and I've been assigned to this project :)

There are indeed several rules/specifications to follow in order to publish a project on Google Fonts. Here are a very good documentation done by our team, where you can find a lot of informations about it: https://googlefonts.github.io/gf-guide/index

New fonts guide: https://googlefonts.github.io/gf-guide/onboarding.html#new-fonts

But I can start to guide you for the main issues 👍

Here is a list of what you should modify:

[ ] Glyphset: you will find attached the Glyphs file with the missing glyphs coloured in pink (IJ Germandbls idotaccent ij jdotless ordfeminine ordmasculine nbspace periodcentered.loclCAT periodcentered.loclCAT.case dieresiscomb dotaccentcomb gravecomb acutecomb hungarumlautcomb caroncomb.alt circumflexcomb caroncomb brevecomb ringcomb tildecomb macroncomb commaturnedabovecomb commaaccentcomb cedillacomb ogonekcomb dieresis dotaccent acute hungarumlaut circumflex caron breve ring tilde macron cedilla ogonek)
[ ] Font infos: copyright, parameters, v-metrics, instances, features, you can have a look to the guide, but if you are not sure, I'll do it, no worries!
[ ] Readme: https://googlefonts.github.io/gf-guide/readmefile.html Don't hesitate to add some images :)
[ ] It's better if you draw the .notdef
[ ] Accents: Here is the diacritics guide: https://googlefonts.github.io/gf-guide/diacritics.html

First, accented letters should be composites, made of components. To create this, select all your accented letters and do Glyphs > create composite (hold "option" to display "for all masters") I advice you to copy your design in the background, to not loose the accents positions (select all your glyphs and cmd + J in the two masters)

All your base glyphs need to have anchors (cmd + U)

The accent attached to the letter is a "combining accent", with the suffix "comb". They have anchors too, that are linked the the letters ones.

Accents without "comb" suffix are called "legacy accents" and should be a composite

In the source file attached, I give you an exemple with the grave accent (on 'è'). You can follow this modele for the rest of the glyphset :)

Pixelfy Sans.glyphs.zip

I run fontbakery to get a report and find fails. There are some but I can easily fix them on my side. I still copy/paste it here if you are interested to solve them by yourself.

Fontbakery report

Fontbakery version: 0.8.13

[1] Family checks

ℹ INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)

* ℹ **INFO** From a total of 1 font files, 0 of them (0.00%) lack a STAT table. And these are the most common STAT axis orderings: ('wght', 1) [code: summary]

[29] Pixelfy Sans[wght].ttf

🔥 FAIL: Checking file is named canonically. (com.google.fonts/check/canonical_filename)

* 🔥 **FAIL** Expected "PixelifySans[wght].ttf. Got Pixelfy Sans[wght].ttf. [code: bad-filename]

🔥 FAIL: Checking OS/2 fsType does not impose restrictions. (com.google.fonts/check/fstype)

* 🔥 **FAIL** In this font fsType is set to 8 meaning that: The font may be embedded but must only be installed temporarily on other systems. No such DRM restrictions can be enabled on the Google Fonts collection, so the fsType field must be set to zero (Installable Embedding) instead. [code: drm]

🔥 FAIL: Copyright notices match canonical pattern in fonts (com.google.fonts/check/font_copyright)

* 🔥 **FAIL** Name Table entry: Copyright notices should match a pattern similar to: "Copyright 2019 The Familyname Project Authors (git url)" But instead we have got: "Copyright (c) 2021 by Stefie Justprince. All rights reserved." [code: bad-notice-format]

🔥 FAIL: Check variable font instances (com.google.fonts/check/fvar_instances)

🔥 FAIL: Check font follows the Google Fonts vertical metric schema (com.google.fonts/check/vertical_metrics)

* 🔥 **FAIL** OS/2.sTypoLineGap is "200" it should be 0 [code: bad-OS/2.sTypoLineGap] * 🔥 **FAIL** The sum of hhea.ascender + abs(hhea.descender) + hhea.lineGap is 1000 when it should be at least 1200 [code: bad-hhea-range]

🔥 FAIL: OS/2.fsSelection bit 7 (USE_TYPO_METRICS) is set in all fonts. (com.google.fonts/check/os2/use_typo_metrics)

* 🔥 **FAIL** OS/2.fsSelection bit 7 (USE_TYPO_METRICS) wasNOT set in the following fonts: ['Pixelfy Sans[wght].ttf']. [code: missing-os2-fsselection-bit7]

🔥 FAIL: Checking OS/2 usWinAscent & usWinDescent. (com.google.fonts/check/family/win_ascent_and_descent)

* 🔥 **FAIL** OS/2.usWinAscent value should be equal or greater than 916, but got 750 instead [code: ascent]

🔥 FAIL: Checking OS/2 Metrics match hhea Metrics. (com.google.fonts/check/os2_metrics_match_hhea)

* 🔥 **FAIL** OS/2 sTypoAscender (631) and hhea ascent (800) must be equal. [code: ascender]

🔥 FAIL: Ensure soft_dotted characters lose their dot when combined with marks that replace the dot. (com.google.fonts/check/soft_dotted)

* 🔥 **FAIL** The dot of soft dotted characters used in orthographies must disappear in the following strings: i̊ i̋ j̀ j́ j̃ j̄ j̈ į̀ į́ į̂ į̃ į̄ į̌ і́ The dot of soft dotted characters should disappear in other cases, for example: i̇ ǐ i̒ i̦̇ i̦̊ i̦̋ ǐ̦ i̦̒ i̧̇ i̧̊ i̧̋ ǐ̧ i̧̒ j̆ j̇ j̊ j̋ ǰ j̒ j̦̀ [code: soft-dotted]

🔥 FAIL: The variable font 'wght' (Weight) axis coordinate must be 700 on the 'Bold' instance. (com.google.fonts/check/varfont/bold_wght_coord)

* 🔥 **FAIL** The "wght" axis coordinate of the "Bold" instance must be 700. Got 650.0 instead. [code: wght-not-700]

🔥 FAIL: STAT table has Axis Value tables? (com.adobe.fonts/check/stat_has_axis_value_tables)

* 🔥 **FAIL** STAT table is missing Axis Value for 'wght' value '650.0' [code: missing-axis-value-table]

⚠ WARN: Checking OS/2 achVendID. (com.google.fonts/check/vendor_id)

* ⚠ **WARN** OS/2 VendorID value 'NONE' is not yet recognized. If you registered it recently, then it's safe to ignore this warning message. Otherwise, you should set it to your own unique 4 character code, and register it with Microsoft at https://www.microsoft.com/typography/links/vendorlist.aspx [code: unknown]

⚠ WARN: Check Google Fonts glyph coverage. (com.google.fonts/check/glyph_coverage)

* ⚠ **WARN** GF_Cyrillic_Core is almost fulfilled. Missing codepoints: - 0x0400 (CYRILLIC CAPITAL LETTER IE WITH GRAVE) - 0x040D (CYRILLIC CAPITAL LETTER I WITH GRAVE) - 0x041E (CYRILLIC CAPITAL LETTER O) - 0x041F (CYRILLIC CAPITAL LETTER PE) - 0x0406 (CYRILLIC CAPITAL LETTER BYELORUSSIAN-UKRAINIAN I) - 0x0450 (CYRILLIC SMALL LETTER IE WITH GRAVE) - 0x045D (CYRILLIC SMALL LETTER I WITH GRAVE) [code: missing-codepoints] * ⚠ **WARN** GF_Greek_Core is almost fulfilled. Missing codepoints: - 0x03CF (GREEK CAPITAL KAI SYMBOL) - 0x03C2 (GREEK SMALL LETTER FINAL SIGMA) - 0x03AF (GREEK SMALL LETTER IOTA WITH TONOS) - 0x03CA (GREEK SMALL LETTER IOTA WITH DIALYTIKA) - 0x0390 (GREEK SMALL LETTER IOTA WITH DIALYTIKA AND TONOS) - 0x03CB (GREEK SMALL LETTER UPSILON WITH DIALYTIKA) - 0x03B0 (GREEK SMALL LETTER UPSILON WITH DIALYTIKA AND TONOS) - 0x03D7 (GREEK KAI SYMBOL) - 0x0387 (GREEK ANO TELEIA) - 0x037E (GREEK QUESTION MARK) - 4 more. Use -F or --full-lists to disable shortening of long lists. [code: missing-codepoints]

⚠ WARN: Are there caret positions declared for every ligature? (com.google.fonts/check/ligature_carets)

* ⚠ **WARN** This font lacks caret position values for ligature glyphs on its GDEF table. [code: lacks-caret-pos]

⚠ WARN: Is there kerning info for non-ligated sequences? (com.google.fonts/check/kerning_for_non_ligated_sequences)

* ⚠ **WARN** GPOS table lacks kerning info for the following non-ligated sequences: - f + i - i + l [code: lacks-kern-info]

⚠ WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)

* ⚠ **WARN** This font file does not have a 'meta' table. [code: lacks-meta-table]

⚠ WARN: Font contains '.notdef' as its first glyph? (com.google.fonts/check/mandatory_glyphs)

* ⚠ **WARN** Glyph '.notdef' should contain a drawing, but it is empty. [code: empty]

⚠ WARN: Check font contains no unreachable glyphs (com.google.fonts/check/unreachable_glyphs)

* ⚠ **WARN** The following glyphs could not be reached by codepoint or substitution rules: - i.loclTRK - periodcentered.loclCAT - periodcentered.loclCAT.case - uni030C.alt [code: unreachable-glyphs]

⚠ WARN: Ensure dotted circle glyph is present and can attach marks. (com.google.fonts/check/dotted_circle)

* ⚠ **WARN** No dotted circle glyph present [code: missing-dotted-circle]

⚠ WARN: Check math signs have the same width. (com.google.fonts/check/math_signs_width)

* ⚠ **WARN** The most common width is 403 among a set of 3 math glyphs. The following math glyphs have a different width, though: Width = 586: plusminus, plus Width = 556: greater, less Width = 502: minus, logicalnot Width = 528: multiply Width = 368: approxequal Width = 438: greaterequal, lessequal [code: width-outliers]

⚠ WARN: Checking Vertical Metric Linegaps. (com.google.fonts/check/linegaps)

* ⚠ **WARN** OS/2 sTypoLineGap is not equal to 0. [code: OS/2]

⚠ WARN: Are there any misaligned on-curve points? (com.google.fonts/check/outline_alignment_miss)

* ⚠ **WARN** The following glyphs have on-curve points which have potentially incorrect y coordinates: * Q (U+0051): X=433.0,Y=-192.0 (should be at descender -193?) * Q (U+0051): X=333.0,Y=-192.0 (should be at descender -193?) * grave (U+0060): X=105.0,Y=630.0 (should be at ascender 631?) * grave (U+0060): X=60.0,Y=630.0 (should be at ascender 631?) * uni00B2 (U+00B2): X=256.0,Y=629.0 (should be at ascender 631?) * uni00B2 (U+00B2): X=106.0,Y=629.0 (should be at ascender 631?) * Oslash (U+00D8): X=330.0,Y=-2.0 (should be at baseline 0?) * Oslash (U+00D8): X=248.0,Y=-2.0 (should be at baseline 0?) * egrave (U+00E8): X=220.0,Y=630.0 (should be at ascender 631?) * egrave (U+00E8): X=175.0,Y=630.0 (should be at ascender 631?) * 86 more. Use -F or --full-lists to disable shortening of long lists. [code: found-misalignments]

ℹ INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)

* ℹ **INFO** Hinting filesize impact: | | Pixelfy Sans[wght].ttf | |:------------- | ---------------:| | Dehinted Size | 86.4kb | | Hinted Size | 86.4kb | | Increase | 24 bytes | | Change | 0.0 % | [code: size-impact]

ℹ INFO: Font has old ttfautohint applied? (com.google.fonts/check/old_ttfautohint)

* ℹ **INFO** Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 1.000;gftools[0.9.32]'] [code: version-not-detected]

ℹ INFO: EPAR table present in font? (com.google.fonts/check/epar)

* ℹ **INFO** EPAR table not present in font. To learn more see https://github.com/googlefonts/fontbakery/issues/818 [code: lacks-EPAR]

ℹ INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)

* ℹ **INFO** These are the ppm ranges declared on the gasp table: PPM <= 65535: flag = 0x0F - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType® [code: ranges]

ℹ INFO: Check for font-v versioning. (com.google.fonts/check/fontv)

* ℹ **INFO** Version string is: "Version 1.000;gftools[0.9.32]" The version string must ideally include a git commit hash and either a "dev" or a "release" suffix such as in the example below: "Version 1.3; git-0d08353-release" [code: bad-format]

ℹ INFO: Font contains all required tables? (com.google.fonts/check/required_tables)

* ℹ **INFO** This font contains the following optional tables: - loca - prep - GPOS - GSUB - gasp [code: optional-tables]

ℹ INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)

* ℹ **INFO** . [code: family-path]

Summary

💔 ERROR	🔥 FAIL	⚠ WARN	💤 SKIP	ℹ INFO	🍞 PASS	🔎 DEBUG
0	11	11	104	8	112	0
0%	4%	4%	42%	3%	46%	0%

Note: The following loglevels were omitted in this report:

SKIP
PASS
DEBUG

Don't hesitate if you have any questions! Cheers! Emma

eifetx commented 1 year ago

hello @emmamarichal . thank you for responding. im just checked file from your attached, im still working on it.

my questions,

If this font can be boarding on Google Fonts, is it possible for me to only want "regular" only ? i think there are too many warnings on this axis font
After I fix this font, can I just attach it here or do I have to update the repository?

emmamarichal commented 1 year ago

Hi @eifetx,

Don't worry about the warning about the weight axis, I often have them and I can fix it easily. And yes, you can update the repo with the new files, tell me when it's updated :)

Thanks a lot!

eifetx commented 1 year ago

hi @emmamarichal

thank you in advance you have helped a lot

I have fixed and have updated my repo. if what I fixed still has issues, please let me know.

emmamarichal commented 1 year ago

@eifetx Great, thanks a lot! :)

google / fonts

Add Pixelify Sans #5910

Here is a list of what you should modify:

Fontbakery report

Summary