google / fonts

Font files available from Google Fonts, and a public issue tracker for all things Google Fonts
https://fonts.google.com
18.3k stars 2.64k forks source link

Add Saitamaar #7014

Open scrpgil opened 1 year ago

scrpgil commented 1 year ago

Font Project Git Repo URL: https://github.com/asciiart-development/SaitamaarFont

Super short description of the Font Family: Saitamaar is a font designed specifically for ASCII art. It is particularly optimized for displaying Japanese SJIS-Art (Shift JIS Art).

Requirements:

Google Fonts will publish only fonts that match its requirements. Please familiarize yourself with the complete documentation in the Google Fonts Guide (GF-Guide) and ensure your font project complies with them before submitting the font family. You can also use the Google Fonts Project Template, which will help you create a repository that follows the needed structure and includes build requirements.

By filling this issue, you can confirm the project meets the requirements (by ticking the cases or putting x between the square brackets in text mode):

Image:

image1

image2

image-saitamaar

RosaWagner commented 1 year ago

Hi @scrpgil, thanks for your submission and using the gf-repo-template. This looks very promising.

Although it looks like:

davelab6 commented 1 year ago

Thanks @RosaWagner , agreed

@keage please could you confirm here you are the sole copyright holder, and you are OK with the font being redistributed under the Open Font License?

scrpgil commented 1 year ago

Thank you for your review. I am happy to answer some of your questions.

you are not the author of the font, would it be possible to contact them to back up this submission?

I am not the creator of the font. I have obtained permission from the creator to submit it to Google Fonts and have created the UFO file based on that.

the ufo source has been made from opening an .otf file into fontforge, to then export to ufo with no further changes, can you confirm?

As you pointed out, the metadata such as the license was not set. I will make sure to update and set it accordingly.

the font metadata doesn't display any info about the license; is the author actually okay to license this font under OFL? I understand the font was provided for the public domain under a specific license allowing that, but I don't know if the change license is still legal or not. cc @davelab6

I have received permission from the author to distribute the font under the OFL license.

@keage please could you confirm here you are the sole copyright holder, and you are OK with the font being redistributed under the Open Font License?

I will contact keage to ask them to respond to this issue.

keage commented 12 months ago

Sorry for late reply.

I (@keage) am the creator and the sole copyright holder of Saitamaar. I totally agreed with the font being redistributed under the OFL.

RosaWagner commented 12 months ago

@keage thanks for answering, this is absolutely nice of you. Then we will try to review this submission shortly and give you prompt feedback on the decision.

eliheuer commented 12 months ago

@scrpgil @keage This fonts has some unusual and uneven spacing. Note how some characters are pushed to the far left of the bounding box, but others are centered. Is there a reason I don't understand for this?

Screenshot 2023-12-07 at 4 46 30 AM Screenshot 2023-12-07 at 4 47 15 AM Screenshot 2023-12-07 at 4 47 39 AM
eliheuer commented 12 months ago

This font has a huge character set, including CJK:

Screenshot 2023-12-07 at 7 43 44 AM
eliheuer commented 12 months ago

And Yi scripts:

Screenshot 2023-12-07 at 7 45 03 AM
eliheuer commented 12 months ago

Cyrillic and greek:

Screenshot 2023-12-07 at 7 46 34 AM
eliheuer commented 12 months ago

Armenian:

Screenshot 2023-12-07 at 7 52 19 AM
eliheuer commented 12 months ago

Hebrew and Japanese

Screenshot 2023-12-07 at 7 53 20 AM
eliheuer commented 12 months ago

Dingbats:

Screenshot 2023-12-07 at 7 54 12 AM
eliheuer commented 11 months ago

@scrpgil Hello, Saitamaar was reviewed and given the OK for onboarding to Google Fonts in the first quarter of next year(2024).

Please see the Google Fonts Guide for the guidelines, requirements, and specifications: https://googlefonts.github.io/gf-guide/

I can help get things up to spec in the new year. Please ask any questions here. Thanks!