google / fonts

Font files available from Google Fonts, and a public issue tracker for all things Google Fonts
https://fonts.google.com
18.22k stars 2.62k forks source link

Update Urbanist #7116

Open coreyhu opened 10 months ago

coreyhu commented 10 months ago

Font Project Git Repo URL: https://github.com/coreyhu/Urbanist

Current version: 1.303

New available version: 1.330

Super short description of the upgrade: (expand style, expand glyphset, improve rendering, bug fix…) Expanded glyphset, glyphset bugfixes and improvements

Bugs reported in this repo which this upgrade would fix: Search in the issue tracker if there is some opened issues containing the font name.

6942

emmamarichal commented 10 months ago

Hi @coreyhu! Thanks a lot for this update!

I took a look to the exported fonts, and I saw some kerning/spacing issues:

Screenshot 2024-01-03 at 10 45 50 Screenshot 2024-01-03 at 10 46 11

Screenshot 2024-01-03 at 13 44 53 Screenshot 2024-01-03 at 13 45 06 Screenshot 2024-01-03 at 13 45 34 Screenshot 2024-01-03 at 13 45 45

Also, the dieresis looks a bit close to the letters, I'd move it up a bit:

Screenshot 2024-01-03 at 10 47 26

There are also a lot of fails for the Italic (in the fontbakery report). I can correct it this month, once you change the spacing and kerning values. I'll then make a PR to Google (you can close the one you opened if you want!) But thanks for opening a PR on the google repo, we appreciate when designers are involved in the process :)

FontBakery report

fontbakery version: 0.10.8

[1] Family checks
INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)
* ℹ **INFO** From a total of 2 font files, 0 of them (0.00%) lack a STAT table. And these are the most common STAT axis orderings: ('wght-ital', 2) [code: summary]

[19] Urbanist[wght].ttf
WARN: DESCRIPTION.en_us.html should end in a linebreak. (com.google.fonts/check/description/eof_linebreak)
* ⚠ **WARN** The last characther on DESCRIPTION.en_us.html is not a line-break. Please add it. [code: missing-eof-linebreak]
WARN: Check for codepoints not covered by METADATA subsets. (com.google.fonts/check/metadata/unreachable_subsetting)
* ⚠ **WARN** The following codepoints supported by the font are not covered by any subsets defined in the font's metadata file, and will never be served. You can solve this by either manually adding additional subset declarations to METADATA.pb, or by editing the glyphset definitions. * U+02C7 CARON: try adding one of: yi, tifinagh, canadian-aboriginal * U+02D8 BREVE: try adding one of: yi, canadian-aboriginal * U+02D9 DOT ABOVE: try adding one of: yi, canadian-aboriginal * U+02DB OGONEK: try adding one of: yi, canadian-aboriginal * U+02DD DOUBLE ACUTE ACCENT: not included in any glyphset definition * U+0306 COMBINING BREVE: try adding one of: old-permic, tifinagh * U+030A COMBINING RING ABOVE: try adding syriac * U+030B COMBINING DOUBLE ACUTE ACCENT: try adding one of: cherokee, osage * U+030C COMBINING CARON: try adding one of: cherokee, tai-le * U+0312 COMBINING TURNED COMMA ABOVE: not included in any glyphset definition 55 more. Use -F or --full-lists to disable shortening of long lists. Or you can add the above codepoints to one of the subsets supported by the font: `latin`, `latin-ext`, `math`, `menu`, `symbols` [code: unreachable-subsetting]
WARN: Glyphs are similiar to Google Fonts version? (com.google.fonts/check/production_glyphs_similarity)
* ⚠ **WARN** Following glyphs differ greatly from Google Fonts version: * .notdef * A * AE * Aacute * Abreve * Acircumflex * Adieresis * Agrave * Amacron * Aogonek and 424 more. Use -F or --full-lists to disable shortening of long lists.
WARN: Is there kerning info for non-ligated sequences? (com.google.fonts/check/kerning_for_non_ligated_sequences)
* ⚠ **WARN** GPOS table lacks kerning info for the following non-ligated sequences: - f + i - i + l [code: lacks-kern-info]
WARN: METADATA.pb: Designers are listed correctly on the Google Fonts catalog? (com.google.fonts/check/metadata/designer_profiles)
* ⚠ **WARN** It seems that Corey Hu is still not listed on the designers catalog. Please submit a photo and a link to a webpage where people can learn more about the work of this designer/typefoundry. [code: profile-not-found]
WARN: Check font contains no unreachable glyphs (com.google.fonts/check/unreachable_glyphs)
* ⚠ **WARN** The following glyphs could not be reached by codepoint or substitution rules: - i.001 - uni030C.alt [code: unreachable-glyphs]
WARN: Does the font contain a soft hyphen? (com.google.fonts/check/soft_hyphen)
* ⚠ **WARN** This font has a 'Soft Hyphen' character. [code: softhyphen]
WARN: Detect any interpolation issues in the font. (com.google.fonts/check/interpolation_issues)
* ⚠ **WARN** Interpolation issues were found in the font: - Contour 1 start point differs in glyph 'registered' between location wght=400 and location wght=100 - Contour 1 start point differs in glyph 'registered' between location wght=100 and location wght=900 - Contour 4 start point differs in glyph 'uni25CC' between location wght=100 and location wght=900 [code: interpolation-issues]
WARN: Check math signs have the same width. (com.google.fonts/check/math_signs_width)
* ⚠ **WARN** The most common width is 1160 among a set of 10 math glyphs. The following math glyphs have a different width, though: Width = 980: logicalnot Width = 977: multiply Width = 1236: approxequal [code: width-outliers]
WARN: Ensure soft_dotted characters lose their dot when combined with marks that replace the dot. (com.google.fonts/check/soft_dotted)
* ⚠ **WARN** The dot of soft dotted characters used in orthographies _must_ disappear in the following strings: į̀ į́ į̂ į̃ į̄ į̌ ị̀ ị́ ị̂ ị̃ ị̄ The dot of soft dotted characters _should_ disappear in other cases, for example: į̆ į̇ į̈ į̊ į̋ į̒ į̣̀ į̣́ į̣̂ į̣̃ į̣̄ į̣̆ į̣̇ į̣̈ į̣̊ į̣̋ į̣̌ į̣̒ į̦̀ į̦́ Your font fully covers the following languages that require the soft-dotted feature: Avokaya (Latn, 100,000 speakers), Navajo (Latn, 166,319 speakers), Ebira (Latn, 2,200,000 speakers), Lithuanian (Latn, 2,357,094 speakers), Igbo (Latn, 27,823,640 speakers), Dutch (Latn, 31,709,104 speakers), Ma’di (Latn, 584,000 speakers). Your font does *not* cover the following languages that require the soft-dotted feature: Koonzime (Latn, 40,000 speakers), Ejagham (Latn, 120,000 speakers), Sar (Latn, 500,000 speakers), Mundani (Latn, 34,000 speakers), Bafut (Latn, 158,146 speakers), Nzakara (Latn, 50,000 speakers), Gulay (Latn, 250,478 speakers), Zapotec (Latn, 490,000 speakers), Mfumte (Latn, 79,000 speakers), Kom (Latn, 360,685 speakers), Basaa (Latn, 332,940 speakers), Southern Kisi (Latn, 360,000 speakers), Lugbara (Latn, 2,200,000 speakers), Ukrainian (Cyrl, 29,273,587 speakers), Nateni (Latn, 100,000 speakers), Fur (Latn, 1,230,163 speakers), South Central Banda (Latn, 244,000 speakers), Belarusian (Cyrl, 10,064,517 speakers), Aghem (Latn, 38,843 speakers), Bete-Bendi (Latn, 100,000 speakers), Dan (Latn, 1,099,244 speakers), Ijo, Southeast (Latn, 2,471,000 speakers), Mango (Latn, 77,000 speakers). [code: soft-dotted]
INFO: Does DESCRIPTION file contain a upstream Git repo URL? (com.google.fonts/check/description/git_url)
* ℹ **INFO** Found a git repo URL: https://github.com/coreyhu/Urbanist [code: url-found]
INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
* ℹ **INFO** Hinting filesize impact: | | ofl/urbanist/Urbanist[wght].ttf | |:------------- | ---------------:| | Dehinted Size | 98.8kb | | Hinted Size | 98.9kb | | Increase | 24 bytes | | Change | 0.0 % | [code: size-impact]
INFO: Font has old ttfautohint applied? (com.google.fonts/check/old_ttfautohint)
* ℹ **INFO** Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 1.330'] [code: version-not-detected]
INFO: EPAR table present in font? (com.google.fonts/check/epar)
* ℹ **INFO** EPAR table not present in font. To learn more see https://github.com/fonttools/fontbakery/issues/818 [code: lacks-EPAR]
INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
* ℹ **INFO** These are the ppm ranges declared on the gasp table: PPM <= 65535: flag = 0x0F - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType® [code: ranges]
INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
* ℹ **INFO** Version string is: "Version 1.330" The version string must ideally include a git commit hash and either a "dev" or a "release" suffix such as in the example below: "Version 1.3; git-0d08353-release" [code: bad-format]
INFO: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
* ℹ **INFO** Latn [code: dlng-tag] * ℹ **INFO** Latn [code: slng-tag]
INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
* ℹ **INFO** This font contains the following optional tables: - loca - prep - GPOS - GSUB - gasp [code: optional-tables]
INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
* ℹ **INFO** ofl/urbanist [code: family-path]

[26] Urbanist-Italic[wght].ttf
🔥 FAIL: Check name ID 25 to end with "Italic" for Italic VFs. (com.google.fonts/check/metadata/valid_nameid25)
* 🔥 **FAIL** Name ID 25 must end with "Italic" for Italic fonts. [code: nameid25-missing-italic]
🔥 FAIL: Check a font's STAT table contains compulsory Axis Values. (com.google.fonts/check/STAT)
* 🔥 **FAIL** Compulsory STAT Axis Values are incorrect: | Name | Axis | Current Value | Current Flags | Current LinkedValue | Expected Value | Expected Flags | Expected LinkedValue | | :--- | :--- | :--- | :--- | :--- | :--- | :--- | :--- | | Thin | wght | 100.0 | 0 | None | 100.0 | 0 | None | | ExtraLight | wght | 200.0 | 0 | None | 200.0 | 0 | None | | Light | wght | 300.0 | 0 | None | 300.0 | 0 | None | | Regular | wght | N/A | N/A | N/A | 400.0 | 2 | 700.0 | | Medium | wght | 500.0 | 0 | None | 500.0 | 0 | None | | SemiBold | wght | 600.0 | 0 | None | 600.0 | 0 | None | | Bold | wght | 700.0 | 0 | None | 700.0 | 0 | None | | ExtraBold | wght | 800.0 | 0 | None | 800.0 | 0 | None | | Black | wght | 900.0 | 0 | None | 900.0 | 0 | None | | Italic | wght | 400.0 | 2 | 700.0 | N/A | N/A | N/A | [code: bad-axis-values]
🔥 FAIL: Validate STAT particle names and values match the fallback names in GFAxisRegistry. (com.google.fonts/check/STAT/gf_axisregistry)
* 🔥 **FAIL** On the font variation axis 'wght', the name 'Italic' is not among the expected ones (Thin, ExtraLight, Light, Regular, Medium, SemiBold, Bold, ExtraBold, Black) according to the Google Fonts Axis Registry. [code: invalid-name]
🔥 FAIL: Check correctness of STAT table strings (com.google.fonts/check/STAT_strings)
* 🔥 **FAIL** The following AxisValue entries on the STAT table should not contain "Italic": ['nameID 2: Italic'] [code: bad-italic]
🔥 FAIL: Checking post.italicAngle value. (derived from com.google.fonts/check/italic_angle) (com.google.fonts/check/italic_angle)
* 🔥 **FAIL** Font is italic, so post.italicAngle should be non-zero. [code: zero-italic]
🔥 FAIL: Check hhea.caretSlopeRise and hhea.caretSlopeRun (com.google.fonts/check/caret_slope)
* 🔥 **FAIL** hhea.caretSlopeRise and hhea.caretSlopeRun do not match with post.italicAngle. Got: caretSlopeRise 1000 and caretSlopeRun 141 Expected: caretSlopeRise 1 and caretSlopeRun 0 [code: caretslope-mismatch]
WARN: DESCRIPTION.en_us.html should end in a linebreak. (com.google.fonts/check/description/eof_linebreak)
* ⚠ **WARN** The last characther on DESCRIPTION.en_us.html is not a line-break. Please add it. [code: missing-eof-linebreak]
WARN: Check for codepoints not covered by METADATA subsets. (com.google.fonts/check/metadata/unreachable_subsetting)
* ⚠ **WARN** The following codepoints supported by the font are not covered by any subsets defined in the font's metadata file, and will never be served. You can solve this by either manually adding additional subset declarations to METADATA.pb, or by editing the glyphset definitions. * U+02C7 CARON: try adding one of: yi, tifinagh, canadian-aboriginal * U+02D8 BREVE: try adding one of: yi, canadian-aboriginal * U+02D9 DOT ABOVE: try adding one of: yi, canadian-aboriginal * U+02DB OGONEK: try adding one of: yi, canadian-aboriginal * U+02DD DOUBLE ACUTE ACCENT: not included in any glyphset definition * U+0306 COMBINING BREVE: try adding one of: old-permic, tifinagh * U+030A COMBINING RING ABOVE: try adding syriac * U+030B COMBINING DOUBLE ACUTE ACCENT: try adding one of: cherokee, osage * U+030C COMBINING CARON: try adding one of: cherokee, tai-le * U+0312 COMBINING TURNED COMMA ABOVE: not included in any glyphset definition 55 more. Use -F or --full-lists to disable shortening of long lists. Or you can add the above codepoints to one of the subsets supported by the font: `latin`, `latin-ext`, `math`, `menu`, `symbols` [code: unreachable-subsetting]
WARN: Glyphs are similiar to Google Fonts version? (com.google.fonts/check/production_glyphs_similarity)
* ⚠ **WARN** Following glyphs differ greatly from Google Fonts version: * .notdef * A * AE * Aacute * Abreve * Acircumflex * Adieresis * Agrave * Amacron * Aogonek and 428 more. Use -F or --full-lists to disable shortening of long lists.
WARN: Is there kerning info for non-ligated sequences? (com.google.fonts/check/kerning_for_non_ligated_sequences)
* ⚠ **WARN** GPOS table lacks kerning info for the following non-ligated sequences: - f + i - i + l [code: lacks-kern-info]
WARN: METADATA.pb: Designers are listed correctly on the Google Fonts catalog? (com.google.fonts/check/metadata/designer_profiles)
* ⚠ **WARN** It seems that Corey Hu is still not listed on the designers catalog. Please submit a photo and a link to a webpage where people can learn more about the work of this designer/typefoundry. [code: profile-not-found]
WARN: On a family update, the DESCRIPTION.en_us.html file should ideally also be updated. (com.google.fonts/check/description/family_update)
* ⚠ **WARN** The DESCRIPTION.en_us.html file in this family has not changed in comparison to the latest font release on the google/fonts github repo. Please consider mentioning note-worthy improvements made to the family recently. [code: description-not-updated]
WARN: Check font contains no unreachable glyphs (com.google.fonts/check/unreachable_glyphs)
* ⚠ **WARN** The following glyphs could not be reached by codepoint or substitution rules: - i.001 - uni030C.alt [code: unreachable-glyphs]
WARN: Does the font contain a soft hyphen? (com.google.fonts/check/soft_hyphen)
* ⚠ **WARN** This font has a 'Soft Hyphen' character. [code: softhyphen]
WARN: Detect any interpolation issues in the font. (com.google.fonts/check/interpolation_issues)
* ⚠ **WARN** Interpolation issues were found in the font: - Contour 1 start point differs in glyph 'registered' between location wght=400 and location wght=100 - Contour 1 start point differs in glyph 'registered' between location wght=100 and location wght=900 - Contour 4 start point differs in glyph 'uni25CC' between location wght=100 and location wght=900 [code: interpolation-issues]
WARN: Check math signs have the same width. (com.google.fonts/check/math_signs_width)
* ⚠ **WARN** The most common width is 1160 among a set of 10 math glyphs. The following math glyphs have a different width, though: Width = 980: logicalnot Width = 977: multiply Width = 1236: approxequal [code: width-outliers]
WARN: Ensure soft_dotted characters lose their dot when combined with marks that replace the dot. (com.google.fonts/check/soft_dotted)
* ⚠ **WARN** The dot of soft dotted characters used in orthographies _must_ disappear in the following strings: į̀ į́ į̂ į̃ į̄ į̌ ị̀ ị́ ị̂ ị̃ ị̄ The dot of soft dotted characters _should_ disappear in other cases, for example: į̆ į̇ į̈ į̊ į̋ į̒ į̣̀ į̣́ į̣̂ į̣̃ į̣̄ į̣̆ į̣̇ į̣̈ į̣̊ į̣̋ į̣̌ į̣̒ į̦̀ į̦́ Your font fully covers the following languages that require the soft-dotted feature: Avokaya (Latn, 100,000 speakers), Navajo (Latn, 166,319 speakers), Ebira (Latn, 2,200,000 speakers), Lithuanian (Latn, 2,357,094 speakers), Igbo (Latn, 27,823,640 speakers), Dutch (Latn, 31,709,104 speakers), Ma’di (Latn, 584,000 speakers). Your font does *not* cover the following languages that require the soft-dotted feature: Koonzime (Latn, 40,000 speakers), Ejagham (Latn, 120,000 speakers), Sar (Latn, 500,000 speakers), Mundani (Latn, 34,000 speakers), Bafut (Latn, 158,146 speakers), Nzakara (Latn, 50,000 speakers), Gulay (Latn, 250,478 speakers), Zapotec (Latn, 490,000 speakers), Mfumte (Latn, 79,000 speakers), Kom (Latn, 360,685 speakers), Basaa (Latn, 332,940 speakers), Southern Kisi (Latn, 360,000 speakers), Lugbara (Latn, 2,200,000 speakers), Ukrainian (Cyrl, 29,273,587 speakers), Nateni (Latn, 100,000 speakers), Fur (Latn, 1,230,163 speakers), South Central Banda (Latn, 244,000 speakers), Belarusian (Cyrl, 10,064,517 speakers), Aghem (Latn, 38,843 speakers), Bete-Bendi (Latn, 100,000 speakers), Dan (Latn, 1,099,244 speakers), Ijo, Southeast (Latn, 2,471,000 speakers), Mango (Latn, 77,000 speakers). [code: soft-dotted]
INFO: Does DESCRIPTION file contain a upstream Git repo URL? (com.google.fonts/check/description/git_url)
* ℹ **INFO** Found a git repo URL: https://github.com/coreyhu/Urbanist [code: url-found]
INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
* ℹ **INFO** Hinting filesize impact: | | ofl/urbanist/Urbanist-Italic[wght].ttf | |:------------- | ---------------:| | Dehinted Size | 101.5kb | | Hinted Size | 101.6kb | | Increase | 24 bytes | | Change | 0.0 % | [code: size-impact]
INFO: Font has old ttfautohint applied? (com.google.fonts/check/old_ttfautohint)
* ℹ **INFO** Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 1.330'] [code: version-not-detected]
INFO: EPAR table present in font? (com.google.fonts/check/epar)
* ℹ **INFO** EPAR table not present in font. To learn more see https://github.com/fonttools/fontbakery/issues/818 [code: lacks-EPAR]
INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
* ℹ **INFO** These are the ppm ranges declared on the gasp table: PPM <= 65535: flag = 0x0F - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType® [code: ranges]
INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
* ℹ **INFO** Version string is: "Version 1.330" The version string must ideally include a git commit hash and either a "dev" or a "release" suffix such as in the example below: "Version 1.3; git-0d08353-release" [code: bad-format]
INFO: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
* ℹ **INFO** Latn [code: dlng-tag] * ℹ **INFO** Latn [code: slng-tag]
INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
* ℹ **INFO** This font contains the following optional tables: - loca - prep - GPOS - GSUB - gasp [code: optional-tables]
INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
* ℹ **INFO** ofl/urbanist [code: family-path]

Summary

💔 ERROR ☠ FATAL 🔥 FAIL ⚠ WARN 💤 SKIP ℹ INFO 🍞 PASS 🔎 DEBUG
0 0 6 21 78 19 368
0% 0% 1% 4% 16% 4% 75%

Note: The following loglevels were omitted in this report:

coreyhu commented 10 months ago

Thanks I'll take a look this week

emmamarichal commented 4 months ago

Hi @coreyhu, did you have the time to fix the issues mentionned? :)

emmamarichal commented 3 months ago

Hi @coreyhu! Could you take a look to this issue too? https://github.com/google/fonts/issues/7913#issuecomment-2221654736 It seems there is an issue with the macron accent. It would be great if we could solve that.

I'll also investigate on my side and let you know if I have any clue for solving it

emmamarichal commented 3 months ago

Oh, it seems the issue is solved in your last version. Then I just need you take a look to the kerning (comment above), and we are good!

emmamarichal commented 1 month ago

@chrissimpkins we can move it to Q4