search

google / fonts

Font files available from Google Fonts, and a public issue tracker for all things Google Fonts
https://fonts.google.com
18.29k stars 2.64k forks source link

Add primary_script definitions across all families that target non-Latin based languages #7284

Closed chrissimpkins closed 2 months ago

chrissimpkins commented 9 months ago

Opening a tracker to address this issue catalog-wide.

chrissimpkins commented 9 months ago

@simoncozens Can I ask you to summarize how far you got with the automated approach to address this? Not urgent. I've tentatively got this queued up for Q2 but we can begin working on it earlier if we are reasonably far along with an approach.

simoncozens commented 9 months ago

There is a gftools script called gftools-set-primary-script which can be run on the fonts/ofl directory. It works fairly well, although there are a few caveats:

1) if a font includes a companion Latin (which they all have to do) which has a larger glyphset than the "designed" glyphset, then the Latin is considered primary. 2) it fails on kana-only Japanese. 3) it is not smart about multi-script fonts. 4) it obviously produces a lot of changes - 262 files in the run I just did - and we like metadata changes to be batched into small chunks.

But I think it is worth running, reviewing the output, and perhaps making piecemeal PRs.

chrissimpkins commented 7 months ago

Let's look into this issue this quarter. Tentatively assigning you, @simoncozens.

chrissimpkins commented 5 months ago

Any progress on this one @simoncozens?

chrissimpkins commented 4 months ago

Moving to Q3. @simoncozens and @m4rc1e, I added both of you to this one. Can I ask the two of you to connect early in the quarter on a plan about how to address this? Thanks.

m4rc1e commented 2 months ago

I'll chat to Simon but I think we've completed this, https://github.com/google/fonts/pulls?q=is%3Apr+Set+primary+scripts+is%3Aclosed.

simoncozens commented 2 months ago

I think so too!