google / fonts

Font files available from Google Fonts, and a public issue tracker for all things Google Fonts
https://fonts.google.com
17.87k stars 2.6k forks source link

Playwrite SK: Version 1.002 added #7735

Closed vv-monsalve closed 1 month ago

vv-monsalve commented 2 months ago

Taken from the upstream repo https://github.com/TypeTogether/Playwrite at commit https://github.com/TypeTogether/Playwrite/commit/e53bd89e9d46f46f0f8ce089fdef3a869130f670.

PR Checklist:

github-actions[bot] commented 2 months ago

FontBakery report

fontbakery version: 0.12.6

Experimental checks

These won't break the CI job for now, but will become effective after some time if nobody raises any concern.

[1] PlaywriteSK[wght].ttf
⚠️ WARN Validate location, size and resolution of article images.
* ⚠️ **WARN**

There are 3 image files in the article directory and they should be moved to an article/images subdirectory:

- ofl/playwritesk/article/Playwrite-Slovensko-1.png

- ofl/playwritesk/article/Playwrite-Slovensko-2.png

- ofl/playwritesk/article/Playwrite-Slovensko-3.png
[code: misplaced-image-files]

All other checks

[14] PlaywriteSK[wght].ttf
⚠️ WARN Check for points out of bounds.
* ⚠️ **WARN**

The following glyphs have coordinates which are out of bounds: * ('Aacute', 728, 1254) * ('Aacute', 734, 1254) * ('Aacute', 744, 1254) * ('AEacute', 1081, 1254) * ('AEacute', 1087, 1254) * ('AEacute', 1097, 1254) * ('Agrave', 557, 1254) * ('Agrave', 566, 1254) * ('Agrave', 573, 1254) * ('Cacute', 825, 1254) and 110 more.

Use -F or --full-lists to disable shortening of long lists.

This happens a lot when points are not extremes, which is usually bad. However, fixing this alert by adding points on extremes may do more harm than good, especially with italics, calligraphic-script, handwriting, rounded and other fonts. So it is common to ignore this message.

[code: points-out-of-bounds]
⚠️ WARN Glyph names are all valid?
* ⚠️ **WARN**

The following glyph names may be too long for some legacy systems which may expect a maximum 31-characters length limit: circumflexcomb_hookabovecomb.case

[code: legacy-long-names]
⚠️ WARN Font has **proper** whitespace glyph names?
* ⚠️ **WARN**

Glyph 0x00A0 is called "nbspace": Change to "uni00A0"

[code: not-recommended-00a0]
⚠️ WARN Ensure soft_dotted characters lose their dot when combined with marks that replace the dot.
* ⚠️ **WARN**

The dot of soft dotted characters should disappear in other cases, for example: ị̀ ị́ ị̂ ị̃ ị̄ ị̆ ị̇ ị̈ ị̉ ị̊ ị̋ ị̒ i̦̇ i̦̊ i̦̋ i̦̒ i̧̇ i̧̊ i̧̋ i̧̒

Your font fully covers the following languages that require the soft-dotted feature: Lithuanian (Latn, 2,357,094 speakers), Dutch (Latn, 31,709,104 speakers).

Your font does not cover the following languages that require the soft-dotted feature: Sar (Latn, 500,000 speakers), Kpelle, Guinea (Latn, 622,000 speakers), Koonzime (Latn, 40,000 speakers), Aghem (Latn, 38,843 speakers), Mango (Latn, 77,000 speakers), Nzakara (Latn, 50,000 speakers), Ebira (Latn, 2,200,000 speakers), Vute (Latn, 21,000 speakers), Bete-Bendi (Latn, 100,000 speakers), Bafut (Latn, 158,146 speakers), Gulay (Latn, 250,478 speakers), Basaa (Latn, 332,940 speakers), Yala (Latn, 200,000 speakers), Mfumte (Latn, 79,000 speakers), Makaa (Latn, 221,000 speakers), Igbo (Latn, 27,823,640 speakers), Ejagham (Latn, 120,000 speakers), Ekpeye (Latn, 226,000 speakers), Navajo (Latn, 166,319 speakers), Southern Kisi (Latn, 360,000 speakers), Ijo, Southeast (Latn, 2,471,000 speakers), Belarusian (Cyrl, 10,064,517 speakers), Avokaya (Latn, 100,000 speakers), Ma’di (Latn, 584,000 speakers), South Central Banda (Latn, 244,000 speakers), Ukrainian (Cyrl, 29,273,587 speakers), Ngbaka (Latn, 1,020,000 speakers), Fur (Latn, 1,230,163 speakers), Kom (Latn, 360,685 speakers), Mundani (Latn, 34,000 speakers), Nateni (Latn, 100,000 speakers), Dii (Latn, 71,000 speakers), Cicipu (Latn, 44,000 speakers), Dan (Latn, 1,099,244 speakers), Lugbara (Latn, 2,200,000 speakers), Zapotec (Latn, 490,000 speakers).

[code: soft-dotted]
⚠️ WARN Check for codepoints not covered by METADATA subsets.
* ⚠️ **WARN**

The following codepoints supported by the font are not covered by any subsets defined in the font's metadata file, and will never be served. You can solve this by either manually adding additional subset declarations to METADATA.pb, or by editing the glyphset definitions.

  • U+02C7 CARON: try adding one of: canadian-aboriginal, yi, tifinagh
  • U+02D8 BREVE: try adding one of: canadian-aboriginal, yi
  • U+02D9 DOT ABOVE: try adding one of: canadian-aboriginal, yi
  • U+02DB OGONEK: try adding one of: canadian-aboriginal, yi
  • U+02DD DOUBLE ACUTE ACCENT: not included in any glyphset definition
  • U+0306 COMBINING BREVE: try adding one of: old-permic, tifinagh
  • U+030A COMBINING RING ABOVE: try adding syriac
  • U+030B COMBINING DOUBLE ACUTE ACCENT: try adding one of: osage, cherokee
  • U+030C COMBINING CARON: try adding one of: tai-le, cherokee
  • U+0312 COMBINING TURNED COMMA ABOVE: not included in any glyphset definition 8 more.

Use -F or --full-lists to disable shortening of long lists.

Or you can add the above codepoints to one of the subsets supported by the font: latin, latin-ext, math, menu, vietnamese

[code: unreachable-subsetting]
⚠️ WARN Ensure variable fonts include an avar table.
* ⚠️ **WARN**

This variable font does not have an avar table.

[code: missing-avar]
⚠️ WARN Check font follows the Google Fonts vertical metric schema
* ⚠️ **WARN**

We recommend the absolute sum of the hhea metrics should be between 1.2-1.5x of the font's upm. This font has 1.899x (1899)

[code: bad-hhea-range]
ℹ️ INFO List all superfamily filepaths
* ℹ️ **INFO**

ofl/playwritesk

[code: family-path]
ℹ️ INFO Font contains all required tables?
* ℹ️ **INFO**

This font contains the following optional tables:

- loca

- prep

- GPOS

- GSUB

- gasp
[code: optional-tables]
ℹ️ INFO EPAR table present in font?
* ℹ️ **INFO**

EPAR table not present in font. To learn more see https://github.com/fonttools/fontbakery/issues/818

[code: lacks-EPAR]
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering?
* ℹ️ **INFO**

These are the ppm ranges declared on the gasp table:

PPM <= 65535: flag = 0x0F - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType®

[code: ranges]
ℹ️ INFO Show hinting filesize impact.
* ℹ️ **INFO**

Hinting filesize impact:

ofl/playwritesk/PlaywriteSK[wght].ttf
Dehinted Size 345.3kb
Hinted Size 345.3kb
Increase 24 bytes
Change 0.0 %
[code: size-impact]
ℹ️ INFO Ensure fonts have ScriptLangTags declared on the 'meta' table.
* ℹ️ **INFO**

Latn,af,ca,cs,cy,da,en,es,et,eu,fr,ga,hi,hr,hu,id,is,it,nl,no,pl,pt,ro,sk,sl,sv,tr,vi,wa,yo,zu

[code: dlng-tag] * ℹ️ **INFO**

Latn,af,ca,cs,cy,da,en,es,et,eu,fr,ga,hi,hr,hu,id,is,it,nl,no,pl,pt,ro,sk,sl,sv,tr,vi,wa,yo,zu

[code: slng-tag]
ℹ️ INFO Font has old ttfautohint applied?
* ℹ️ **INFO**

Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 1.002']

[code: version-not-detected]
[1] Family checks
ℹ️ INFO Check axis ordering on the STAT table.
* ℹ️ **INFO**

None of the fonts lack a STAT table.

And these are the most common STAT axis orderings:
('wght', 1)
[code: summary]

Summary

💥 ERROR ☠ FATAL 🔥 FAIL ⚠️ WARN ⏩ SKIP ℹ️ INFO ✅ PASS 🔎 DEBUG
0 0 0 8 52 8 183 0
0% 0% 0% 3% 21% 3% 73% 0%

Note: The following loglevels were omitted in this report:

emmamarichal commented 1 month ago

@vv-monsalve Just needs a confirmation for the caron: it's not the good shape used, but since this langage maybe doesn't use it, we can ignore?

Screenshot 2024-05-29 at 17 31 55 Screenshot 2024-05-29 at 17 36 13
emmamarichal commented 1 month ago

otherwise lgtm!

vv-monsalve commented 1 month ago

@vv-monsalve Just needs a confirmation for the caron: it's not the good shape used, but since this langage maybe doesn't use it, we can ignore?

I can confirm this is the expected shape for the caron in Slovakia (this) and Czechia (CZ) models. It was discussed here.