search

google / fonts

Font files available from Google Fonts, and a public issue tracker for all things Google Fonts
https://fonts.google.com
18.11k stars 2.61k forks source link

Deduplicate lookups in Crimson Text #7760

Open IvanUkhov opened 4 months ago

IvanUkhov commented 4 months ago

Describe the bug

There are duplicate lookups in the same feature record.

To Reproduce

ttx -t GSUB ofl/crimsontext/CrimsonText-Regular.ttf
      …
      <FeatureRecord index="2">
        <FeatureTag value="ccmp"/>
        <Feature>
          <!-- LookupCount=6 -->
          <LookupListIndex index="0" value="0"/>
          <LookupListIndex index="1" value="3"/>
          <LookupListIndex index="2" value="6"/>
          <LookupListIndex index="3" value="7"/>
          <LookupListIndex index="4" value="6"/>
          <LookupListIndex index="5" value="7"/>
        </Feature>
      </FeatureRecord>
      …

Expected behavior

Unless I am missing something, it should not happen.

vv-monsalve commented 4 months ago

Hi @IvanUkhov, thank you for your report. @emmamarichal will take a look at it and let you know about it.

emmamarichal commented 4 months ago

Hi @IvanUkhov! Could you send me some images or example of what it is affected by this? So I can solve this easier, with more context? thank you!

IvanUkhov commented 4 months ago

I do not have any images. I am just parsing the font data. It is more of a question. Maybe it is intentional that lookups 6 and 7 should be done twice for some reason.

emmamarichal commented 4 months ago

I'm not sure if this is intentional, but the features are automatically generated. I'll have to investigate, but as it doesn't seem to affect the font visually, I won't be adding this to our priority milestone.