google / fonts

Font files available from Google Fonts, and a public issue tracker for all things Google Fonts
https://fonts.google.com
17.87k stars 2.6k forks source link

Noto Sans Khudawadi: Version 2.004; ttfautohint (v1.8.4.7-5d5b) added #7765

Closed simoncozens closed 1 month ago

simoncozens commented 1 month ago

Taken from the upstream repo https://github.com/notofonts/khudawadi at commit https://github.com/notofonts/khudawadi/commit/77a425be0b41864390f3b973dbd41c9ad47922b9.

PR Checklist:

github-actions[bot] commented 1 month ago

FontBakery report

fontbakery version: 0.12.6

Experimental checks

These won't break the CI job for now, but will become effective after some time if nobody raises any concern.

[1] NotoSansKhudawadi-Regular.ttf
ℹ️ INFO METADATA.pb: Validate family.minisite_url field.
* ℹ️ **INFO**

Please consider adding a family.minisite_url entry.

[code: lacks-minisite-url]

All other checks

[12] NotoSansKhudawadi-Regular.ttf
🔥 FAIL Check for presence of an ARTICLE.en_us.html file
* 🔥 **FAIL**

This is a Noto font but it lacks a DESCRIPTION.en_us.html file.

[code: missing-description]
⚠️ WARN Check if each glyph has the recommended amount of contours.
* ⚠️ **WARN**

This check inspects the glyph outlines and detects the total number of contours in each of them. The expected values are infered from the typical ammounts of contours observed in a large collection of reference font families. The divergences listed below may simply indicate a significantly different design on some of your glyphs. On the other hand, some of these may flag actual bugs in the font such as glyphs mapped to an incorrect codepoint. Please consider reviewing the design and codepoint assignment of these to make sure they are correct.

The following glyphs do not have the recommended number of contours:

- Glyph name: aogonek    Contours detected: 3    Expected: 2

- Glyph name: uogonek   Contours detected: 2    Expected: 1

- Glyph name: aogonek   Contours detected: 3    Expected: 2

- Glyph name: uogonek   Contours detected: 2    Expected: 1
[code: contour-count]
⚠️ WARN Check math signs have the same width.
* ⚠️ **WARN**

The most common width is 572 among a set of 6 math glyphs. The following math glyphs have a different width, though:

Width = 322: minus

[code: width-outliers]
⚠️ WARN Are any segments inordinately short?
* ⚠️ **WARN**

The following glyphs have segments which seem very short:

* u112B0 (U+112B0) contains a short segment B<<923.0,65.0>-<931.0,65.0>-<946.0,67.5>>

* u112B0 (U+112B0) contains a short segment B<<946.0,67.5>-<961.0,70.0>-<976.0,75.0>>

* u112B0 (U+112B0) contains a short segment B<<966.0,0.0>-<952.0,-6.0>-<936.0,-8.0>>

* u112B0 (U+112B0) contains a short segment B<<936.0,-8.0>-<920.0,-10.0>-<904.0,-10.0>>

* u112B1 (U+112B1) contains a short segment B<<923.0,65.0>-<931.0,65.0>-<946.0,67.5>>

* u112B1 (U+112B1) contains a short segment B<<946.0,67.5>-<961.0,70.0>-<976.0,75.0>>

* u112B1 (U+112B1) contains a short segment B<<966.0,0.0>-<952.0,-6.0>-<936.0,-8.0>>

* u112B1 (U+112B1) contains a short segment B<<936.0,-8.0>-<920.0,-10.0>-<904.0,-10.0>>

* u112B6 (U+112B6) contains a short segment B<<923.0,65.0>-<931.0,65.0>-<946.0,67.5>>

* u112B6 (U+112B6) contains a short segment B<<946.0,67.5>-<961.0,70.0>-<976.0,75.0>>

* 90 more.

Use -F or --full-lists to disable shortening of long lists.

[code: found-short-segments]
⚠️ WARN Ensure soft_dotted characters lose their dot when combined with marks that replace the dot.
* ⚠️ **WARN**

The dot of soft dotted characters used in orthographies must disappear in the following strings: į̀ į́ į̂ į̃ į̄ į̌

The dot of soft dotted characters should disappear in other cases, for example: į̆ į̇ į̈ į̊ į̋ į̦̀ į̦́ į̦̂ į̦̃ į̦̄ į̦̆ į̦̇ į̦̈ į̦̊ į̦̋ į̦̌ į̧̀ į̧́ į̧̂ į̧̃

Your font fully covers the following languages that require the soft-dotted feature: Dutch (Latn, 31,709,104 speakers), Lithuanian (Latn, 2,357,094 speakers).

Your font does not cover the following languages that require the soft-dotted feature: Ekpeye (Latn, 226,000 speakers), Ukrainian (Cyrl, 29,273,587 speakers), Navajo (Latn, 166,319 speakers), Sar (Latn, 500,000 speakers), Dii (Latn, 71,000 speakers), Cicipu (Latn, 44,000 speakers), Mango (Latn, 77,000 speakers), Vute (Latn, 21,000 speakers), Southern Kisi (Latn, 360,000 speakers), Kpelle, Guinea (Latn, 622,000 speakers), Nzakara (Latn, 50,000 speakers), Nateni (Latn, 100,000 speakers), Ejagham (Latn, 120,000 speakers), Gulay (Latn, 250,478 speakers), Bete-Bendi (Latn, 100,000 speakers), Makaa (Latn, 221,000 speakers), Kom (Latn, 360,685 speakers), Lugbara (Latn, 2,200,000 speakers), Igbo (Latn, 27,823,640 speakers), Ngbaka (Latn, 1,020,000 speakers), South Central Banda (Latn, 244,000 speakers), Yala (Latn, 200,000 speakers), Ebira (Latn, 2,200,000 speakers), Fur (Latn, 1,230,163 speakers), Ma’di (Latn, 584,000 speakers), Mfumte (Latn, 79,000 speakers), Zapotec (Latn, 490,000 speakers), Aghem (Latn, 38,843 speakers), Basaa (Latn, 332,940 speakers), Bafut (Latn, 158,146 speakers), Belarusian (Cyrl, 10,064,517 speakers), Ijo, Southeast (Latn, 2,471,000 speakers), Koonzime (Latn, 40,000 speakers), Avokaya (Latn, 100,000 speakers), Mundani (Latn, 34,000 speakers), Dan (Latn, 1,099,244 speakers).

[code: soft-dotted]
⚠️ WARN Check for codepoints not covered by METADATA subsets.
* ⚠️ **WARN**

The following codepoints supported by the font are not covered by any subsets defined in the font's metadata file, and will never be served. You can solve this by either manually adding additional subset declarations to METADATA.pb, or by editing the glyphset definitions.

  • U+02C7 CARON: try adding one of: canadian-aboriginal, yi, tifinagh
  • U+02C9 MODIFIER LETTER MACRON: not included in any glyphset definition
  • U+02D8 BREVE: try adding one of: canadian-aboriginal, yi
  • U+02D9 DOT ABOVE: try adding one of: canadian-aboriginal, yi
  • U+02DB OGONEK: try adding one of: canadian-aboriginal, yi
  • U+02DD DOUBLE ACUTE ACCENT: not included in any glyphset definition
  • U+0302 COMBINING CIRCUMFLEX ACCENT: try adding one of: coptic, tifinagh, cherokee, math
  • U+0306 COMBINING BREVE: try adding one of: old-permic, tifinagh
  • U+0307 COMBINING DOT ABOVE: try adding one of: malayalam, old-permic, canadian-aboriginal, coptic, tai-le, math, syriac, tifinagh
  • U+030A COMBINING RING ABOVE: try adding syriac 5 more.

Use -F or --full-lists to disable shortening of long lists.

Or you can add the above codepoints to one of the subsets supported by the font: khudawadi, latin, latin-ext, menu

[code: unreachable-subsetting]
⚠️ WARN Ensure fonts have ScriptLangTags declared on the 'meta' table.
* ⚠️ **WARN**

This font file does not have a 'meta' table.

[code: lacks-meta-table]
ℹ️ INFO List all superfamily filepaths
* ℹ️ **INFO**

ofl/notosanskhudawadi

[code: family-path]
ℹ️ INFO Font contains all required tables?
* ℹ️ **INFO**

This font contains the following optional tables:

- cvt 

- fpgm

- loca

- prep

- GPOS

- GSUB

- gasp
[code: optional-tables]
ℹ️ INFO EPAR table present in font?
* ℹ️ **INFO**

EPAR table not present in font. To learn more see https://github.com/fonttools/fontbakery/issues/818

[code: lacks-EPAR]
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering?
* ℹ️ **INFO**

These are the ppm ranges declared on the gasp table:

PPM <= 65535: flag = 0x0F - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType®

[code: ranges]
ℹ️ INFO Show hinting filesize impact.
* ℹ️ **INFO**

Hinting filesize impact:

ofl/notosanskhudawadi/NotoSansKhudawadi-Regular.ttf
Dehinted Size 48.4kb
Hinted Size 67.2kb
Increase 18.8kb
Change 38.9 %
[code: size-impact]
[1] Family checks
ℹ️ INFO Check axis ordering on the STAT table.
* ℹ️ **INFO**

All of the fonts lack a STAT table.

[code: summary]

Summary

💥 ERROR ☠ FATAL 🔥 FAIL ⚠️ WARN ⏩ SKIP ℹ️ INFO ✅ PASS 🔎 DEBUG
0 0 1 6 71 7 166 0
0% 0% 0% 2% 28% 3% 66% 0%

Note: The following loglevels were omitted in this report:

vv-monsalve commented 1 month ago

I've seen you deleted the Description file, but now FB complains about it being this a Noto project. Should the check be updated?

vv-monsalve commented 1 month ago

@simoncozens, the font is showing tofu on Sandbox

Screen Shot 2024-05-31 at 12 46 25
simoncozens commented 1 month ago

This was a bad sample text, I fixed it in lang 0.6.0. However, the 0.6.0 changed sample texts never appeared in the push lists.

vv-monsalve commented 5 days ago

Needs #7680 to land