search

google / fonts

Font files available from Google Fonts, and a public issue tracker for all things Google Fonts
https://fonts.google.com
17.84k stars 2.6k forks source link

Fix sample text of Cantonese; Add sample text for Hakka; Rename Chinese languages in a consistent format #7782

Closed laubonghaudoi closed 1 month ago

laubonghaudoi commented 1 month ago

This PR fixes the following issues:

  1. The original sample text of yue_Hant (Cantonese) is actually in Simplified Chinese characters. This PR updates them into Traditional Chinese characters.
  2. Sample text for Hakka Chinese was missing. This PR adds sample texts for Hakka.
  3. The naming of Chinese languages was inconsistent. This PR renames them with the consistent XX Chinese format.
simoncozens commented 1 month ago

This is really helpful, thank you - however, the lang directory here is a subtree pulled in from the googlefonts/lang repository. So we will need this update there.

chrissimpkins commented 1 month ago

Thank you very much for this contribution!

Going to close as a merge will break our git subtree. As Simon mentioned, https://github.com/googlefonts/lang is the correct upstream location for these changes. You'll find the same file path structure and it should be as simple as a copy/paste into the new repo.

laubonghaudoi commented 1 month ago

Ah thank you! I will PR to that repo