google / fonts

Font files available from Google Fonts, and a public issue tracker for all things Google Fonts
https://fonts.google.com
17.84k stars 2.6k forks source link

Noto Naskh Arabic: Version 2.019 added #7791

Closed simoncozens closed 1 month ago

simoncozens commented 1 month ago

Taken from the upstream repo https://github.com/notofonts/arabic at commit https://github.com/notofonts/arabic/commit/136d96955b0581da8718eb4cdb2e700a723aefc6.

PR Checklist:

github-actions[bot] commented 1 month ago

FontBakery report

fontbakery version: 0.12.6

Experimental checks

These won't break the CI job for now, but will become effective after some time if nobody raises any concern.

[1] NotoNaskhArabic[wght].ttf
ℹ️ INFO METADATA.pb: Validate family.minisite_url field.
* ℹ️ **INFO**

Please consider adding a family.minisite_url entry.

[code: lacks-minisite-url]

All other checks

[20] NotoNaskhArabic[wght].ttf
🔥 FAIL Check that glyph for U+0675 ARABIC LETTER HIGH HAMZA is not a mark.
* 🔥 **FAIL**

The arabic letter high hamza (U+0675) should have roughly the same size the arabic letter hamza (U+0621), but a different glyph outline area was detected.

[code: glyph-area]
🔥 FAIL Ensure dotted circle glyph is present and can attach marks.
* 🔥 **FAIL**

The following glyphs could not be attached to the dotted circle glyph:

- acutecomb

- gravecomb

- tildecomb

- uni0302

- uni0304

- uni0306

- uni0307

- uni0308

- uni030A

- uni030B

- 10 more.

Use -F or --full-lists to disable shortening of long lists.

[code: unattached-dotted-circle-marks]
🔥 FAIL Shapes languages in all GF glyphsets.
* 🔥 **FAIL**

GF_Arabic_Core glyphset:

Language FAIL messages
ar_Arab (Arabic) Shaper didn't attach uni0655 to None
^ Shaper didn't attach uni0655 to space
[code: failed-language-shaping] * ⚠️ **WARN**

GF_Arabic_Plus glyphset:

Language WARN messages
ms_Arab (Malay (Arabic)) No exemplar glyphs were defined for language Malay (Arabic)
[code: warning-language-shaping]
🔥 FAIL Check for presence of an ARTICLE.en_us.html file
* 🔥 **FAIL**

This is a Noto font but it lacks a DESCRIPTION.en_us.html file.

[code: missing-description]
⚠️ WARN Detect any interpolation issues in the font.
* ⚠️ **WARN**

Interpolation issues were found in the font:

- Contour 0 point 72 in glyph 'uni06AA' has a kink between location wght=400 and location wght=700

- Contour 0 point 26 in glyph 'uni0665.lf' has a kink between location wght=400 and location wght=700
[code: interpolation-issues]
⚠️ WARN Check math signs have the same width.
* ⚠️ **WARN**

The most common width is 559 among a set of 6 math glyphs. The following math glyphs have a different width, though:

Width = 310: minus

[code: width-outliers]
⚠️ WARN Check font contains no unreachable glyphs
* ⚠️ **WARN**

The following glyphs could not be reached by codepoint or substitution rules:

- alayh.1

- alayh.2

- fatha.1

- la.1

- radiya.1

- uni0640.wide

- uni06F7.mark
[code: unreachable-glyphs]
⚠️ WARN Glyph names are all valid?
* ⚠️ **WARN**

The following glyph names may be too long for some legacy systems which may expect a maximum 31-characters length limit: twodotshorizontalabove_tahabovear, twodotshorizontalabovear.diagonal, twodotshorizontalbelow_tahabovear and twodotshorizontalcenter_tahabovear

[code: legacy-long-names]
⚠️ WARN Check the direction of the outermost contour in each glyph
* ⚠️ **WARN**

The following glyphs have a counter-clockwise outer contour:

* uniFD46 (U+FD46) has a counter-clockwise outer contour

* uniFD46 (U+FD46) has a counter-clockwise outer contour

* uniFD46 (U+FD46) has a counter-clockwise outer contour
[code: ccw-outer-contour]
⚠️ WARN Ensure soft_dotted characters lose their dot when combined with marks that replace the dot.
* ⚠️ **WARN**

The dot of soft dotted characters used in orthographies must disappear in the following strings: į̀ į́ į̂ į̃ į̄ į̌

The dot of soft dotted characters should disappear in other cases, for example: į̆ į̇ į̈ į̊ į̋ į̦̀ į̦́ į̦̂ į̦̃ į̦̄ į̦̆ į̦̇ į̦̈ į̦̊ į̦̋ į̦̌ į̧̀ į̧́ į̧̂ į̧̃

Your font fully covers the following languages that require the soft-dotted feature: Dutch (Latn, 31,709,104 speakers), Lithuanian (Latn, 2,357,094 speakers).

Your font does not cover the following languages that require the soft-dotted feature: Avokaya (Latn, 100,000 speakers), Fur (Latn, 1,230,163 speakers), Mundani (Latn, 34,000 speakers), Bete-Bendi (Latn, 100,000 speakers), Dan (Latn, 1,099,244 speakers), Ijo, Southeast (Latn, 2,471,000 speakers), Kom (Latn, 360,685 speakers), South Central Banda (Latn, 244,000 speakers), Mfumte (Latn, 79,000 speakers), Igbo (Latn, 27,823,640 speakers), Koonzime (Latn, 40,000 speakers), Gulay (Latn, 250,478 speakers), Lugbara (Latn, 2,200,000 speakers), Dii (Latn, 71,000 speakers), Ekpeye (Latn, 226,000 speakers), Southern Kisi (Latn, 360,000 speakers), Zapotec (Latn, 490,000 speakers), Mango (Latn, 77,000 speakers), Bafut (Latn, 158,146 speakers), Ukrainian (Cyrl, 29,273,587 speakers), Cicipu (Latn, 44,000 speakers), Vute (Latn, 21,000 speakers), Aghem (Latn, 38,843 speakers), Nateni (Latn, 100,000 speakers), Sar (Latn, 500,000 speakers), Ebira (Latn, 2,200,000 speakers), Ma’di (Latn, 584,000 speakers), Yala (Latn, 200,000 speakers), Makaa (Latn, 221,000 speakers), Ngbaka (Latn, 1,020,000 speakers), Ejagham (Latn, 120,000 speakers), Nzakara (Latn, 50,000 speakers), Basaa (Latn, 332,940 speakers), Belarusian (Cyrl, 10,064,517 speakers), Navajo (Latn, 166,319 speakers), Kpelle, Guinea (Latn, 622,000 speakers).

[code: soft-dotted]
⚠️ WARN Check for codepoints not covered by METADATA subsets.
* ⚠️ **WARN**

The following codepoints supported by the font are not covered by any subsets defined in the font's metadata file, and will never be served. You can solve this by either manually adding additional subset declarations to METADATA.pb, or by editing the glyphset definitions.

  • U+02C7 CARON: try adding one of: tifinagh, canadian-aboriginal, yi
  • U+02C9 MODIFIER LETTER MACRON: not included in any glyphset definition
  • U+02D8 BREVE: try adding one of: canadian-aboriginal, yi
  • U+02D9 DOT ABOVE: try adding one of: canadian-aboriginal, yi
  • U+02DB OGONEK: try adding one of: canadian-aboriginal, yi
  • U+02DD DOUBLE ACUTE ACCENT: not included in any glyphset definition
  • U+0306 COMBINING BREVE: try adding one of: tifinagh, old-permic
  • U+030A COMBINING RING ABOVE: try adding syriac
  • U+030B COMBINING DOUBLE ACUTE ACCENT: try adding one of: cherokee, osage
  • U+030C COMBINING CARON: try adding one of: tai-le, cherokee 6 more.

Use -F or --full-lists to disable shortening of long lists.

Or you can add the above codepoints to one of the subsets supported by the font: arabic, latin, latin-ext, math, menu, symbols

[code: unreachable-subsetting]
⚠️ WARN Is there kerning info for non-ligated sequences?
* ⚠️ **WARN**

GPOS table lacks kerning info for the following non-ligated sequences:

- uni0627 + uni0644.init

- uni0644.init + uni0644.medi

- uni0644.medi + uni06510670

- uni06510670 + uni0647.fina

- uni06510670 + uni06C1.fina
[code: lacks-kern-info]
⚠️ WARN Ensure variable fonts include an avar table.
* ⚠️ **WARN**

This variable font does not have an avar table.

[code: missing-avar]
⚠️ WARN Ensure fonts have ScriptLangTags declared on the 'meta' table.
* ⚠️ **WARN**

This font file does not have a 'meta' table.

[code: lacks-meta-table]
ℹ️ INFO List all superfamily filepaths
* ℹ️ **INFO**

ofl/notonaskharabic

[code: family-path]
ℹ️ INFO Font contains all required tables?
* ℹ️ **INFO**

This font contains the following optional tables:

- loca

- prep

- GPOS

- GSUB

- gasp
[code: optional-tables]
ℹ️ INFO EPAR table present in font?
* ℹ️ **INFO**

EPAR table not present in font. To learn more see https://github.com/fonttools/fontbakery/issues/818

[code: lacks-EPAR]
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering?
* ℹ️ **INFO**

These are the ppm ranges declared on the gasp table:

PPM <= 65535: flag = 0x0F - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType®

[code: ranges]
ℹ️ INFO Show hinting filesize impact.
* ℹ️ **INFO**

Hinting filesize impact:

ofl/notonaskharabic/NotoNaskhArabic[wght].ttf
Dehinted Size 301.7kb
Hinted Size 301.7kb
Increase 24 bytes
Change 0.0 %
[code: size-impact]
ℹ️ INFO Font has old ttfautohint applied?
* ℹ️ **INFO**

Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 2.019']

[code: version-not-detected]
[1] Family checks
ℹ️ INFO Check axis ordering on the STAT table.
* ℹ️ **INFO**

None of the fonts lack a STAT table.

And these are the most common STAT axis orderings:
('wght', 1)
[code: summary]

Summary

💥 ERROR ☠ FATAL 🔥 FAIL ⚠️ WARN ⏩ SKIP ℹ️ INFO ✅ PASS 🔎 DEBUG
0 0 4 10 48 8 181 0
0% 0% 2% 4% 19% 3% 72% 0%

Note: The following loglevels were omitted in this report:

simoncozens commented 1 month ago

The only change here is to de-encode the U+2011 glyph, needed by Android.

vv-monsalve commented 1 month ago

The description file needs to be reinstated.

github-actions[bot] commented 1 month ago

FontBakery report

fontbakery version: 0.12.6

Experimental checks

These won't break the CI job for now, but will become effective after some time if nobody raises any concern.

[1] NotoNaskhArabic[wght].ttf
ℹ️ INFO METADATA.pb: Validate family.minisite_url field.
* ℹ️ **INFO**

Please consider adding a family.minisite_url entry.

[code: lacks-minisite-url]

All other checks

[19] NotoNaskhArabic[wght].ttf
🔥 FAIL Check that glyph for U+0675 ARABIC LETTER HIGH HAMZA is not a mark.
* 🔥 **FAIL**

The arabic letter high hamza (U+0675) should have roughly the same size the arabic letter hamza (U+0621), but a different glyph outline area was detected.

[code: glyph-area]
🔥 FAIL Ensure dotted circle glyph is present and can attach marks.
* 🔥 **FAIL**

The following glyphs could not be attached to the dotted circle glyph:

- acutecomb

- gravecomb

- tildecomb

- uni0302

- uni0304

- uni0306

- uni0307

- uni0308

- uni030A

- uni030B

- 10 more.

Use -F or --full-lists to disable shortening of long lists.

[code: unattached-dotted-circle-marks]
🔥 FAIL Shapes languages in all GF glyphsets.
* 🔥 **FAIL**

GF_Arabic_Core glyphset:

Language FAIL messages
ar_Arab (Arabic) Shaper didn't attach uni0655 to None
^ Shaper didn't attach uni0655 to space
[code: failed-language-shaping] * ⚠️ **WARN**

GF_Arabic_Plus glyphset:

Language WARN messages
ms_Arab (Malay (Arabic)) No exemplar glyphs were defined for language Malay (Arabic)
[code: warning-language-shaping]
⚠️ WARN Detect any interpolation issues in the font.
* ⚠️ **WARN**

Interpolation issues were found in the font:

- Contour 0 point 72 in glyph 'uni06AA' has a kink between location wght=400 and location wght=700

- Contour 0 point 26 in glyph 'uni0665.lf' has a kink between location wght=400 and location wght=700
[code: interpolation-issues]
⚠️ WARN Check math signs have the same width.
* ⚠️ **WARN**

The most common width is 559 among a set of 6 math glyphs. The following math glyphs have a different width, though:

Width = 310: minus

[code: width-outliers]
⚠️ WARN Check font contains no unreachable glyphs
* ⚠️ **WARN**

The following glyphs could not be reached by codepoint or substitution rules:

- alayh.1

- alayh.2

- fatha.1

- la.1

- radiya.1

- uni0640.wide

- uni06F7.mark
[code: unreachable-glyphs]
⚠️ WARN Glyph names are all valid?
* ⚠️ **WARN**

The following glyph names may be too long for some legacy systems which may expect a maximum 31-characters length limit: twodotshorizontalabove_tahabovear, twodotshorizontalabovear.diagonal, twodotshorizontalbelow_tahabovear and twodotshorizontalcenter_tahabovear

[code: legacy-long-names]
⚠️ WARN Check the direction of the outermost contour in each glyph
* ⚠️ **WARN**

The following glyphs have a counter-clockwise outer contour:

* uniFD46 (U+FD46) has a counter-clockwise outer contour

* uniFD46 (U+FD46) has a counter-clockwise outer contour

* uniFD46 (U+FD46) has a counter-clockwise outer contour
[code: ccw-outer-contour]
⚠️ WARN Ensure soft_dotted characters lose their dot when combined with marks that replace the dot.
* ⚠️ **WARN**

The dot of soft dotted characters used in orthographies must disappear in the following strings: į̀ į́ į̂ į̃ į̄ į̌

The dot of soft dotted characters should disappear in other cases, for example: į̆ į̇ į̈ į̊ į̋ į̦̀ į̦́ į̦̂ į̦̃ į̦̄ į̦̆ į̦̇ į̦̈ į̦̊ į̦̋ į̦̌ į̧̀ į̧́ į̧̂ į̧̃

Your font fully covers the following languages that require the soft-dotted feature: Lithuanian (Latn, 2,357,094 speakers), Dutch (Latn, 31,709,104 speakers).

Your font does not cover the following languages that require the soft-dotted feature: Koonzime (Latn, 40,000 speakers), Nzakara (Latn, 50,000 speakers), Lugbara (Latn, 2,200,000 speakers), Nateni (Latn, 100,000 speakers), Mundani (Latn, 34,000 speakers), Ekpeye (Latn, 226,000 speakers), Bete-Bendi (Latn, 100,000 speakers), Igbo (Latn, 27,823,640 speakers), South Central Banda (Latn, 244,000 speakers), Vute (Latn, 21,000 speakers), Bafut (Latn, 158,146 speakers), Kom (Latn, 360,685 speakers), Ejagham (Latn, 120,000 speakers), Ma’di (Latn, 584,000 speakers), Mango (Latn, 77,000 speakers), Basaa (Latn, 332,940 speakers), Dii (Latn, 71,000 speakers), Belarusian (Cyrl, 10,064,517 speakers), Sar (Latn, 500,000 speakers), Fur (Latn, 1,230,163 speakers), Aghem (Latn, 38,843 speakers), Ijo, Southeast (Latn, 2,471,000 speakers), Makaa (Latn, 221,000 speakers), Ebira (Latn, 2,200,000 speakers), Cicipu (Latn, 44,000 speakers), Navajo (Latn, 166,319 speakers), Ukrainian (Cyrl, 29,273,587 speakers), Avokaya (Latn, 100,000 speakers), Southern Kisi (Latn, 360,000 speakers), Kpelle, Guinea (Latn, 622,000 speakers), Zapotec (Latn, 490,000 speakers), Dan (Latn, 1,099,244 speakers), Mfumte (Latn, 79,000 speakers), Yala (Latn, 200,000 speakers), Gulay (Latn, 250,478 speakers), Ngbaka (Latn, 1,020,000 speakers).

[code: soft-dotted]
⚠️ WARN Check for codepoints not covered by METADATA subsets.
* ⚠️ **WARN**

The following codepoints supported by the font are not covered by any subsets defined in the font's metadata file, and will never be served. You can solve this by either manually adding additional subset declarations to METADATA.pb, or by editing the glyphset definitions.

  • U+02C7 CARON: try adding one of: canadian-aboriginal, tifinagh, yi
  • U+02C9 MODIFIER LETTER MACRON: not included in any glyphset definition
  • U+02D8 BREVE: try adding one of: canadian-aboriginal, yi
  • U+02D9 DOT ABOVE: try adding one of: canadian-aboriginal, yi
  • U+02DB OGONEK: try adding one of: canadian-aboriginal, yi
  • U+02DD DOUBLE ACUTE ACCENT: not included in any glyphset definition
  • U+0306 COMBINING BREVE: try adding one of: old-permic, tifinagh
  • U+030A COMBINING RING ABOVE: try adding syriac
  • U+030B COMBINING DOUBLE ACUTE ACCENT: try adding one of: cherokee, osage
  • U+030C COMBINING CARON: try adding one of: cherokee, tai-le 6 more.

Use -F or --full-lists to disable shortening of long lists.

Or you can add the above codepoints to one of the subsets supported by the font: arabic, latin, latin-ext, math, menu, symbols

[code: unreachable-subsetting]
⚠️ WARN Is there kerning info for non-ligated sequences?
* ⚠️ **WARN**

GPOS table lacks kerning info for the following non-ligated sequences:

- uni0627 + uni0644.init

- uni0644.init + uni0644.medi

- uni0644.medi + uni06510670

- uni06510670 + uni0647.fina

- uni06510670 + uni06C1.fina
[code: lacks-kern-info]
⚠️ WARN Ensure variable fonts include an avar table.
* ⚠️ **WARN**

This variable font does not have an avar table.

[code: missing-avar]
⚠️ WARN Ensure fonts have ScriptLangTags declared on the 'meta' table.
* ⚠️ **WARN**

This font file does not have a 'meta' table.

[code: lacks-meta-table]
ℹ️ INFO List all superfamily filepaths
* ℹ️ **INFO**

ofl/notonaskharabic

[code: family-path]
ℹ️ INFO Font contains all required tables?
* ℹ️ **INFO**

This font contains the following optional tables:

- loca

- prep

- GPOS

- GSUB

- gasp
[code: optional-tables]
ℹ️ INFO EPAR table present in font?
* ℹ️ **INFO**

EPAR table not present in font. To learn more see https://github.com/fonttools/fontbakery/issues/818

[code: lacks-EPAR]
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering?
* ℹ️ **INFO**

These are the ppm ranges declared on the gasp table:

PPM <= 65535: flag = 0x0F - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType®

[code: ranges]
ℹ️ INFO Show hinting filesize impact.
* ℹ️ **INFO**

Hinting filesize impact:

ofl/notonaskharabic/NotoNaskhArabic[wght].ttf
Dehinted Size 301.7kb
Hinted Size 301.7kb
Increase 24 bytes
Change 0.0 %
[code: size-impact]
ℹ️ INFO Font has old ttfautohint applied?
* ℹ️ **INFO**

Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 2.019']

[code: version-not-detected]
[1] Family checks
ℹ️ INFO Check axis ordering on the STAT table.
* ℹ️ **INFO**

None of the fonts lack a STAT table.

And these are the most common STAT axis orderings:
('wght', 1)
[code: summary]

Summary

💥 ERROR ☠ FATAL 🔥 FAIL ⚠️ WARN ⏩ SKIP ℹ️ INFO ✅ PASS 🔎 DEBUG
0 0 3 10 41 8 189 0
0% 0% 1% 4% 16% 3% 75% 0%

Note: The following loglevels were omitted in this report: