google / fonts

Font files available from Google Fonts, and a public issue tracker for all things Google Fonts
https://fonts.google.com
17.84k stars 2.6k forks source link

Bungee Shade: Version 2.000 added #7798

Closed vv-monsalve closed 1 month ago

vv-monsalve commented 1 month ago

Taken from the upstream repo https://github.com/djrrb/Bungee at commit https://github.com/djrrb/Bungee/commit/eb03cf69adab5094f6b84e95357789cdf3bfeb99.

PR Checklist:

github-actions[bot] commented 1 month ago

FontBakery report

fontbakery version: 0.12.6

Experimental checks

These won't break the CI job for now, but will become effective after some time if nobody raises any concern.

[1] BungeeShade-Regular.ttf
⚠️ WARN Validate location, size and resolution of article images.
* ⚠️ **WARN**

Family metadata at ofl/bungeeshade does not have an article.

[code: lacks-article]

All other checks

[21] BungeeShade-Regular.ttf
🔥 FAIL Shapes languages in all GF glyphsets.
* 🔥 **FAIL**

GF_Latin_Core glyphset:

Language FAIL messages
nl_Latn (Dutch) Shaper didn't attach acutecmb to j
^ Shaper didn't attach acutecmb to J
[code: failed-language-shaping]
🔥 FAIL Check license file has good copyright string.
* 🔥 **FAIL**

First line in license file is:

"copyright 2008 the bungee project authors (david@djr.com)"

which does not match the expected format, similar to:

"Copyright 2022 The Familyname Project Authors (git url)"

[code: bad-format]
🔥 FAIL Check if the vertical metrics of a family are similar to the same family hosted on Google Fonts.
* 🔥 **FAIL**

Bungee Shade Regular: OS/2 sTypoAscender is 1020 when it should be 1634

[code: bad-typo-ascender] * 🔥 **FAIL**

Bungee Shade Regular: OS/2 sTypoDescender is -300 when it should be -914

[code: bad-typo-descender] * 🔥 **FAIL**

Bungee Shade Regular: hhea Ascender is 1020 when it should be 1634

[code: bad-hhea-ascender] * 🔥 **FAIL**

Bungee Shade Regular: hhea Descender is -300 when it should be -914

[code: bad-hhea-descender]
⚠️ WARN Check accent of Lcaron, dcaron, lcaron, tcaron
* ⚠️ **WARN**

Lcaron is decomposed and therefore could not be checked. Please check manually.

[code: decomposed-outline] * ⚠️ **WARN**

dcaron is composed of a single component and therefore could not be checked. Please check manually.

[code: single-component] * ⚠️ **WARN**

lcaron is composed of a single component and therefore could not be checked. Please check manually.

[code: single-component] * ⚠️ **WARN**

tcaron is composed of a single component and therefore could not be checked. Please check manually.

[code: single-component]
⚠️ WARN Check if each glyph has the recommended amount of contours.
* ⚠️ **WARN**

This check inspects the glyph outlines and detects the total number of contours in each of them. The expected values are infered from the typical ammounts of contours observed in a large collection of reference font families. The divergences listed below may simply indicate a significantly different design on some of your glyphs. On the other hand, some of these may flag actual bugs in the font such as glyphs mapped to an incorrect codepoint. Please consider reviewing the design and codepoint assignment of these to make sure they are correct.

The following glyphs do not have the recommended number of contours:

- Glyph name: exclam Contours detected: 5    Expected: 2

- Glyph name: quotedbl  Contours detected: 5    Expected: 2

- Glyph name: numbersign    Contours detected: 5    Expected: 2

- Glyph name: percent   Contours detected: 11   Expected: 4 or 5

- Glyph name: ampersand Contours detected: 4    Expected: 1, 2 or 3

- Glyph name: quotesingle   Contours detected: 3    Expected: 1

- Glyph name: parenleft Contours detected: 3    Expected: 1

- Glyph name: parenright    Contours detected: 3    Expected: 1

- Glyph name: asterisk  Contours detected: 3    Expected: 1 or 4

- Glyph name: plus  Contours detected: 3    Expected: 1

- 993 more.

Use -F or --full-lists to disable shortening of long lists.

[code: contour-count]
⚠️ WARN Check math signs have the same width.
* ⚠️ **WARN**

The most common width is 834 among a set of 9 math glyphs. The following math glyphs have a different width, though:

Width = 814: greater, greaterequal, less, lessequal

[code: width-outliers]
⚠️ WARN Check font contains no unreachable glyphs
* ⚠️ **WARN**

The following glyphs could not be reached by codepoint or substitution rules:

- Tcedilla

- acute.vert

- breveacute

- brevegrave

- brevehookabove

- brevetilde

- circumflexacute

- circumflexgrave

- circumflexhookabove

- circumflextilde

- 4 more.

Use -F or --full-lists to disable shortening of long lists.

[code: unreachable-glyphs]
⚠️ WARN Do outlines contain any jaggy segments?
* ⚠️ **WARN**

The following glyphs have jaggy segments:

* Abreve (U+0102): L<<452.0,905.0>--<542.0,980.0>>/L<<542.0,980.0>--<541.0,979.0>> = 5.19442890773487

* Abreve.salt (U+E108): L<<455.0,905.0>--<545.0,980.0>>/L<<545.0,980.0>--<544.0,979.0>> = 5.19442890773487

* Abreve.salt_v (U+E1F5): L<<537.0,865.0>--<627.0,940.0>>/L<<627.0,940.0>--<626.0,939.0>> = 5.19442890773487

* Abreve.v (U+E191): L<<538.0,865.0>--<628.0,940.0>>/L<<628.0,940.0>--<627.0,939.0>> = 5.19442890773487

* Abrevedotbelow (U+1EB6): L<<452.0,905.0>--<542.0,980.0>>/L<<542.0,980.0>--<541.0,979.0>> = 5.19442890773487

* Abrevegrave (U+1EB0): L<<452.0,905.0>--<542.0,980.0>>/L<<542.0,980.0>--<541.0,979.0>> = 5.19442890773487

* Abrevetilde (U+1EB4): L<<462.0,1192.0>--<462.0,1192.0>>/B<<462.0,1192.0>-<422.0,1198.0>-<399.5,1200.0>> = 8.530765609948139

* Abrevetilde (U+1EB4): L<<479.0,1190.0>--<462.0,1192.0>>/L<<462.0,1192.0>--<462.0,1192.0>> = 6.709836807756896

* Acircumflex (U+00C2): L<<145.0,806.0>--<276.0,915.0>>/L<<276.0,915.0>--<275.0,914.0>> = 5.2374760668124445

* Acircumflex.salt (U+E103): L<<148.0,806.0>--<279.0,915.0>>/L<<279.0,915.0>--<278.0,914.0>> = 5.2374760668124445

* 262 more.

Use -F or --full-lists to disable shortening of long lists.

[code: found-jaggy-segments]
⚠️ WARN Do outlines contain any semi-vertical or semi-horizontal lines?
* ⚠️ **WARN**

The following glyphs have semi-vertical/semi-horizontal lines:

* M.v (U+FF4D): L<<105.0,-73.0>--<109.0,575.0>>

* M.v (U+FF4D): L<<248.0,684.0>--<244.0,36.0>>

* M.v (U+FF4D): L<<342.0,90.0>--<344.0,599.0>>

* M.v (U+FF4D): L<<354.0,599.0>--<352.0,90.0>>

* M.v (U+FF4D): L<<770.0,90.0>--<768.0,599.0>>

* M.v (U+FF4D): L<<778.0,599.0>--<780.0,90.0>>

* M.v (U+FF4D): L<<888.0,36.0>--<884.0,684.0>>

* M.v (U+FF4D): L<<894.0,684.0>--<898.0,36.0>>

* asciicircum (U+005E): L<<185.0,172.0>--<317.0,171.0>>

* asciicircum (U+005E): L<<188.0,52.0>--<56.0,53.0>>

* 4 more.

Use -F or --full-lists to disable shortening of long lists.

[code: found-semi-vertical]
⚠️ WARN Check for codepoints not covered by METADATA subsets.
* ⚠️ **WARN**

The following codepoints supported by the font are not covered by any subsets defined in the font's metadata file, and will never be served. You can solve this by either manually adding additional subset declarations to METADATA.pb, or by editing the glyphset definitions.

  • U+02BE MODIFIER LETTER RIGHT HALF RING: not included in any glyphset definition
  • U+02BF MODIFIER LETTER LEFT HALF RING: not included in any glyphset definition
  • U+02C7 CARON: try adding one of: tifinagh, yi, canadian-aboriginal
  • U+02C8 MODIFIER LETTER VERTICAL LINE: not included in any glyphset definition
  • U+02C9 MODIFIER LETTER MACRON: not included in any glyphset definition
  • U+02CA MODIFIER LETTER ACUTE ACCENT: not included in any glyphset definition
  • U+02CB MODIFIER LETTER GRAVE ACCENT: not included in any glyphset definition
  • U+02CC MODIFIER LETTER LOW VERTICAL LINE: not included in any glyphset definition
  • U+02D8 BREVE: try adding one of: yi, canadian-aboriginal
  • U+02D9 DOT ABOVE: try adding one of: yi, canadian-aboriginal 535 more.

Use -F or --full-lists to disable shortening of long lists.

Or you can add the above codepoints to one of the subsets supported by the font: latin, latin-ext, menu, vietnamese

[code: unreachable-subsetting]
⚠️ WARN Is there kerning info for non-ligated sequences?
* ⚠️ **WARN**

GPOS table lacks kerning info for the following non-ligated sequences:

- I.salt_v + I.salt_v
[code: lacks-kern-info]
⚠️ WARN Are there caret positions declared for every ligature?
* ⚠️ **WARN**

GDEF table is missing, but it is mandatory to declare it on fonts that provide ligature glyphs because the caret (text cursor) positioning for each ligature must be provided in this table.

[code: GDEF-missing]
⚠️ WARN Ensure fonts have ScriptLangTags declared on the 'meta' table.
* ⚠️ **WARN**

This font file does not have a 'meta' table.

[code: lacks-meta-table]
ℹ️ INFO List all superfamily filepaths
* ℹ️ **INFO**

ofl/bungeeshade

[code: family-path]
ℹ️ INFO Font contains all required tables?
* ℹ️ **INFO**

This font contains the following optional tables:

- loca

- prep

- GPOS

- GSUB

- gasp

- vhea

- vmtx
[code: optional-tables]
ℹ️ INFO Does DESCRIPTION file contain a upstream Git repo URL?
* ℹ️ **INFO**

Found a git repo URL: https://github.com/djrrb/Bungee

[code: url-found]
ℹ️ INFO Check for presence of an ARTICLE.en_us.html file
* ℹ️ **INFO**

This font doesn't have an ARTICLE.en_us.html file.

[code: missing-article]
ℹ️ INFO EPAR table present in font?
* ℹ️ **INFO**

EPAR table not present in font. To learn more see https://github.com/fonttools/fontbakery/issues/818

[code: lacks-EPAR]
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering?
* ℹ️ **INFO**

These are the ppm ranges declared on the gasp table:

PPM <= 65535: flag = 0x0F - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType®

[code: ranges]
ℹ️ INFO Show hinting filesize impact.
* ℹ️ **INFO**

Hinting filesize impact:

ofl/bungeeshade/BungeeShade-Regular.ttf
Dehinted Size 297.8kb
Hinted Size 297.8kb
Increase 24 bytes
Change 0.0 %
[code: size-impact]
ℹ️ INFO Font has old ttfautohint applied?
* ℹ️ **INFO**

Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 2.000']

[code: version-not-detected]
[1] Family checks
ℹ️ INFO Check axis ordering on the STAT table.
* ℹ️ **INFO**

All of the fonts lack a STAT table.

[code: summary]

Summary

💥 ERROR ☠ FATAL 🔥 FAIL ⚠️ WARN ⏩ SKIP ℹ️ INFO ✅ PASS 🔎 DEBUG
0 0 3 11 66 9 162 0
0% 0% 1% 4% 26% 4% 65% 0%

Note: The following loglevels were omitted in this report:

github-actions[bot] commented 1 month ago

FontBakery report

fontbakery version: 0.12.6

Experimental checks

These won't break the CI job for now, but will become effective after some time if nobody raises any concern.

[1] BungeeShade-Regular.ttf
⚠️ WARN Validate location, size and resolution of article images.
* ⚠️ **WARN**

Family metadata at ofl/bungeeshade does not have an article.

[code: lacks-article]

All other checks

[20] BungeeShade-Regular.ttf
🔥 FAIL Shapes languages in all GF glyphsets.
* 🔥 **FAIL**

GF_Latin_Core glyphset:

Language FAIL messages
nl_Latn (Dutch) Shaper didn't attach acutecmb to J
^ Shaper didn't attach acutecmb to j
[code: failed-language-shaping]
🔥 FAIL Check if the vertical metrics of a family are similar to the same family hosted on Google Fonts.
* 🔥 **FAIL**

Bungee Shade Regular: OS/2 sTypoAscender is 1020 when it should be 1634

[code: bad-typo-ascender] * 🔥 **FAIL**

Bungee Shade Regular: OS/2 sTypoDescender is -300 when it should be -914

[code: bad-typo-descender] * 🔥 **FAIL**

Bungee Shade Regular: hhea Ascender is 1020 when it should be 1634

[code: bad-hhea-ascender] * 🔥 **FAIL**

Bungee Shade Regular: hhea Descender is -300 when it should be -914

[code: bad-hhea-descender]
⚠️ WARN Check accent of Lcaron, dcaron, lcaron, tcaron
* ⚠️ **WARN**

Lcaron is decomposed and therefore could not be checked. Please check manually.

[code: decomposed-outline] * ⚠️ **WARN**

dcaron is composed of a single component and therefore could not be checked. Please check manually.

[code: single-component] * ⚠️ **WARN**

lcaron is composed of a single component and therefore could not be checked. Please check manually.

[code: single-component] * ⚠️ **WARN**

tcaron is composed of a single component and therefore could not be checked. Please check manually.

[code: single-component]
⚠️ WARN Check if each glyph has the recommended amount of contours.
* ⚠️ **WARN**

This check inspects the glyph outlines and detects the total number of contours in each of them. The expected values are infered from the typical ammounts of contours observed in a large collection of reference font families. The divergences listed below may simply indicate a significantly different design on some of your glyphs. On the other hand, some of these may flag actual bugs in the font such as glyphs mapped to an incorrect codepoint. Please consider reviewing the design and codepoint assignment of these to make sure they are correct.

The following glyphs do not have the recommended number of contours:

- Glyph name: exclam Contours detected: 5    Expected: 2

- Glyph name: quotedbl  Contours detected: 5    Expected: 2

- Glyph name: numbersign    Contours detected: 5    Expected: 2

- Glyph name: percent   Contours detected: 11   Expected: 4 or 5

- Glyph name: ampersand Contours detected: 4    Expected: 1, 2 or 3

- Glyph name: quotesingle   Contours detected: 3    Expected: 1

- Glyph name: parenleft Contours detected: 3    Expected: 1

- Glyph name: parenright    Contours detected: 3    Expected: 1

- Glyph name: asterisk  Contours detected: 3    Expected: 1 or 4

- Glyph name: plus  Contours detected: 3    Expected: 1

- 993 more.

Use -F or --full-lists to disable shortening of long lists.

[code: contour-count]
⚠️ WARN Check math signs have the same width.
* ⚠️ **WARN**

The most common width is 834 among a set of 9 math glyphs. The following math glyphs have a different width, though:

Width = 814: greaterequal, greater, lessequal, less

[code: width-outliers]
⚠️ WARN Check font contains no unreachable glyphs
* ⚠️ **WARN**

The following glyphs could not be reached by codepoint or substitution rules:

- Tcedilla

- acute.vert

- breveacute

- brevegrave

- brevehookabove

- brevetilde

- circumflexacute

- circumflexgrave

- circumflexhookabove

- circumflextilde

- 4 more.

Use -F or --full-lists to disable shortening of long lists.

[code: unreachable-glyphs]
⚠️ WARN Do outlines contain any jaggy segments?
* ⚠️ **WARN**

The following glyphs have jaggy segments:

* Abreve (U+0102): L<<452.0,905.0>--<542.0,980.0>>/L<<542.0,980.0>--<541.0,979.0>> = 5.19442890773487

* Abreve.salt (U+E108): L<<455.0,905.0>--<545.0,980.0>>/L<<545.0,980.0>--<544.0,979.0>> = 5.19442890773487

* Abreve.salt_v (U+E1F5): L<<537.0,865.0>--<627.0,940.0>>/L<<627.0,940.0>--<626.0,939.0>> = 5.19442890773487

* Abreve.v (U+E191): L<<538.0,865.0>--<628.0,940.0>>/L<<628.0,940.0>--<627.0,939.0>> = 5.19442890773487

* Abrevedotbelow (U+1EB6): L<<452.0,905.0>--<542.0,980.0>>/L<<542.0,980.0>--<541.0,979.0>> = 5.19442890773487

* Abrevegrave (U+1EB0): L<<452.0,905.0>--<542.0,980.0>>/L<<542.0,980.0>--<541.0,979.0>> = 5.19442890773487

* Abrevetilde (U+1EB4): L<<462.0,1192.0>--<462.0,1192.0>>/B<<462.0,1192.0>-<422.0,1198.0>-<399.5,1200.0>> = 8.530765609948139

* Abrevetilde (U+1EB4): L<<479.0,1190.0>--<462.0,1192.0>>/L<<462.0,1192.0>--<462.0,1192.0>> = 6.709836807756896

* Acircumflex (U+00C2): L<<145.0,806.0>--<276.0,915.0>>/L<<276.0,915.0>--<275.0,914.0>> = 5.2374760668124445

* Acircumflex.salt (U+E103): L<<148.0,806.0>--<279.0,915.0>>/L<<279.0,915.0>--<278.0,914.0>> = 5.2374760668124445

* 262 more.

Use -F or --full-lists to disable shortening of long lists.

[code: found-jaggy-segments]
⚠️ WARN Do outlines contain any semi-vertical or semi-horizontal lines?
* ⚠️ **WARN**

The following glyphs have semi-vertical/semi-horizontal lines:

* M.v (U+FF4D): L<<105.0,-73.0>--<109.0,575.0>>

* M.v (U+FF4D): L<<248.0,684.0>--<244.0,36.0>>

* M.v (U+FF4D): L<<342.0,90.0>--<344.0,599.0>>

* M.v (U+FF4D): L<<354.0,599.0>--<352.0,90.0>>

* M.v (U+FF4D): L<<770.0,90.0>--<768.0,599.0>>

* M.v (U+FF4D): L<<778.0,599.0>--<780.0,90.0>>

* M.v (U+FF4D): L<<888.0,36.0>--<884.0,684.0>>

* M.v (U+FF4D): L<<894.0,684.0>--<898.0,36.0>>

* asciicircum (U+005E): L<<185.0,172.0>--<317.0,171.0>>

* asciicircum (U+005E): L<<188.0,52.0>--<56.0,53.0>>

* 4 more.

Use -F or --full-lists to disable shortening of long lists.

[code: found-semi-vertical]
⚠️ WARN Check for codepoints not covered by METADATA subsets.
* ⚠️ **WARN**

The following codepoints supported by the font are not covered by any subsets defined in the font's metadata file, and will never be served. You can solve this by either manually adding additional subset declarations to METADATA.pb, or by editing the glyphset definitions.

  • U+02BE MODIFIER LETTER RIGHT HALF RING: not included in any glyphset definition
  • U+02BF MODIFIER LETTER LEFT HALF RING: not included in any glyphset definition
  • U+02C7 CARON: try adding one of: tifinagh, yi, canadian-aboriginal
  • U+02C8 MODIFIER LETTER VERTICAL LINE: not included in any glyphset definition
  • U+02C9 MODIFIER LETTER MACRON: not included in any glyphset definition
  • U+02CA MODIFIER LETTER ACUTE ACCENT: not included in any glyphset definition
  • U+02CB MODIFIER LETTER GRAVE ACCENT: not included in any glyphset definition
  • U+02CC MODIFIER LETTER LOW VERTICAL LINE: not included in any glyphset definition
  • U+02D8 BREVE: try adding one of: yi, canadian-aboriginal
  • U+02D9 DOT ABOVE: try adding one of: yi, canadian-aboriginal 535 more.

Use -F or --full-lists to disable shortening of long lists.

Or you can add the above codepoints to one of the subsets supported by the font: latin, latin-ext, menu, vietnamese

[code: unreachable-subsetting]
⚠️ WARN Is there kerning info for non-ligated sequences?
* ⚠️ **WARN**

GPOS table lacks kerning info for the following non-ligated sequences:

- I.salt_v + I.salt_v
[code: lacks-kern-info]
⚠️ WARN Are there caret positions declared for every ligature?
* ⚠️ **WARN**

GDEF table is missing, but it is mandatory to declare it on fonts that provide ligature glyphs because the caret (text cursor) positioning for each ligature must be provided in this table.

[code: GDEF-missing]
⚠️ WARN Ensure fonts have ScriptLangTags declared on the 'meta' table.
* ⚠️ **WARN**

This font file does not have a 'meta' table.

[code: lacks-meta-table]
ℹ️ INFO List all superfamily filepaths
* ℹ️ **INFO**

ofl/bungeeshade

[code: family-path]
ℹ️ INFO Font contains all required tables?
* ℹ️ **INFO**

This font contains the following optional tables:

- loca

- prep

- GPOS

- GSUB

- gasp

- vhea

- vmtx
[code: optional-tables]
ℹ️ INFO Does DESCRIPTION file contain a upstream Git repo URL?
* ℹ️ **INFO**

Found a git repo URL: https://github.com/djrrb/Bungee

[code: url-found]
ℹ️ INFO Check for presence of an ARTICLE.en_us.html file
* ℹ️ **INFO**

This font doesn't have an ARTICLE.en_us.html file.

[code: missing-article]
ℹ️ INFO EPAR table present in font?
* ℹ️ **INFO**

EPAR table not present in font. To learn more see https://github.com/fonttools/fontbakery/issues/818

[code: lacks-EPAR]
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering?
* ℹ️ **INFO**

These are the ppm ranges declared on the gasp table:

PPM <= 65535: flag = 0x0F - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType®

[code: ranges]
ℹ️ INFO Show hinting filesize impact.
* ℹ️ **INFO**

Hinting filesize impact:

ofl/bungeeshade/BungeeShade-Regular.ttf
Dehinted Size 297.8kb
Hinted Size 297.8kb
Increase 24 bytes
Change 0.0 %
[code: size-impact]
ℹ️ INFO Font has old ttfautohint applied?
* ℹ️ **INFO**

Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 2.000']

[code: version-not-detected]
[1] Family checks
ℹ️ INFO Check axis ordering on the STAT table.
* ℹ️ **INFO**

All of the fonts lack a STAT table.

[code: summary]

Summary

💥 ERROR ☠ FATAL 🔥 FAIL ⚠️ WARN ⏩ SKIP ℹ️ INFO ✅ PASS 🔎 DEBUG
0 0 2 11 66 9 163 0
0% 0% 1% 4% 26% 4% 65% 0%

Note: The following loglevels were omitted in this report:

vv-monsalve commented 1 month ago

@emmamarichal

Same comments as in Bungee Regular.