emmamarichal
commented
1 week ago Hi @simoncozens! I noticed some cases with a mix of lowercases and smallcaps. what do you think?
Closed simoncozens closed 1 week ago
emmamarichal
commented
1 week ago Hi @simoncozens! I noticed some cases with a mix of lowercases and smallcaps. what do you think?
github-actions[bot]
commented
1 week ago fontbakery version: 0.12.7
These won't break the CI job for now, but will become effective after some time if nobody raises any concern.
This check inspects the glyph outlines and detects the total number of contours in each of them. The expected values are infered from the typical ammounts of contours observed in a large collection of reference font families. The divergences listed below may simply indicate a significantly different design on some of your glyphs. On the other hand, some of these may flag actual bugs in the font such as glyphs mapped to an incorrect codepoint. Please consider reviewing the design and codepoint assignment of these to make sure they are correct.
The following glyphs do not have the recommended number of contours:
- Glyph name: zero Contours detected: 1 Expected: 2 or 3
- Glyph name: five Contours detected: 2 Expected: 1
- Glyph name: b Contours detected: 1 Expected: 2
- Glyph name: c Contours detected: 2 Expected: 1
- Glyph name: j Contours detected: 4 Expected: 2
- Glyph name: p Contours detected: 4 Expected: 2
- Glyph name: q Contours detected: 3 Expected: 2
- Glyph name: s Contours detected: 2 Expected: 1
- Glyph name: w Contours detected: 2 Expected: 1
- Glyph name: sterling Contours detected: 4 Expected: 1 or 2
- 133 more.
Use -F or --full-lists to disable shortening of long lists.
[code: contour-count]The most common width is 596 among a set of 2 math glyphs. The following math glyphs have a different width, though:
Width = 426: plus
Width = 410: less
Width = 432: greater
Width = 530: plusminus
Width = 388: multiply
Width = 484: divide
Width = 436: minus
Width = 400: approxequal
Width = 452: notequal
Width = 562: lessequal
Width = 516: greaterequal
[code: width-outliers]This font has a 'Soft Hyphen' character.
[code: softhyphen]The following glyphs could not be reached by codepoint or substitution rules:
- NULL
- Z.alt.stroke
- Z.stroke
- a.superior
- b.superior
- d.superior
- e.superior
- eight.lf
- f.bottom
- f_l.ss01
- 25 more.
Use -F or --full-lists to disable shortening of long lists.
[code: unreachable-glyphs]The following glyphs have jaggy segments:
* A.ss01: B<<287.0,143.0>-<288.0,144.0>-<288.0,145.0>>/B<<288.0,145.0>-<289.0,136.0>-<298.0,133.0>> = 6.340191745909908
* Aacute.ss01: B<<287.0,143.0>-<288.0,144.0>-<288.0,145.0>>/B<<288.0,145.0>-<289.0,136.0>-<298.0,133.0>> = 6.340191745909908
* Abreve.ss01: B<<287.0,143.0>-<288.0,144.0>-<288.0,145.0>>/B<<288.0,145.0>-<289.0,136.0>-<298.0,133.0>> = 6.340191745909908
* Acircumflex.ss01: B<<287.0,143.0>-<288.0,144.0>-<288.0,145.0>>/B<<288.0,145.0>-<289.0,136.0>-<298.0,133.0>> = 6.340191745909908
* Adieresis.ss01: B<<287.0,143.0>-<288.0,144.0>-<288.0,145.0>>/B<<288.0,145.0>-<289.0,136.0>-<298.0,133.0>> = 6.340191745909908
* Agrave.ss01: B<<287.0,143.0>-<288.0,144.0>-<288.0,145.0>>/B<<288.0,145.0>-<289.0,136.0>-<298.0,133.0>> = 6.340191745909908
* Amacron.ss01: B<<287.0,143.0>-<288.0,144.0>-<288.0,145.0>>/B<<288.0,145.0>-<289.0,136.0>-<298.0,133.0>> = 6.340191745909908
* Aogonek.ss01: B<<287.0,143.0>-<288.0,144.0>-<288.0,145.0>>/B<<288.0,145.0>-<289.0,136.0>-<298.0,133.0>> = 6.340191745909908
* Aring.ss01: B<<287.0,143.0>-<288.0,144.0>-<288.0,145.0>>/B<<288.0,145.0>-<289.0,136.0>-<298.0,133.0>> = 6.340191745909908
* Aringacute.ss01: B<<287.0,143.0>-<288.0,144.0>-<288.0,145.0>>/B<<288.0,145.0>-<289.0,136.0>-<298.0,133.0>> = 6.340191745909908
* 489 more.
Use -F or --full-lists to disable shortening of long lists.
[code: found-jaggy-segments]No dotted circle glyph present
[code: missing-dotted-circle]The following codepoints supported by the font are not covered by any subsets defined in the font's metadata file, and will never be served. You can solve this by either manually adding additional subset declarations to METADATA.pb, or by editing the glyphset definitions.
Use -F or --full-lists to disable shortening of long lists.
Or you can add the above codepoints to one of the subsets supported by the font: latin, latin-ext, menu, vietnamese
Font file is 1.0Mb; ideally it should be less than 1.0Mb
[code: large-font]GPOS table lacks kerning info for the following non-ligated sequences:
- f + f
- f + i
- f + l
This font lacks caret position values for ligature glyphs on its GDEF table.
[code: lacks-caret-pos]This font file does not have a 'meta' table.
[code: lacks-meta-table]The stylistic set ss01 lacks a description string on the 'name' table.
[code: missing-description] * ⚠️ **WARN**The stylistic set ss02 lacks a description string on the 'name' table.
[code: missing-description] * ⚠️ **WARN**The stylistic set ss03 lacks a description string on the 'name' table.
[code: missing-description] * ⚠️ **WARN**The stylistic set ss04 lacks a description string on the 'name' table.
[code: missing-description] * ⚠️ **WARN**The stylistic set ss05 lacks a description string on the 'name' table.
[code: missing-description] * ⚠️ **WARN**The stylistic set ss06 lacks a description string on the 'name' table.
[code: missing-description] * ⚠️ **WARN**The stylistic set ss07 lacks a description string on the 'name' table.
[code: missing-description]ofl/estonia
[code: family-path] * ℹ️ **INFO**ofl/estoniasc
[code: family-path]This font contains the following optional tables:
- cvt
- fpgm
- loca
- prep
- GPOS
- GSUB
- gasp
Found a git repo URL: https://github.com/googlefonts/estonia
[code: url-found]This font doesn't have an ARTICLE.en_us.html file.
[code: missing-article]EPAR table not present in font. To learn more see https://github.com/fonttools/fontbakery/issues/818
[code: lacks-EPAR]These are the ppm ranges declared on the gasp table:
PPM <= 65535: flag = 0x0F - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType®
[code: ranges]| 💥 ERROR | ☠ FATAL | 🔥 FAIL | ⚠️ WARN | ⏩ SKIP | ℹ️ INFO | ✅ PASS | 🔎 DEBUG |
|---|---|---|---|---|---|---|---|
| 0 | 0 | 0 | 13 | 61 | 9 | 165 | 0 |
| 0% | 0% | 0% | 5% | 25% | 4% | 67% | 0% |
Note: The following loglevels were omitted in this report:
simoncozens
commented
1 week ago Probably small caps not provided for those glyphs. I don't plan to fix it.
vv-monsalve
commented
1 week ago It's probably better not to add this SC font. This variant was not part of the original scope of the font, and AFAIK, there will not be more funding to develop it further, at least in a sort or mid-term.
I think we can close this PR here.
FontBakery report
fontbakery version: 0.12.7
Experimental checks
These won't break the CI job for now, but will become effective after some time if nobody raises any concern.
[2] EstoniaSC-Regular.ttf
⚠️ WARN Validate size, and resolution of article images, and ensure article page has minimum length and includes visual assets.
Family metadata at ofl/estoniasc does not have an article.
[code: lacks-article]ℹ️ INFO METADATA.pb: Validate family.minisite_url field.
Please consider adding a family.minisite_url entry.
[code: lacks-minisite-url]All other checks
[19] EstoniaSC-Regular.ttf
⚠️ WARN Check if each glyph has the recommended amount of contours.
This check inspects the glyph outlines and detects the total number of contours in each of them. The expected values are infered from the typical ammounts of contours observed in a large collection of reference font families. The divergences listed below may simply indicate a significantly different design on some of your glyphs. On the other hand, some of these may flag actual bugs in the font such as glyphs mapped to an incorrect codepoint. Please consider reviewing the design and codepoint assignment of these to make sure they are correct.
The following glyphs do not have the recommended number of contours:
Use -F or --full-lists to disable shortening of long lists.
[code: contour-count]⚠️ WARN Check math signs have the same width.
The most common width is 596 among a set of 2 math glyphs. The following math glyphs have a different width, though:
Width = 426: plus
Width = 410: less
Width = 432: greater
Width = 530: plusminus
Width = 388: multiply
Width = 484: divide
Width = 436: minus
Width = 400: approxequal
Width = 452: notequal
Width = 562: lessequal
Width = 516: greaterequal
[code: width-outliers]⚠️ WARN Does the font contain a soft hyphen?
This font has a 'Soft Hyphen' character.
[code: softhyphen]⚠️ WARN Check font contains no unreachable glyphs
The following glyphs could not be reached by codepoint or substitution rules:
Use -F or --full-lists to disable shortening of long lists.
[code: unreachable-glyphs]⚠️ WARN Do outlines contain any jaggy segments?
The following glyphs have jaggy segments:
Use -F or --full-lists to disable shortening of long lists.
[code: found-jaggy-segments]⚠️ WARN Ensure dotted circle glyph is present and can attach marks.
No dotted circle glyph present
[code: missing-dotted-circle]⚠️ WARN Check for codepoints not covered by METADATA subsets.
The following codepoints supported by the font are not covered by any subsets defined in the font's metadata file, and will never be served. You can solve this by either manually adding additional subset declarations to METADATA.pb, or by editing the glyphset definitions.
Use -F or --full-lists to disable shortening of long lists.
Or you can add the above codepoints to one of the subsets supported by the font:
[code: unreachable-subsetting]latin,latin-ext,menu,vietnamese⚠️ WARN Ensure files are not too large.
Font file is 1.0Mb; ideally it should be less than 1.0Mb
[code: large-font]⚠️ WARN Is there kerning info for non-ligated sequences?
GPOS table lacks kerning info for the following non-ligated sequences:
[code: lacks-kern-info]⚠️ WARN Are there caret positions declared for every ligature?
This font lacks caret position values for ligature glyphs on its GDEF table.
[code: lacks-caret-pos]⚠️ WARN Ensure fonts have ScriptLangTags declared on the 'meta' table.
This font file does not have a 'meta' table.
[code: lacks-meta-table]⚠️ WARN Ensure Stylistic Sets have description.
The stylistic set ss01 lacks a description string on the 'name' table.
[code: missing-description] * ⚠️ **WARN**The stylistic set ss02 lacks a description string on the 'name' table.
[code: missing-description] * ⚠️ **WARN**The stylistic set ss03 lacks a description string on the 'name' table.
[code: missing-description] * ⚠️ **WARN**The stylistic set ss04 lacks a description string on the 'name' table.
[code: missing-description] * ⚠️ **WARN**The stylistic set ss05 lacks a description string on the 'name' table.
[code: missing-description] * ⚠️ **WARN**The stylistic set ss06 lacks a description string on the 'name' table.
[code: missing-description] * ⚠️ **WARN**The stylistic set ss07 lacks a description string on the 'name' table.
[code: missing-description]ℹ️ INFO List all superfamily filepaths
ofl/estonia
[code: family-path] * ℹ️ **INFO**ofl/estoniasc
[code: family-path]ℹ️ INFO Font contains all required tables?
This font contains the following optional tables:
[code: optional-tables]ℹ️ INFO Does DESCRIPTION file contain a upstream Git repo URL?
Found a git repo URL: https://github.com/googlefonts/estonia
[code: url-found]ℹ️ INFO Check for presence of an ARTICLE.en_us.html file
This font doesn't have an ARTICLE.en_us.html file.
[code: missing-article]ℹ️ INFO EPAR table present in font?
EPAR table not present in font. To learn more see https://github.com/fonttools/fontbakery/issues/818
[code: lacks-EPAR]ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering?
These are the ppm ranges declared on the gasp table:
PPM <= 65535: flag = 0x0F - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType®
[code: ranges]ℹ️ INFO Show hinting filesize impact.
Hinting filesize impact:
[1] Family checks
ℹ️ INFO Check axis ordering on the STAT table.
All of the fonts lack a STAT table.
[code: summary]Summary
Note: The following loglevels were omitted in this report: