google / fonts

Font files available from Google Fonts, and a public issue tracker for all things Google Fonts
https://fonts.google.com
17.83k stars 2.6k forks source link

Maven Pro: Version 2.101 added #7841

Closed m4rc1e closed 3 weeks ago

m4rc1e commented 3 weeks ago

Taken from the upstream repo https://www.github.com/googlefonts/mavenproFont at commit https://www.github.com/googlefonts/mavenproFont/commit/1c21ee500b7b87a4871696519fc84107a1a001df.

PR Checklist:

github-actions[bot] commented 3 weeks ago

FontBakery report

fontbakery version: 0.12.7

Experimental checks

These won't break the CI job for now, but will become effective after some time if nobody raises any concern.

[2] MavenPro[wght].ttf
⚠️ WARN Validate size, and resolution of article images, and ensure article page has minimum length and includes visual assets.
* ⚠️ **WARN**

Family metadata at ofl/mavenpro does not have an article.

[code: lacks-article]
ℹ️ INFO METADATA.pb: Validate family.minisite_url field.
* ℹ️ **INFO**

Please consider adding a family.minisite_url entry.

[code: lacks-minisite-url]

All other checks

[32] MavenPro[wght].ttf
🔥 FAIL Check accent of Lcaron, dcaron, lcaron, tcaron
* 🔥 **FAIL**

dcaron uses component quoteright.

Overridden: This check was originally a WARN but was overridden by the ufo profile: For Google Fonts, one of the comma-lookalikes is a FAIL

[code: bad-mark] * 🔥 **FAIL**

tcaron uses component quoteright.

Overridden: This check was originally a WARN but was overridden by the ufo profile: For Google Fonts, one of the comma-lookalikes is a FAIL

[code: bad-mark] * ⚠️ **WARN**

lcaron is decomposed and therefore could not be checked. Please check manually.

[code: decomposed-outline]
🔥 FAIL Ensure the font supports case swapping for all its glyphs.
* 🔥 **FAIL**

The following glyphs lack their case-swapping counterparts:

Glyph present in the font Missing case-swapping counterpart
U+01F4: LATIN CAPITAL LETTER G WITH ACUTE U+01F5: LATIN SMALL LETTER G WITH ACUTE
U+021B: LATIN SMALL LETTER T WITH COMMA BELOW U+021A: LATIN CAPITAL LETTER T WITH COMMA BELOW
U+0226: LATIN CAPITAL LETTER A WITH DOT ABOVE U+0227: LATIN SMALL LETTER A WITH DOT ABOVE
U+1E09: LATIN SMALL LETTER C WITH CEDILLA AND ACUTE U+1E08: LATIN CAPITAL LETTER C WITH CEDILLA AND ACUTE
U+1E0F: LATIN SMALL LETTER D WITH LINE BELOW U+1E0E: LATIN CAPITAL LETTER D WITH LINE BELOW
U+1E1E: LATIN CAPITAL LETTER F WITH DOT ABOVE U+1E1F: LATIN SMALL LETTER F WITH DOT ABOVE
U+1E45: LATIN SMALL LETTER N WITH DOT ABOVE U+1E44: LATIN CAPITAL LETTER N WITH DOT ABOVE
U+1E6D: LATIN SMALL LETTER T WITH DOT BELOW U+1E6C: LATIN CAPITAL LETTER T WITH DOT BELOW
[code: missing-case-counterparts]
🔥 FAIL Font contains '.notdef' as its first glyph?
* 🔥 **FAIL**

The '.notdef' glyph should contain a drawing, but it is blank.

[code: notdef-is-blank]
🔥 FAIL Does METADATA.pb copyright field contain broken links?
* 🔥 **FAIL**

The following links are broken in the METADATA.pb file: http://www.vissol.co.uk/mavenpro/ (status code: 404)

[code: broken-links]
🔥 FAIL METADATA.pb: Check URL on copyright string is the same as in repository_url field.
* 🔥 **FAIL**

Repository URL is https://www.github.com/googlefonts/mavenproFont

But: font copyright string has 'http://www.vissol.co.uk/mavenpro', OFL text has 'http://www.vissol.co.uk/mavenpro' and HTML description has 'github.com/googlefonts/mavenproFont'

[code: mismatch]
🔥 FAIL Shapes languages in all GF glyphsets.
* 🔥 **FAIL**

GF_Latin_Core glyphset:

Language FAIL messages
nl_Latn (Dutch) Shaper didn't attach acutecomb to j
[code: failed-language-shaping]
🔥 FAIL Check Google Fonts glyph coverage.
* 🔥 **FAIL**

Missing required codepoints:

- 0x021A (LATIN CAPITAL LETTER T WITH COMMA BELOW)
[code: missing-codepoints]
⚠️ WARN Does the font have a DSIG table?
* ⚠️ **WARN**

This font has a digital signature (DSIG table) which is only required - even if only a placeholder - on old programs like MS Office 2013 in order to work properly. The current recommendation is to completely remove the DSIG table.

[code: found-DSIG]
⚠️ WARN Detect any interpolation issues in the font.
* ⚠️ **WARN**

Interpolation issues were found in the font:

- Contour 0 start point differs in glyph 'Lslash' between location wght=400 and location wght=900

- Contour 0 in glyph 'Lslash': becomes underweight between wght=400 and wght=900.
[code: interpolation-issues]
⚠️ WARN Check math signs have the same width.
* ⚠️ **WARN**

The most common width is 611 among a set of 2 math glyphs. The following math glyphs have a different width, though:

Width = 551: plus

Width = 660: less

Width = 638: equal

Width = 649: greater

Width = 622: logicalnot

Width = 585: plusminus

Width = 481: multiply

Width = 628: divide

Width = 566: minus

Width = 568: greaterequal, lessequal

[code: width-outliers]
⚠️ WARN Does the font contain a soft hyphen?
* ⚠️ **WARN**

This font has a 'Soft Hyphen' character.

[code: softhyphen]
⚠️ WARN Check font contains no unreachable glyphs
* ⚠️ **WARN**

The following glyphs could not be reached by codepoint or substitution rules:

- IJacute

- caronalt

- dotbelowcomb.case

- hookabovecomb.case

- ijacute

- uni03020309

- uni03060309

- uni031B.case

- uni0326.alt
[code: unreachable-glyphs]
⚠️ WARN Ensure dotted circle glyph is present and can attach marks.
* ⚠️ **WARN**

No dotted circle glyph present

[code: missing-dotted-circle]
⚠️ WARN Ensure soft_dotted characters lose their dot when combined with marks that replace the dot.
* ⚠️ **WARN**

The dot of soft dotted characters used in orthographies must disappear in the following strings: i̊ i̋ j̀ j́ j̃ j̄ j̈ j̑ į̀ į́ į̂ į̃ į̄ į̌ ị̀ ị́ ị̂ ị̃ ị̄

The dot of soft dotted characters should disappear in other cases, for example: i̇ i̛̇ i̛̊ i̛̋ i̤̇ i̤̊ i̤̋ i̦̇ i̦̊ i̦̋ i̧̇ i̧̊ i̧̋ i̮̇ i̮̊ i̮̋ i̱̇ i̱̊ i̱̋ i̵̇

Your font fully covers the following languages that require the soft-dotted feature: Lithuanian (Latn, 2,357,094 speakers).

Your font does not cover the following languages that require the soft-dotted feature: Dan (Latn, 1,099,244 speakers), Dii (Latn, 71,000 speakers), Bete-Bendi (Latn, 100,000 speakers), Avokaya (Latn, 100,000 speakers), Mfumte (Latn, 79,000 speakers), Ejagham (Latn, 120,000 speakers), Basaa (Latn, 332,940 speakers), Lugbara (Latn, 2,200,000 speakers), South Central Banda (Latn, 244,000 speakers), Bafut (Latn, 158,146 speakers), Nateni (Latn, 100,000 speakers), Southern Kisi (Latn, 360,000 speakers), Kom (Latn, 360,685 speakers), Dutch (Latn, 31,709,104 speakers), Cicipu (Latn, 44,000 speakers), Koonzime (Latn, 40,000 speakers), Navajo (Latn, 166,319 speakers), Kpelle, Guinea (Latn, 622,000 speakers), Ngbaka (Latn, 1,020,000 speakers), Fur (Latn, 1,230,163 speakers), Vute (Latn, 21,000 speakers), Ma’di (Latn, 584,000 speakers), Ijo, Southeast (Latn, 2,471,000 speakers), Yala (Latn, 200,000 speakers), Mundani (Latn, 34,000 speakers), Zapotec (Latn, 490,000 speakers), Ekpeye (Latn, 226,000 speakers), Makaa (Latn, 221,000 speakers), Gulay (Latn, 250,478 speakers), Ebira (Latn, 2,200,000 speakers), Sar (Latn, 500,000 speakers), Nzakara (Latn, 50,000 speakers), Mango (Latn, 77,000 speakers), Ukrainian (Cyrl, 29,273,587 speakers), Igbo (Latn, 27,823,640 speakers), Belarusian (Cyrl, 10,064,517 speakers), Aghem (Latn, 38,843 speakers).

[code: soft-dotted]
⚠️ WARN Copyright notice on METADATA.pb should not contain 'Reserved Font Name'.
* ⚠️ **WARN**

METADATA.pb: copyright field ("Copyright 2011 The Maven Pro Project Authors (http://www.vissol.co.uk/mavenpro/), with Reserved Font Name "Maven Pro".") contains "Reserved Font Name". This is an error except in a few specific rare cases.

[code: rfn]
⚠️ WARN Check for codepoints not covered by METADATA subsets.
* ⚠️ **WARN**

The following codepoints supported by the font are not covered by any subsets defined in the font's metadata file, and will never be served. You can solve this by either manually adding additional subset declarations to METADATA.pb, or by editing the glyphset definitions.

  • U+02C7 CARON: try adding one of: yi, tifinagh, canadian-aboriginal
  • U+02C9 MODIFIER LETTER MACRON: not included in any glyphset definition
  • U+02D8 BREVE: try adding one of: yi, canadian-aboriginal
  • U+02D9 DOT ABOVE: try adding one of: yi, canadian-aboriginal
  • U+02DB OGONEK: try adding one of: yi, canadian-aboriginal
  • U+02DD DOUBLE ACUTE ACCENT: not included in any glyphset definition
  • U+0302 COMBINING CIRCUMFLEX ACCENT: try adding one of: cherokee, math, tifinagh, coptic
  • U+0306 COMBINING BREVE: try adding one of: tifinagh, old-permic
  • U+0307 COMBINING DOT ABOVE: try adding one of: syriac, malayalam, old-permic, tai-le, math, tifinagh, coptic, canadian-aboriginal
  • U+030A COMBINING RING ABOVE: try adding syriac 61 more.

Use -F or --full-lists to disable shortening of long lists.

Or you can add the above codepoints to one of the subsets supported by the font: latin, latin-ext, menu, vietnamese

[code: unreachable-subsetting]
⚠️ WARN Check copyright namerecords match license file.
* ⚠️ **WARN**

Please consider using HTTPS URLs at name table entry [plat=3, enc=1, name=13]

[code: http-in-description] * ⚠️ **WARN**

Please consider updating the url from 'https://scripts.sil.org/OFL' to 'https://openfontlicense.org'.

[code: old-url]
⚠️ WARN License URL matches License text on name table?
* ⚠️ **WARN**

Please consider using HTTPS URLs at name table entry [plat=3, enc=1, name=13]

[code: http-in-description] * ⚠️ **WARN**

Please consider using HTTPS URLs at name table entry [plat=3, enc=1, name=13]

[code: http-in-description] * ⚠️ **WARN**

Please consider using HTTPS URLs at name table entry [plat=3, enc=1, name=13]

[code: http-in-description]
⚠️ WARN Name table strings must not contain the string 'Reserved Font Name'.
* ⚠️ **WARN**

Name table entry contains "Reserved Font Name" for a family name ("Maven Pro") that differs from the currently used family name (MavenPro), which is fine.

[code: legacy-familyname]
⚠️ WARN Is there kerning info for non-ligated sequences?
* ⚠️ **WARN**

GPOS table lacks kerning info for the following non-ligated sequences:

- f + i

- f + l
[code: lacks-kern-info]
⚠️ WARN Are there caret positions declared for every ligature?
* ⚠️ **WARN**

This font lacks caret position values for ligature glyphs on its GDEF table.

[code: lacks-caret-pos]
⚠️ WARN Ensure fonts have ScriptLangTags declared on the 'meta' table.
* ⚠️ **WARN**

This font file does not have a 'meta' table.

[code: lacks-meta-table]
⚠️ WARN Checking OS/2 achVendID.
* ⚠️ **WARN**

OS/2 VendorID value 'NONE' is not yet recognized. If you registered it recently, then it's safe to ignore this warning message. Otherwise, you should set it to your own unique 4 character code, and register it with Microsoft at https://www.microsoft.com/typography/links/vendorlist.aspx

[code: unknown]
ℹ️ INFO List all superfamily filepaths
* ℹ️ **INFO**

ofl/mavenpro

[code: family-path]
ℹ️ INFO Font contains all required tables?
* ℹ️ **INFO**

This font contains the following optional tables:

- loca

- prep

- GPOS

- GSUB

- gasp
[code: optional-tables]
ℹ️ INFO Does DESCRIPTION file contain a upstream Git repo URL?
* ℹ️ **INFO**

Found a git repo URL: https://github.com/googlefonts/mavenproFont

[code: url-found]
ℹ️ INFO Check for presence of an ARTICLE.en_us.html file
* ℹ️ **INFO**

This font doesn't have an ARTICLE.en_us.html file.

[code: missing-article]
ℹ️ INFO EPAR table present in font?
* ℹ️ **INFO**

EPAR table not present in font. To learn more see https://github.com/fonttools/fontbakery/issues/818

[code: lacks-EPAR]
ℹ️ INFO Familyname must be unique according to namecheck.fontdata.com
* ℹ️ **INFO**

The family name "MavenPro" seems to be already in use. Please visit http://namecheck.fontdata.com for more info.

[code: name-collision]
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering?
* ℹ️ **INFO**

These are the ppm ranges declared on the gasp table:

PPM <= 65535: flag = 0x0F - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType®

[code: ranges]
ℹ️ INFO Show hinting filesize impact.
* ℹ️ **INFO**

Hinting filesize impact:

ofl/mavenpro/MavenPro[wght].ttf
Dehinted Size 88.6kb
Hinted Size 88.6kb
Increase 24 bytes
Change 0.0 %
[code: size-impact]
ℹ️ INFO Font has old ttfautohint applied?
* ℹ️ **INFO**

Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 2.101']

[code: version-not-detected]
[1] Family checks
ℹ️ INFO Check axis ordering on the STAT table.
* ℹ️ **INFO**

None of the fonts lack a STAT table.

And these are the most common STAT axis orderings:
('wght', 1)
[code: summary]

Summary

💥 ERROR ☠ FATAL 🔥 FAIL ⚠️ WARN ⏩ SKIP ℹ️ INFO ✅ PASS 🔎 DEBUG
0 0 7 17 41 11 172 0
0% 0% 3% 7% 17% 4% 69% 0%

Note: The following loglevels were omitted in this report: